ibm-acpi-devel — ibm-acpi Linux driver development

Re: [ibm-acpi-devel] T60, R60, Z61 also may have the same issue

[Chris H. <cp...@cs...>]

Henrique de Moraes Holschuh wrote:
> I have just been told elsewhere in this thread by Chris Hanson that T60 with
> BIOS 2.x also have this bug, so I am also interested in T60 reports.

I've done a little testing and have some results now.

I built the ACPI video support as a module and patched it with the
acpi_video_get_next_level patch you sent out in this thread.

I'm using BIOS 2.07 / EC 1.07 on a T60p 2007-93U.

When I boot without the video module, Fn-Home and Fn-End work normally;
tpb gets the key events, shows the OSD, and video goes up and down as
expected.  When I load the (patched) video module, video continues to go
up and down, but tpb no longer shows OSD feedback.

The commands "echo {4,5} > /proc/acpi/ibm/cmos" work properly.
Strangely, when using these commands, tpb shows OSD feedback even with
the video module loaded.

I also played around with the ibm-acpi hotkey support.  From long ago, I
have a setting of "enabled,0xff9f"; I don't remember how I arrived at
that mask.  Changing the mask to 0xffff causes Fn-Home, Fn-End, and
Fn-F7 to start sending ACPI hotkey events.  Of course that means that
tpb no longer provides feedback.  I'll have to figure out if I can use
those events to support OSD feedback.

Re: [ibm-acpi-devel] [ltp] T60, R60, Z61 also may have the same issue

[Rob H. <rob...@gm...>]

On 12/31/06, Henrique de Moraes Holschuh <hm...@hm...> wrote:
> On Sun, 31 Dec 2006, Henrique de Moraes Holschuh wrote:
> > Well, I have finally got down to try to track the bug with brightness in X60
> > ThinkPads.
>  for me to take? for me to take?
> I have just been told elsewhere in this thread by Chris Hanson that T60 with
> BIOS 2.x also have this bug, so I am also interested in T60 reports.

I have a T60 with BIOS 2.1 and firmware 1.7 (according to dmidecode).
I am suffering from the problems you described in your earlier email.
Namely, fn-end and fn-home both work correctly to turn the brightness
up and down, but only fn-end (brightness down) is picked up by tpb.
fn-home generates the following acpi events:

Jan  1 09:46:23 calvin logger: ACPI event unhandled: ibm/hotkey HKEY
00000080 00001010
Jan  1 09:46:23 calvin logger: ACPI event unhandled: video LCD0
00000086 00000000

I do not have any confusion between fn-f7 and fn-home.  `echo {4,5} >
/proc/acpi/ibm/cmos` work correctly to turn brightness up and down,
and tpb displays the results of both.

Can you recommend any immediate course of action?

Thanks for your work.

-Rob


> It is likely that the R60 and Z61 with 2.x BIOS might have the same issue,
> so if you have any of these machines with a 2.x BIOS, please reply telling
> us whether it shows the brightness issue or not.
>
> Obviously, I am interested in answers to the X60 questions from onwers of
> *any* machine that has the problem, even if it is not a X60.
>
> --
>   "One disk to rule them all, One disk to find them. One disk to bring
>   them all and in the darkness grind them. In the Land of Redmond
>   where the shadows lie." -- The Silicon Valley Tarot
>   Henrique Holschuh
> --
> The linux-thinkpad mailing list home page is at:
> http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad
>

Re: [ibm-acpi-devel] [ltp] ibm-acpi ThinkPad X60 brightness support problems

[Henrique de M. H. <hm...@hm...>]

On Tue, 02 Jan 2007, Michael Reinsch wrote:
> > But here's something I expect might shed light on the issue: Video FOO 0x86
> > is trapped, and acted upon by the standard generic ACPI video module!
> > Please disable it (remove video.o module, or recompile kernel without
> > ACPI_VIDEO), and tell me what happens :-)
> 
> Hey, yeah, that fixed it! I unloaded the generic ACPI video module and
> the screen no longer goes dark when pressing Fn+Home. Everything else
> still seems to work...
> 
> Thanks, that is a good workaround until the issue is fixed.

Please try the attached patch from 2.6.20-rc2, and tell me if it fixes the
issue.  I don't know which kernel you're using, so I am not sure if it will
apply easily.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [ltp] ibm-acpi ThinkPad X60 brightness support problems

[Michael R. <mr...@uu...>]

Hi!

On 01.01.2007, 12:21 -0200 Henrique de Moraes Holschuh wrote:

> > > 	1. Fn+Home/fn+End *do* work, but tpb, KDE and other similar
> > > 	"ThinkPad CMOS snooping" things don't report Fn+Home (brightness up)
> > > 	anymore.
> >=20
> > Not sure about that one... well, see below.
>=20
> Can you get the ThinkPad to increase brightness using the keyboard in Lin=
ux?

The "not sure about that one" was referring to "ThinkPad CMOS snooping"
stopped working. Sorry about the confusion. The brightness keys still
work as before (at least in the console), just Fn+Home turns off the
screen.

I also just started tpb and it works as before. So this did not break.

> But here's something I expect might shed light on the issue: Video FOO 0x=
86
> is trapped, and acted upon by the standard generic ACPI video module!
> Please disable it (remove video.o module, or recompile kernel without
> ACPI_VIDEO), and tell me what happens :-)

Hey, yeah, that fixed it! I unloaded the generic ACPI video module and
the screen no longer goes dark when pressing Fn+Home. Everything else
still seems to work...

Thanks, that is a good workaround until the issue is fixed.

--=20
  Michael Reinsch <mr...@uu...>                      http://mr.uue.org/
------------------------------------------------------------------------

Re: [ibm-acpi-devel] [ltp] ibm-acpi ThinkPad X60 brightness support problems

[Henrique de M. H. <hm...@hm...>]

On Mon, 01 Jan 2007, Michael Reinsch wrote:
> Hello and a happy new year!
> 
> On 31.12.2006, 17:21 -0200 Henrique de Moraes Holschuh wrote:
> 
> > 	1. Fn+Home/fn+End *do* work, but tpb, KDE and other similar
> > 	"ThinkPad CMOS snooping" things don't report Fn+Home (brightness up)
> > 	anymore.
> 
> Not sure about that one... well, see below.

Can you get the ThinkPad to increase brightness using the keyboard in Linux?

This used to be done automatically by the BIOS, so you can test this with
ibm-acpi unloaded.

If you can, please send me the output of "cat /dev/nvram" just before, and
right after an increase and decrease in brightness done using the fn keys,
and also just before, and right after an increase and decrease in brightness
using the cmos ibm-acpi commands.

> > 	2. Lenovo changed the mappings and Fn+Home generates a hotkey event
> > 	that is the same as the fn+F7 one (switch monitor output), which
> > 	would explain all sort of weird behaviour if fn+F7 ain't safe in
> > 	your particular configuration.
> 
> This doesn't seem to be the case. This is what happens on my X60s:
> 
> - Fn+F7 produces "ibm/hotkey HKEY 00000080 00001007", which triggers a
> script to write into /proc/acpi/ibm/video (but which doesn't work with
> the X60 any more :( - but that is another issue). Pressing Fn+F7 itself
> does not trigger this issue.

Good.

> - Fn+Home actually produces two events:
>   1. ibm/hotkey HKEY 00000080 00001010
>   2. video LCD0 00000086 00000000

Well, HKEY 1010 is the standard thinkpad mapping for fn+Home.  So far so
good.  Does it go away if you set the ibm-acpi hotkey mask to 0x00 (it
should) ?

Video LCD0 0x86 0x0 is new, but there is nothing wrong with it...
it is "brightness up" (ACPI Spec 3.0a, page 577 and 582).

WTF does the ThinkPad ACPI BIOS does not generate events for brightness down
is anyone's guess (I think we may be missing something important in
ibm-acpi, but that's a *very* long standing issue, if true).

But here's something I expect might shed light on the issue: Video FOO 0x86
is trapped, and acted upon by the standard generic ACPI video module!
Please disable it (remove video.o module, or recompile kernel without
ACPI_VIDEO), and tell me what happens :-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] ibm-acpi 0.13-20061231 release available on sf.net

[Henrique de M. H. <hm...@hm...>]

I have just released 0.13-20061231 in patch format, using the
sourceforge.net file release system.

http://sourceforge.net/project/showfiles.php?group_id=117042

Changes since the last release are:
	* Support for Legacy Bay on the T60p and other advanced ultrabay
	machines in IDE mode

I will do the releases through sourceforge from now on to avoid issues with
mailinglist archives.

The releases are also tagged in the git repository, now.

Enjoy!

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] T60, R60, Z61 also may have the same issue

[Evgeni G. <sar...@di...>]

On Sun, 31 Dec 2006 20:34:07 -0200 Henrique de Moraes Holschuh wrote:

> > NACK for Z61m with latest BIOS. Fn+Home/End works, and tpb reports
> > correctly.
> 
> Just checking: You are at BIOS 7FET94WW (2.12), correct? It was
> released 2006-12-18.

Uh, 2.12 is out? Okay, I'm on 2.11, will try 2.12 tomorrow, when I'm
back from the new-year-party here ;)
So NACK for 2.11, not 2.12...

Regards

-- 
   ^^^    | Evgeni -SargentD- Golov (sar...@di...)
 d(O_o)b  | PGP-Key-ID: 0xAC15B50C
  >-|-<   | WWW: http://www.die-welt.net   ICQ: 54116744
   / \    | IRC: #sod @ irc.german-freakz.net

Re: [ibm-acpi-devel] T60, R60, Z61 also may have the same issue

[Henrique de M. H. <hm...@hm...>]

On Sun, 31 Dec 2006, Evgeni Golov wrote:
> On Sun, 31 Dec 2006 18:07:45 -0200 Henrique de Moraes Holschuh wrote:
> > It is likely that the R60 and Z61 with 2.x BIOS might have the same
> > issue, so if you have any of these machines with a 2.x BIOS, please
> > reply telling us whether it shows the brightness issue or not.
> 
> NACK for Z61m with latest BIOS. Fn+Home/End works, and tpb reports
> correctly.

Just checking: You are at BIOS 7FET94WW (2.12), correct? It was released
2006-12-18.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] T60, R60, Z61 also may have the same issue

[Evgeni G. <sar...@di...>]

On Sun, 31 Dec 2006 18:07:45 -0200 Henrique de Moraes Holschuh wrote:

> It is likely that the R60 and Z61 with 2.x BIOS might have the same
> issue, so if you have any of these machines with a 2.x BIOS, please
> reply telling us whether it shows the brightness issue or not.

NACK for Z61m with latest BIOS. Fn+Home/End works, and tpb reports
correctly.

regards
Evgeni

-- 
   ^^^    | Evgeni -SargentD- Golov (sar...@di...)
 d(O_o)b  | PGP-Key-ID: 0xAC15B50C
  >-|-<   | WWW: http://www.die-welt.net   ICQ: 54116744
   / \    | IRC: #sod @ irc.german-freakz.net

[ibm-acpi-devel] T60, R60, Z61 also may have the same issue

[Henrique de M. H. <hm...@hm...>]

On Sun, 31 Dec 2006, Henrique de Moraes Holschuh wrote:
> Well, I have finally got down to try to track the bug with brightness in X60
> ThinkPads.

I have just been told elsewhere in this thread by Chris Hanson that T60 with
BIOS 2.x also have this bug, so I am also interested in T60 reports.

It is likely that the R60 and Z61 with 2.x BIOS might have the same issue,
so if you have any of these machines with a 2.x BIOS, please reply telling
us whether it shows the brightness issue or not.

Obviously, I am interested in answers to the X60 questions from onwers of
*any* machine that has the problem, even if it is not a X60.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] ibm-acpi ThinkPad X60 brightness support problems

[Henrique de M. H. <hm...@hm...>]

On Sun, 31 Dec 2006, Chris Hanson wrote:
> This is also a problem with the 2.x versions of the T60 BIOS, so that's
> a larger pool of people who can help.  I can provide help, and I'm
> willing to write to Lenovo to complain.

This probably means ALL 2.x BIOSes in *60 and *61 are an issue.  This does
not bode well.  OTOH, some T60 owners *can* raise hell with Lenovo for
breaking Linux support, which will help later on.

> The 2.x versions also has the problem that causes the two processors to
> be controlled together when doing frequency scaling; in the 1.x the
> processors are handled independently.  My limited research seems to
> indicate that this is an ACPI problem.

This is a separate issue, so let's start another thread to talk about it.
And again, please remember you CAN report it as a bug to Lenovo.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] ibm-acpi ThinkPad X60 brightness support problems

[Chris H. <cp...@cs...>]

Henrique de Moraes Holschuh wrote:
> Therefore, we are stuck with properly identifying the bug, and then flooding
> Lenovo with complains from X60 owners still under warranty, requesting a
> fix.  I will add workarounds to ibm-acpi, if one is possible, but we don't
> know much about that yet.
> 
> Obviously, I will need help from X60 owners as I cannot reproduce the
> problem without a X60.

This is also a problem with the 2.x versions of the T60 BIOS, so that's
a larger pool of people who can help.  I can provide help, and I'm
willing to write to Lenovo to complain.

The 2.x versions also has the problem that causes the two processors to
be controlled together when doing frequency scaling; in the 1.x the
processors are handled independently.  My limited research seems to
indicate that this is an ACPI problem.

[ibm-acpi-devel] ibm-acpi ThinkPad X60 brightness support problems

[Henrique de M. H. <hm...@hm...>]

Well, I have finally got down to try to track the bug with brightness in X60
ThinkPads.

And, well, whatever Lenovo did on the X60 that broke the brightness support,
it doesn't look like it was in the ACPI tables.  That means BIOS and/or EC
firmware, which is not something I am going to attempt to fix, unless
someone gives me a X60 as a gift ;-)

Therefore, we are stuck with properly identifying the bug, and then flooding
Lenovo with complains from X60 owners still under warranty, requesting a
fix.  I will add workarounds to ibm-acpi, if one is possible, but we don't
know much about that yet.

Obviously, I will need help from X60 owners as I cannot reproduce the
problem without a X60.

Problem description, as I understood it:

	1. Fn+Home/fn+End *do* work, but tpb, KDE and other similar
	"ThinkPad CMOS snooping" things don't report Fn+Home (brightness up)
	anymore.

	2. Lenovo changed the mappings and Fn+Home generates a hotkey event
	that is the same as the fn+F7 one (switch monitor output), which
	would explain all sort of weird behaviour if fn+F7 ain't safe in
	your particular configuration.

So, let's start with a few question for X60 owners with BIOS 2.x:

First, did I understood the problem correctly?  Do you have any extra
information on the issue?

Remember that if fn+Home is indeed causing fn+F7 events, something in your
system may well react to fn+F7 (and thus, also to fn+Home now), and, e.g.,
hang X *hard* trying to switch from the internal display to the external
output.  So have a look on the ThinkWiki pages about video output switching
before you report back any sort of weird behaviour that could be explained
by *that*.

Second, please set the ibm-acpi hotkey mask to 0xffff, and tell me what
events fn+Home, fn+End and fn+F7 are generating (probably it is safer to do
this from the console).

Third, please tell me if "echo 4 > /proc/acpi/ibm/cmos" (brightness up) and
"echo 5 > /proc/acpi/ibm/cmos" (brightness down) works.

Fourth, if you disable the bit for fn+F7 in the hotkey mask, what happens to
fn+F7 and fn+Home ? and if you enable it, what happens to fn+F7 an fn+Home?
(again, be careful if this would cause video output port switching, try it
from the console).

I am directing replies to this thread to the ibm-acpi-devel mailinglist.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] Add Ultrabay support for the T60p Thinkpad

[Henrique de M. H. <hm...@hm...>]

Whoopie from ThinkWiki just sent me an email, calling my attention to the
fact that the patch you submitted is in fact different from the one I
merged... something I should have triple-verified.  It appears the t60p has
the bay in a different ACPI node than some other *60 ThinkPads.  Either
that, or the node moves depending on ICHR mode set in the BIOS.

So I apologise for the screw up, and:

Acked-by: Henrique de Moraes Holschuh <hm...@hm...>

I am merging your patch into the ibm-acpi tree and will ask Len to push it
to Linus.  Now, please excuse me while I go look for a new brown-paperbag
hat...

On Sun, 10 Dec 2006, Theodore Ts'o wrote:
> Add Ultrabay Support for the T60p Thinkpad
> 
> The following patch adds support for obtaining the status and ejecting
> Ultrabay devices for the T60p Thinkpad; my guess is that it probably
> works on T60 Thinkpads and probably more recent Lenovo latops as well.
> 
> With the 2.03 BIOS I have been able to eject a SATA drive in an Ultrabay
> carrier by using the command:
> 
>   "echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"
> 
> and upon re-inserting the it back into the device and issuing the
> command:
> 
>  "echo 0 0 0 > /sys/class/scsi_host/host1/scan"
> 
> have the device appear again.  (With the 1.02 BIOS the device does not
> function when re-inserted, even after a warm boot; a cold reboot is
> required to store the Ultrabay device's functionality.)
> 
> More complicated Ultrabay eject and insert scripts can be found on the
> ThinkWiki, although it's important to comment out the "hdparm -Y" as it
> apparently doesn't work or do anything, and causes the eject process to
> hang for about a minute.
> 
> Signed-off-by: "Theodore Ts'o" <ty...@mi...>
> 
> Index: 2.6.19/drivers/acpi/ibm_acpi.c
> ===================================================================
> --- 2.6.19.orig/drivers/acpi/ibm_acpi.c	2006-12-09 18:35:09.000000000 -0500
> +++ 2.6.19/drivers/acpi/ibm_acpi.c	2006-12-09 18:35:42.000000000 -0500
> @@ -169,6 +169,7 @@
>  #endif
>  IBM_HANDLE(bay, root, "\\_SB.PCI.IDE.SECN.MAST",	/* 570 */
>  	   "\\_SB.PCI0.IDE0.IDES.IDSM",	/* 600e/x, 770e, 770x */
> +	   "\\_SB.PCI0.IDE0.PRIM.MSTR",	/* T60p */
>  	   "\\_SB.PCI0.IDE0.SCND.MSTR",	/* all others */
>      );				/* A21e, R30, R31 */
>  

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] [PATCH] ibm-acpi: latest version for 2.6.18 and 2.6.19

[Henrique de M. H. <hm...@hm...>]

Well, I am taking my sweet time to release a tarball, so now that ibm-acpi
is in 2.6.20-rc2, here are the patches.

Enjoy!

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] ACPI: ibm-acpi: fix Kconfig entries for ibm-acpi bay and dock

[Henrique de M. H. <hm...@hm...>]

On Sat, 30 Dec 2006, Henrique de Moraes Holschuh wrote:
> Support for ACPI_BAY has not been merged in mainline yet.  Usage of
> "depends on FOO=n" fails if FOO is undefined, thus ibm-acpi support
> for bay was being made non-available in a kernel that has no other
> sort of bay support.
> 
> Fix it to use "depends on ! FOO" instead, that does the right thing
> when FOO is undefined.  Fix ACPI_IBM_DOCK accordingly as well while
> at it, and also improve the help text.

Either this patch, or a different fix (see below), should to be sent to
Linus.  Otherwise, it causes a regression (lack of removable bay support in
ibm-acpi).

Unfortunately, I didn't notice the problem before because I had ACPI_BAY
applied to my 2.6.18 and 2.6.19 test trees.

The patch uses "depends on ! FOO", which means the legacy support in
ibm-acpi can be selected if ACPI_DOCK or ACPI_BAY is set to "m" (module).
Loading ACPI_DOCK or ACPI_BAY module along with ibm-acpi and ACPI_IBM_DOCK
or ACPI_IBM_BAY could cause weird behaviour (untested) on some systems.

There are alternate ways to fix this.  The easiest would be to revert commit
2df910b4c3edcce9a0c12394db6f5f4a6e69c712 from Linus' tree, and I'd submit it
again when ACPI_BAY is ready to be sent to mainline.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] [PATCH] ACPI: ibm-acpi: fix Kconfig entries for ibm-acpi bay and dock

[Henrique de M. H. <hm...@hm...>]

From: Henrique de Moraes Holschuh <hm...@hm...>

Support for ACPI_BAY has not been merged in mainline yet.  Usage of
"depends on FOO=3Dn" fails if FOO is undefined, thus ibm-acpi support
for bay was being made non-available in a kernel that has no other
sort of bay support.

Fix it to use "depends on ! FOO" instead, that does the right thing
when FOO is undefined.  Fix ACPI_IBM_DOCK accordingly as well while
at it, and also improve the help text.

Signed-off-by: Henrique de Moraes Holschuh <hm...@hm...>
---

 drivers/acpi/Kconfig |   17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index aa884d8..95de81f 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -213,26 +213,29 @@ config ACPI_IBM
 config ACPI_IBM_DOCK
 	bool "Legacy Docking Station Support"
 	depends on ACPI_IBM
-	depends on ACPI_DOCK=3Dn
-	default n
+	depends on ! ACPI_DOCK
+	default y
 	---help---
 	  Allows the ibm_acpi driver to handle docking station events.
 	  This support is obsoleted by CONFIG_HOTPLUG_PCI_ACPI.  It will
 	  allow locking and removing the laptop from the docking station,
 	  but will not properly connect PCI devices.
=20
-	  If you are not sure, say N here.
+	  If you are not sure, select ACPI_DOCK instead.
=20
 config ACPI_IBM_BAY
 	bool "Legacy Removable Bay Support"
 	depends on ACPI_IBM
-	depends on ACPI_BAY=3Dn
-	default n
+	depends on ! ACPI_BAY
+	default y
 	---help---
 	  Allows the ibm_acpi driver to handle removable bays.
-	  This support is obsoleted by CONFIG_ACPI_BAY.
+	  This support is obsoleted by CONFIG_ACPI_BAY.  It will allow
+	  enabling and disabling devices in the removable bays, but it
+	  will not properly add or remove the devices from the kernel,
+	  which must be done manually by userspace scripts.
=20
-	  If you are not sure, say N here.
+	  If you are not sure, select ACPI_BAY instead if it is available.
=20
 config ACPI_TOSHIBA
 	tristate "Toshiba Laptop Extras"


-- =20
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH] ACPI: ibm_acpi: allow clean removal

[Len B. <le...@ke...>]

Applied.

thanks,
-Len

On Monday 18 December 2006 12:53, Henrique de Moraes Holschuh wrote:
> From: Alexey Starikovskiy <ale...@li...>
> 
> Allow clean removal by setting notify_installed in the right place.
> 
> Alexey Starikovskiy <ale...@in...>
> Signed-off-by: Henrique de Moraes Holschuh <hm...@hm...>
> Signed-off-by: Len Brown <len...@in...>
> ---
> 
>  drivers/acpi/ibm_acpi.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
> index 003a987..719a320 100644
> --- a/drivers/acpi/ibm_acpi.c
> +++ b/drivers/acpi/ibm_acpi.c
> @@ -1805,7 +1805,7 @@ static int __init setup_notify(struct ibm_struct *ibm)
>  		       ibm->name, status);
>  		return -ENODEV;
>  	}
> -
> +	ibm->notify_installed = 1;
>  	return 0;
>  }
>  
> @@ -1882,7 +1882,6 @@ static int __init ibm_init(struct ibm_struct *ibm)
>  		ret = setup_notify(ibm);
>  		if (ret < 0)
>  			return ret;
> -		ibm->notify_installed = 1;
>  	}
>  
>  	return 0;
> 
> 
> --  
>   "One disk to rule them all, One disk to find them. One disk to bring
>   them all and in the darkness grind them. In the Land of Redmond
>   where the shadows lie." -- The Silicon Valley Tarot
>   Henrique Holschuh
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to maj...@vg...
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [ibm-acpi-devel] Thinkpad X60s brightness button

[John F. <jf...@ui...>]

On Sun, 2006-12-17 at 19:56 -0200, Henrique de Moraes Holschuh wrote:
> Regression caused by a new BIOS from Lenovo, and I have not had the time to
> look into it yet.

Ok, I will anxiously await your appraisal.

Thanks,
John

[ibm-acpi-devel] [PATCH] ACPI: ibm_acpi: allow clean removal

[Henrique de M. H. <hm...@hm...>]

From: Alexey Starikovskiy <ale...@li...>

Allow clean removal by setting notify_installed in the right place.

Alexey Starikovskiy <ale...@in...>
Signed-off-by: Henrique de Moraes Holschuh <hm...@hm...>
Signed-off-by: Len Brown <len...@in...>
---

 drivers/acpi/ibm_acpi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 003a987..719a320 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -1805,7 +1805,7 @@ static int __init setup_notify(struct ibm_struct *i=
bm)
 		       ibm->name, status);
 		return -ENODEV;
 	}
-
+	ibm->notify_installed =3D 1;
 	return 0;
 }
=20
@@ -1882,7 +1882,6 @@ static int __init ibm_init(struct ibm_struct *ibm)
 		ret =3D setup_notify(ibm);
 		if (ret < 0)
 			return ret;
-		ibm->notify_installed =3D 1;
 	}
=20
 	return 0;


-- =20
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] [GIT PULL][PATCH] ibm-acpi: patch queue for acpi-test

[Henrique de M. H. <hm...@hm...>]

Please pull from the ibm-acpi-devel git tree at:
git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git

branch for-upstream/acpi-test, to receve this patch series.

This series contains just one patch that was dropped from acpi-test
for some unknown reason.  It is the same patch I submitted for 2.6.20
and 2.6.19 in a separate message.

	ACPI: ibm_acpi: allow clean removal

--=20
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] [PATCH 1/2] ACPI: ibm-acpi: add support for the ultrabay on the T60, X60

[Henrique de M. H. <hm...@hm...>]

From: Henrique de Moraes Holschuh <hm...@hm...>

This patch adds support for the ultrabay on the T60, X60 and other new
ThinkPads that have a SATA ultrabay.

I intend to keep bay and dock support in ibm-acpi working and updated unt=
il
it finally gets deprecated and removed in favour of the generic dock and
bay support.  But we aren't there yet.

Signed-off-by: Henrique de Moraes Holschuh <hm...@hm...>
---

 drivers/acpi/ibm_acpi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 003a987..4a9f3bf 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -169,6 +169,7 @@ IBM_HANDLE(dock, root, "\\_SB.GDCK",	/* X30, X31, X40=
 */
 #endif
 IBM_HANDLE(bay, root, "\\_SB.PCI.IDE.SECN.MAST",	/* 570 */
 	   "\\_SB.PCI0.IDE0.IDES.IDSM",	/* 600e/x, 770e, 770x */
+	   "\\_SB.PCI0.SATA.SCND.MSTR",	/* T60, X60, Z60 */=20
 	   "\\_SB.PCI0.IDE0.SCND.MSTR",	/* all others */
     );				/* A21e, R30, R31 */
=20


-- =20
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] [PATCH 2/2] ACPI: ibm_acpi: allow clean removal

[Henrique de M. H. <hm...@hm...>]

From: Alexey Starikovskiy <ale...@li...>

Allow clean removal by setting notify_installed in the right place.

Alexey Starikovskiy <ale...@in...>
Signed-off-by: Henrique de Moraes Holschuh <hm...@hm...>
Signed-off-by: Len Brown <len...@in...>
---

 drivers/acpi/ibm_acpi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
index 4a9f3bf..025a9f9 100644
--- a/drivers/acpi/ibm_acpi.c
+++ b/drivers/acpi/ibm_acpi.c
@@ -1806,7 +1806,7 @@ static int __init setup_notify(struct ibm_struct *i=
bm)
 		       ibm->name, status);
 		return -ENODEV;
 	}
-
+	ibm->notify_installed =3D 1;
 	return 0;
 }
=20
@@ -1883,7 +1883,6 @@ static int __init ibm_init(struct ibm_struct *ibm)
 		ret =3D setup_notify(ibm);
 		if (ret < 0)
 			return ret;
-		ibm->notify_installed =3D 1;
 	}
=20
 	return 0;


-- =20
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

[ibm-acpi-devel] [GIT PULL][PATCH 0/2] ibm-acpi: Series short description

[Henrique de M. H. <hm...@hm...>]

Please pull from the ibm-acpi-devel git tree at:
git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git

branch for-upstream/acpi-release, to receve this patch series.

The following series contains two patches that should be merged for 2.6.2=
0,
and also 2.6.19.y (thus stable@korg is also cc'ed).

    ACPI: ibm_acpi: allow clean removal
        Without this patch, rmmod'ing ibm-acpi is a Bad Idea.  This patch
        was already in acpi-test, and was dropped for some unknown reason=
.
=09
	I will re-submit it for acpi-test as well.

    ACPI: ibm-acpi: add support for the ultrabay on the T60,X60
        Tested patch that adds support for the T60, X60 and other ThinkPa=
ds
        with a SATA Advanced Ultrabay.

	This patch is already in the acpi-test tree.

--=20
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] Thinkpad X60s brightness button

[Henrique de M. H. <hm...@hm...>]

On Fri, 15 Dec 2006, John Fettig wrote:
> It seems something is wrong with the way ibm_acpi is interpreting the Fn
> +Home combo which is supposed to be "brightness up" on this laptop.
> When I press it while Xorg is running, it crashes (or at the very least,
> blanks).  When I press it while in a VT, it works fine.  If I stop acpi
> and then press it, it still works fine.  I'm not sure exactly where the
> bug is, and I suspect there are multiple across different packages.  I
> created a bug report at 
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=9355
> 
> Any help?

Regression caused by a new BIOS from Lenovo, and I have not had the time to
look into it yet.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh