Re: [Iaxclient-devel] iaxComm PATCH: codec indication and selection

[Steve K. <st...@st...>]

Richard Hirst wrote:

>Hi,
>  I'm new to VoIP, but I've been experimenting with iaxComm on linux.
>I wanted to control which codec was used without having to change my
>asterisk config each time, so I came up with this patch.  It does
>two things:
>
>1) On the display, after the remote party name, if displays the codec
>   in use for this call.. e.g.    asterisk/4567 [ULAW]
>
>2) It adds a preference tab to enable specific codecs.  This offers
>   SPEEX, GSM, ALAW, ULAW at the moment, all enabled by default.  It
>   sets the preferred codec for a call to whichever is the first enabled
>   one in that list.
>
>To get the codec in use, I enhanced struct iaxc_ev_call_state to include
>a format field.  That may be a problem if changing the library interface
>is not allowed.  If so, maybe there is some other way to get that info,
>or we could add a new library function to request it.
>
>Anyway, let me know what you think,
>  
>
All the changes look good to me, but I'll let michael comment on the 
application changes.

Adding a field to the event structure in the library shouldn't be a 
problem.   It would still be backwards source-compatible.  I think if 
you add format _after_ all the other fields, though, it should keep 
binary compatibility, but I haven't been very concerned with that yet.  
I think the library is still young enough to handle this.

>(not on the list, so please cc me on replies)
>  
>
I am CC'ing you, but you should join the list if it interests you.  It's 
a pretty low-volume list..

-SteveK