Re: [Iaxclient-devel] Next to Audio Caller problem

[Steve K. <st...@st...>]

On Nov 7, 2004, at 8:27 PM, Michael Van Donselaar wrote:

>  <snip>
>
>>> The same for the current used codec.
>>
>> I'm not sure what you mean here.  I won't make iLBC the default,
>> because it is not free.
>>
>> Both of these things could be made options configurable from the
>> Makefile, though.
>
> We need to add IAX_FORMAT_ILBC to audio_format_capability in
> iaxclient_lib.c, if  we have ILBC defined in the Makefile.  I can post 
> the
> change to CVS.

OK

> Would it be acceptable if I also did:
>
> #ifdef CODEC_ILBC
> audio_format_preferred = IAXC_FORMAT_ILBC
> #else
> audio_format_preferred = IAXC_FORMAT_SPEEX
> #endif
>
> I'm suggesting that if ILBC is compiled in, it's also preferred.


Personally, I prefer speex, but I suspect that I'd lose in a vote.  
Maybe after I add the code to select and control the VBR modes from 
speex, I'd be able to change minds.  So, while it's pretty trivial for 
people to change this in their implementations, and I'd prefer to 
encourage people to use and contribute to speex, I won't veto this.

-SteveK