Re: [Iaxclient-devel] libiax2/iaxclient format negotiation

[Steve K. <st...@st...>]

Mikael Magnusson wrote:

> Steve Kann wrote:
>
>>
> ...
>
>>
>> libiax2 API:
>>
>> Add params to iax_call to set format and capability.
>> Add param to iax_accept to tell it what format we want.
>>
>> -extern int iax_call(struct iax_session *session, char *cidnum, char 
>> *cidname, char *ich, char *lang, int wait);
>> -extern int iax_accept(struct iax_session *session);
>> +extern int iax_call(struct iax_session *session, char *cidnum, char 
>> *cidname, char *ich, char *lang, int wait, int format, int capability);
>> +extern int iax_accept(struct iax_session *session, int format);
>>
>> Let me know what you think..
>>
>> I've only tested this on one outgoing calls, so a review and testing 
>> is in order..
>
> ...
>
>>
>
> Will you send a patch to the libiax2 author? And will it be backward 
> compatible, or will it require source modifications?
>
> I'm concerned since I have packaged iaxclient for Debian and I'm using 
> a shared libiax2 library instead of statically linking with libiax2 
> that is distributed in iaxclient. The libiax2 used comes from the cvs 
> at cvs.digium.com, because they haven't released any real versions yet.
>
> Regards,
> Mikael Magnusson


Yes, I plan to send this, along with 2 other patches, back to Digium, 
later this week.

I do remember what you have done, and I haven't incorporated your patch 
for building, but I've kept it in mind, and I hope I haven't made it 
harder for you to package (for example, I now build more of the speex 
library with iaxclient, but I put all the libspeex objs in a separate 
place in the Makefile, so your patch to the Makefile should be cleaner)..

The standard flags (using speex, GSM, and uLaw) should be right for you, 
because I'm sure that iLBC does not meet DFSG, and cannot be in Debian..

-SteveK