Re: [Iaxclient-devel] iaxclient_lib small fix

[Steve K. <st...@st...>]

Thanks Dmitry.

It was also wrong in the IAX1 case, although I don't even know if the 
IAX1 stuff even compiles anymore.

Just out of curiosity, what are you doing that actually causes this case 
to happen?  It would only happen, if you were using frames > 20ms long.

I'm actually thinking of making an option for iaxclient to use larger 
frames, because it uses much less bandwidth, but the tradeoff is 
slightly longer latency, and also more perceptible glitches when there's 
a frame dropped, etc.

-SteveK


Dmitry Mishchenko wrote:

>Hello,
>
>In iaxclient_lib.c in handle_audio_event sub there is a code:
>
>#ifdef IAXC_IAX2
>        while(total_consumed < e->datalen) {
>                cur = decode_audio(call, fr,
>                    e->data,e->datalen-total_consumed,
>                    iEncodeType);
>#else
>
>It should be replaced with:
>
>#ifdef IAXC_IAX2
>        while(total_consumed < e->datalen) {
>                cur = decode_audio(call, fr,
>                    e->data+total_consumed,e->datalen-total_consumed,
>                    iEncodeType);
>#else
>
>It gives more clear audio when "while" construction actually working.
>
>Dmitry
>
>
>
>-------------------------------------------------------
>This SF.Net email sponsored by Black Hat Briefings & Training.
>Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
>digital self defense, top technical experts, no vendor pitches, 
>unmatched networking opportunities. Visit www.blackhat.com
>_______________________________________________
>Iaxclient-devel mailing list
>Iax...@li...
>https://lists.sourceforge.net/lists/listinfo/iaxclient-devel
>
>  
>