Re: [Iaxclient-devel] iaxc_shutdown MUTEX deadlock

[Steve K. <st...@st...>]

S wrote:

> Hi All,
>
> in the iaxclient_lib.c the function void iaxc_shutdown() has a MUTEX
> deadlock.
> In the function iaxc_shutdown() is a call to iaxc_dump_all_calls() 
> which also try to get the MUTEX iaxc_lock.
>
> Dead lock code :
> void iaxc_shutdown(){
>      MUTEXLOCK(&iaxc_lock);
>      iaxc_dump_all_calls();
>
>      audio.destroy(&audio);
>
>      MUTEXUNLOCK(&iaxc_lock);
>      MUTEXDESTROY(&iaxc_lock);
> }
>
> FIX : No Dead lock :
>
> void iaxc_shutdown()
> {
>      iaxc_dump_all_calls();
>
>      MUTEXLOCK(&iaxc_lock);
>
>      audio.destroy(&audio);
>
>      MUTEXUNLOCK(&iaxc_lock);
>      MUTEXDESTROY(&iaxc_lock);
> }
>
> Regard's
>
>   Stephan

Thanks, Stephan.

That's a good change, although I think there may be other bugs in 
iaxc_shutdown.  (I don't think most clients are using it right now?).

-SteveK

P.S.  I guess that adds to the number of Steve's in the project again, eh?