[Iaxclient-devel] libiax2 moh patch

[Andrea S. <si...@op...>]

Hi all,

as far as I can see from comment below (quoting iaxclient.h):

/*!
         Causes the audio channel for \a callNo to QUELCH (be squelched).
         \param callNo The number of the active, accepted call to quelch.
         \param MOH If non-zero Music On Hold should be played on the QUELCH'd call.
*/
EXPORT int iaxc_quelch(int callNo, int MOH);

iaxc_quelch should do different things depending on MOH value, but going
one level down I discovered that iaxc_quelch is a wrapper around
int iax_quelch_moh(session, MOH) that is a libiax2 function.

but looking at the code it seems to me that despite the check for
non-zero value of MOH (and setting of session->transfer_moh to 1 if true)
in every case

send_command(session, AST_FRAME_IAX, IAX_COMMAND_QUELCH, 0, ied.buf, ied.pos);

is called, whereas it seems to me that in case of MOH == 0 we should use

send_command(session, AST_FRAME_IAX, IAX_COMMAND_QUELCH, 0, NULL, 0);

is it correct? am I missing something obvious? (maybe yes:)

or should be better to check for MOH value in iaxc_quelch (iaclient_lib.c)
and call iax_quelch_moh if (!MOH) or iax_quelch otherwise?


Andrea