[Iaxclient-cvs] SF.net SVN: iaxclient:[1450] branches/team/elbunce/iaxclient/lib/libiax2/ src/iax.c

[<sb...@us...>]

Revision: 1450
          http://iaxclient.svn.sourceforge.net/iaxclient/?rev=1450&view=rev
Author:   sbalea
Date:     2008-08-26 17:59:03 +0000 (Tue, 26 Aug 2008)

Log Message:
-----------
Fix crash in iax_handle_vnak caused by Pete's code cleanup changes.
Hint: the NULL check will short circuit the rest of the expression if item->next is NULL,
thus avoiding crashage

Modified Paths:
--------------
    branches/team/elbunce/iaxclient/lib/libiax2/src/iax.c

Modified: branches/team/elbunce/iaxclient/lib/libiax2/src/iax.c
===================================================================
--- branches/team/elbunce/iaxclient/lib/libiax2/src/iax.c	2008-08-06 00:48:54 UTC (rev 1449)
+++ branches/team/elbunce/iaxclient/lib/libiax2/src/iax.c	2008-08-26 17:59:03 UTC (rev 1450)
@@ -2463,11 +2463,8 @@
 					struct iax_sched *item = retrans_list;
 					while ( item != NULL )
 					{
-						const unsigned char next_seqno =
-							item->next->frame->oseqno -
-							session->rseqno;
 						if ( item->next == NULL ||
-						     next_seqno > frame_seqno
+						     item->next->frame->oseqno - session->rseqno > frame_seqno
 						   )
 						{
 							tmp->next = item->next;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.