Re: [Iaxclient-devel] v2.1beta3 need patch ?

[Jean-François G. <jf....@sq...>]

Hi Pete,

Peter Grayson a écrit :
> Hi Jean-François,
>
> On Wed, Apr 16, 2008 at 2:18 PM, Jean-François Guchens
> <jf....@sq...> wrote:
>   
>> I think i've found a bug in iaxclient_lib.c :
>>  Line 1168 need to be commented. (calls[callNo].state |=
>>  IAXC_CALL_STATE_COMPLETE;)
>>     
>
> This behavior has been in iaxclient for a very long time. I will need
> more information to be convinced that the semantic here is wrong.
>
>   
ok
>>  Else when receiving an incoming call the call state is always marked as
>>  complete.
>>     
>
> Could you describe the exact scenario? I'm not sure I understand what
> the problem is. It seems like this may be related to what Ruslan
> reported earlier this week -- have you read that thread?
>
> Does this affect calls directly between iaxclient applications?
>
>   
No i didn't read this report, i'm new on iaxclient ML :-)

Here my output :
Incoming call :
 ============== STATE :  active  ringing !free : 10                      
-> ringing
 ============== STATE :  active  complete !free : 18                   
-> answered
 ============== STATE :  active  complete  selected !free : 50   -> selected

Outgoing call:
IAXCLIENT: Originating an audio only call
 ============== STATE :  outgoing  active  selected !free : 
38                    -> sending packet
IAXCLIENT: Failed video codec negotiation.
IAXCLIENT: Call 0 accepted
 ============== STATE :  outgoing  active  selected !free : 
38                    -> receive ack
IAXCLIENT: Call 0 answered
 ============== STATE :  outgoing  active  selected  ringing !free : 
46      -> ringing
IAXCLIENT: Call 0 ringing
 ============== STATE :  outgoing  active  complete  selected !free : 
54   -> complete

I test IAXC_CALL_STATE_* and print the call.state value. Don't pay 
attention to !free.

This calls are made between an iaxclient app i develop and a very basic 
phone plugged on a TDM11b, through asterisk  1.4.17.

As you can see the COMPLETE flag appear, and it's at the right time.
Before my ""patch"", this flag was alway here on outgoing calls. I think 
it's just a flag of iaxclient lib, and this don't change anything on IAX 
protocol communication.

jf
>>  I patched my local version and it works fine now.
>>     
>
> What about for calls going through asterisk?
>
> It seems like if you made an outbound call with iaxclient this change
> would prevent the call from ever getting to the completed state.
>
> Pete
>