Re: [Iaxclient-devel] novideo_dll

[Peter G. <jpg...@gm...>]

Hi Steve,

I've applied both of these patches. Thanks again for all your help lately!

The VS2005 changes were good.

My preference for the iaxcomm VS project would have been to have those
exist in the contrib/win/vs2005 directory, but since I don't use or
build iaxcomm, I defer to those of you who do use iaxcomm for where
you'd like the project/solution files to live.

Pete

On Sun, Apr 6, 2008 at 4:26 PM, stevebvt <ste...@gm...> wrote:
> iaxclient added post build step to copy iaxclientlib.dll in the dll configs
> for testcall/vtestcall
>  iaxcomm added other configurations & post build step to copy
> iaxclientlib.dll in the dll configs
>  note: the debug builds generate some wxWidget warnings at run time
>        don't know what causes them but i just ignore them
>
>
>  steve
>  ----- Original Message ----- From: "Peter Grayson" <jpg...@gm...>
>  To: "stevebvt" <ste...@gm...>
>  Sent: Saturday, April 05, 2008 11:24 PM
>
>
>  Subject: Re: [Iaxclient-devel] novideo_dll
>
>
>
> > Hi Steve,
> >
> > Thanks for sending this patch along. The format is great. It's much
> > easier for me to deal with one patch file that contains all the
> > changes for the various files. I appreciate you doing this.
> >
> > I'm going to take a closer look at the changes on Monday. I'll answer
> > in more detail then.
> >
> > Pete
> >
> > On Sat, Apr 5, 2008 at 11:10 AM, stevebvt <ste...@gm...> wrote:
> >
> > > small number of minor vs2005 configuration fixes
> > >  output directories,dependencies,...
> > >
> > >  hope this patch format is what you were looking for
> > >  should i send patches to everyone or just you
> > >
> > >
> > >  steve
> > >  ----- Original Message ----- From: "Peter Grayson"
> <jpg...@gm...>
> > >  To: "stevebvt" <ste...@gm...>
> > >  Cc: <iax...@li...>
> > >  Sent: Friday, April 04, 2008 5:20 PM
> > >  Subject: Re: [Iaxclient-devel] novideo_dll
> > >
> > >
> > >
> > >
> > > > Hi Steve,
> > > >
> > > > On Fri, Apr 4, 2008 at 2:10 PM, stevebvt <ste...@gm...> wrote:
> > > >
> > > > > added novideo_dll's to msvc2005 projects
> > > > >
> > > >
> > > > Thanks for doing this. There was a problem though -- the
> > > > libvidcap.lib, libtheora.lib, and libogg.lib link dependencies were
> > > > still in there. Also, testcall.vcproj needed to have the new
> > > > Release_novideo_dll and Debug_novideo_dll configurations in order to
> > > > link. I've made both these changes.
> > > >
> > > >
> > > > >  also added LIBVER to libiaxclient.vcproj even if it's not updated
> it
> > > will
> > > > > easier to edit
> > > > >
> > > >
> > > > I'm not a big fan of putting LIBVER in the vcproj files. I do agree
> > > > that the problem this addresses is worth solving though. The problem
> > > > with this approach is that if LIBVER is in the vcproj file, it will
> > > > always be wrong -- and it will be wrong in all 8 places it is in this
> > > > file.
> > > >
> > > > I guess I should recap the problem we're talking about here. In
> > > > iaxclient_lib.c, there is an API function, iaxc_version(), that is
> > > > only defined if LIBVER is defined. This is really obviously crappy
> > > > because the iaxclient api may be incompletely implemented based on
> > > > some arbitrary preprocessor definition.
> > > >
> > > > I propose that we change iaxclient_lib.c so that iaxc_version() is
> > > > always defined, perhaps with an implementation like this:
> > > >
> > > > EXPORT char* iaxc_version(char * ver)
> > > > {
> > > > strncpy(ver, "" LIBVER, IAXC_EVENT_BUFSIZ);
> > > > return ver;
> > > > }
> > > >
> > > > With the above implementation, iaxc_version() would either return
> > > > something correct or something that obviously is not the version (a
> > > > zero-length string).
> > > >
> > > > We could also consider defining LIBVER in the code above to be the
> > > > actual package version (e.g. "2.1.beta3"). The problem with that is
> > > > that the package maintainer (i.e. me) would have to dutifully change
> > > > the LIBVER definition when making releases. I will get that wrong.
> > > >
> > > > I am going to commit the rest of these changes without the LIBVER
> part.
> > > >
> > > >
> > > > >  also did some cleanup
> > > > >
> > > >
> > > > Thanks.
> > > >
> > > > It looks like you made these patches by doing "diff a.c b.c >
> > > > the.patch". If you are making changes in a subversion working copy,
> > > > you can make you patches by running "svn diff". Alternatively, you
> > > > should make unified diffs by using the -u option with diff: "diff -u
> > > > a.c b.c > the.patch". The problem with the simple diffs is that they
> > > > do not encode the filename and thus I have to interactively type the
> > > > name of the file to patch when I run patch.
> > > >
> > > > Pete
> > > >
> > >
> > >
> >
>