Re: [Hyperic-hq-discuss] sigar win32 modifications for compiling and listing network interfaces

[Doug M. <dma...@vm...>]

Hi Andrew,

I've made a few changes on top of yours, but it is the same functionally.  The changes are merged to hyperic/sigar master now, let me know if everything looks good to you.  Thanks again!

-Doug
 
On Apr 12, 2011, at 11:56 PM, Andrew Beekhof wrote:

> On Tue, Apr 12, 2011 at 11:16 PM, Doug MacEachern
> <dma...@vm...> wrote:
>> On Apr 12, 2011, at 1:07 AM, Andrew Beekhof wrote:
>> 
>>> On 04/11/2011 11:11 PM, Doug MacEachern wrote:
>>>> Hi Andrew,
>>>> 
>>>> ok, no problem, I have it building with the ms compiler now.
>>> 
>>> Great
>>> 
>>>> sigar_net_interface_name_get is declared extern, do you need that outside of the sigar library or can I make it static?
>>> 
>>> We're not using it explicitly, so static should be fine.
>> 
>> ok, cool.
>> 
>>> 
>>>> 
>>>> +SIGAR_DECLARE(char *)
>>>> +sigar_net_interface_name_get(sigar_t *sigar, MIB_IFROW *ifr)
>>>> 
>>>> I'd also like to make PIP_ADAPTER_ADDRESSES an input to that function so we can avoid calling sigar_new each time.
>>> 
>>> Sure. That makes sense.  Just be careful how ifconf_buf is used - that
>>> had us guess for a bit.
>> 
>> Yeah, a bit too much reuse of that scratch buffer.
>> 
>>> 
>>> Do you want us to work on this or have you got it under control?
>> 
>> I got it for now.  I want to spend a bit more time testing and get some mingw32 based CI builds hooked up, etc.  Hopefully will be able to get that done soon.
> 
> Awesome.
> Happy to do some early testing too - just let us know.