|
From: Adam S. <aj...@re...> - 2011-03-21 13:23:29
|
----- Original Message -----
> On Wed, Mar 2, 2011 at 10:54 PM, Doug MacEachern
> <dma...@vm...> wrote:
> > Hi Adam,
> >
> > Thanks for the patches!
> > I need to take a closer look, but wondering if we could change
> > sigar_net_interface_config_get rather than change the return values
> > of sigar_net_interface_list:
> > sigar_net_interface_config_get("ethX", &config);
>
> Until recently I probably would have agreed with you, however given
> the recent shift away from ethX even on Linux, I'm not convinced that
> it makes sense to continue using it on Windows where it has no real
> meaning. Worse, the number of ethX entries does not even match the
> number of physical devices (there are two additional "pseudo devices"
> for every physical one).
>
> The other issue is that anything wanting to present network
> information to users must do the translation - again, since ethX is
> meaningless on Windows.
>
> So I guess my answer here is, "yes we could and if you insist we will,
> but I really don't think we should" :-)
>
Hi Doug,
Just a quick ping to see what your thoughts were on the patch?
Thanks!
--
__ __
.-----.| |_.-----.| |--.-----.-----.
|__ --|| _| _ || <| -__|__ --|
|_____||____|_____||__|__|_____|_____|
.----------------------------------.
( aj...@re... || 919.754.4187 )
`----------------------------------'
|