[Hyperic-hq-discuss] hq r14474 - trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase

[<dcr...@hy...>]

Author: dcrutchf
Date: 2010-04-05 10:10:34 -0700 (Mon, 05 Apr 2010)
New Revision: 14474
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=14474

Modified:
   trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java
Log:
Updating code based on code review feedback

Modified: trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java
===================================================================
--- trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java	2010-04-05 07:56:02 UTC (rev 14473)
+++ trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java	2010-04-05 17:10:34 UTC (rev 14474)
@@ -43,14 +43,9 @@
                 pass = props.getProperty(JDBCMeasurementPlugin.PROP_PASSWORD, "");
         
         try {
-            Connection conn = createConnection(url, user, pass);
+            conn = createConnection(url, user, pass);
         } catch(SQLException e) {
-            throw new PluginException(new MetricUnreachableException("Could not connect using information provided", e));
-        } finally {
-            if (conn != null) {
-                DBUtil.closeJDBCObjects(log, conn, null, null);
-                conn = null;
-            }
+            throw new PluginException("Create connection failed:" + e.getMessage(), e);
         }
         
         super.init();