[Hyperic-hq-discuss] hq r14468 - trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase

[<dcr...@hy...>]

Author: dcrutchf
Date: 2010-04-02 07:39:19 -0700 (Fri, 02 Apr 2010)
New Revision: 14468
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=14468

Modified:
   trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java
Log:
[HHQ-3791] - UI does not validate Sybase connection settings within Configuration Properties

Modified: trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java
===================================================================
--- trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java	2010-04-02 07:52:16 UTC (rev 14467)
+++ trunk/plugins/sybase/src/org/hyperic/hq/plugin/sybase/SybaseSysmonCollector.java	2010-04-02 14:39:19 UTC (rev 14468)
@@ -19,7 +19,9 @@
 import org.hyperic.hq.product.CollectorResult;
 import org.hyperic.hq.product.JDBCMeasurementPlugin;
 import org.hyperic.hq.product.Metric;
+import org.hyperic.hq.product.MetricUnreachableException;
 import org.hyperic.hq.product.MetricValue;
+import org.hyperic.hq.product.PluginException;
 import org.hyperic.util.jdbc.DBUtil;
 
 /**
@@ -33,6 +35,27 @@
     private CallableStatement stmt;
     private Connection conn = null;
 
+    protected void init() throws PluginException {
+        Properties props = getProperties();
+
+        String url = props.getProperty(JDBCMeasurementPlugin.PROP_URL, ""),
+                user = props.getProperty(JDBCMeasurementPlugin.PROP_USER, ""),
+                pass = props.getProperty(JDBCMeasurementPlugin.PROP_PASSWORD, "");
+        
+        try {
+            Connection conn = createConnection(url, user, pass);
+        } catch(SQLException e) {
+            throw new PluginException(new MetricUnreachableException("Could not connect using information provided", e));
+        } finally {
+            if (conn != null) {
+                DBUtil.closeJDBCObjects(log, conn, null, null);
+                conn = null;
+            }
+        }
+        
+        super.init();
+    }
+
     public void collect() {
 
         Properties props = getProperties();