[Hyperic-hq-discuss] hq r14465 - in trunk/src/org/hyperic/hq: measurement/server/session ui/action/resource/common/monitor/visibility

[<pn...@hy...>]

Author: pnguyen
Date: 2010-04-01 17:07:28 -0700 (Thu, 01 Apr 2010)
New Revision: 14465
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=14465

Modified:
   trunk/src/org/hyperic/hq/measurement/server/session/DataManagerEJBImpl.java
   trunk/src/org/hyperic/hq/ui/action/resource/common/monitor/visibility/IndicatorChartsAction.java
Log:
[HHQ-3803] Init total to 0, not 1. Added comment to consolidate code in the future.

Modified: trunk/src/org/hyperic/hq/measurement/server/session/DataManagerEJBImpl.java
===================================================================
--- trunk/src/org/hyperic/hq/measurement/server/session/DataManagerEJBImpl.java	2010-04-02 00:06:18 UTC (rev 14464)
+++ trunk/src/org/hyperic/hq/measurement/server/session/DataManagerEJBImpl.java	2010-04-02 00:07:28 UTC (rev 14465)
@@ -1240,9 +1240,9 @@
         if (historicalData.size() == 0) {
             return null;
         }
-        double high  = Double.MIN_VALUE,
-               low   = Double.MAX_VALUE,
-               total = 1;
+        double high  = Double.MIN_VALUE;
+        double low   = Double.MAX_VALUE;
+        double total = 0;
         Double lastVal = null;
         int count = 0;
         long last = Long.MIN_VALUE;

Modified: trunk/src/org/hyperic/hq/ui/action/resource/common/monitor/visibility/IndicatorChartsAction.java
===================================================================
--- trunk/src/org/hyperic/hq/ui/action/resource/common/monitor/visibility/IndicatorChartsAction.java	2010-04-02 00:06:18 UTC (rev 14464)
+++ trunk/src/org/hyperic/hq/ui/action/resource/common/monitor/visibility/IndicatorChartsAction.java	2010-04-02 00:07:28 UTC (rev 14465)
@@ -171,6 +171,11 @@
         return result;
     }
     
+    /**
+     * TODO: The logic here is similar to DataManagerEJBImpl.getAggData().
+     * Need to consolidate the code.
+     * 
+     */
     private double[] getAggregateData(MeasurementTemplate template, List<HighLowMetricValue> metricData) {
         final boolean debug = log.isDebugEnabled();