[Hyperic-hq-discuss] hq r14415 - trunk/src/org/hyperic/hq/application

[<rm...@hy...>]

Author: rmorgan
Date: 2010-03-24 10:40:20 -0700 (Wed, 24 Mar 2010)
New Revision: 14415
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=14415

Modified:
   trunk/src/org/hyperic/hq/application/HQApp.java
Log:
[HQ-2094] Add runReport and methods starting with has (for hasAdminPermission) to the
list of read only methods.  Prior to this change, all reports were run in a read/write
session causing the reports to take longer to run than necessary.



Modified: trunk/src/org/hyperic/hq/application/HQApp.java
===================================================================
--- trunk/src/org/hyperic/hq/application/HQApp.java	2010-03-24 07:56:23 UTC (rev 14414)
+++ trunk/src/org/hyperic/hq/application/HQApp.java	2010-03-24 17:40:20 UTC (rev 14415)
@@ -605,8 +605,9 @@
         }
 
         private boolean methIsReadOnly(String methName) {
-            return // 'create' is part of EJB session bean creation
+            return methName.equals("runReport") || // ReportCenter
                    methName.equals("setUserPrefsAfterCommit") ||
+                   // 'create' is part of EJB session bean creation
                    methName.equals("create") ||
                    methName.equals("disconnectAgent") ||
                    // recent alerts & indicators
@@ -623,7 +624,8 @@
                    // masthead
                    methName.equals("resourcesExistOfType") ||
                    methName.equals("search") || 
-                   methName.equals("initializeTriggers") || 
+                   methName.equals("initializeTriggers") ||
+                   methName.startsWith("has") ||
                    methName.startsWith("are") ||
                    methName.startsWith("check") ||
                    methName.startsWith("dispatch") ||