[Hyperic-hq-discuss] hq r14373 - trunk/web/js/lib

[<pn...@hy...>]

Author: pnguyen
Date: 2010-03-11 16:18:17 -0800 (Thu, 11 Mar 2010)
New Revision: 14373
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=14373

Modified:
   trunk/web/js/lib/lib.js
Log:
[HQ-1884] escapeHTML the group name

Modified: trunk/web/js/lib/lib.js
===================================================================
--- trunk/web/js/lib/lib.js	2010-03-11 22:10:01 UTC (rev 14372)
+++ trunk/web/js/lib/lib.js	2010-03-12 00:18:17 UTC (rev 14373)
@@ -2566,11 +2566,19 @@
             row.id = 'alertGroup:' + groups[i];
             var data = that.alert_group_status[groups[i]] || ['gray','gray'];
             var name = that.alert_groups.data[groups[i]];
-            if(that.alert_groups.data[groups[i]].length > 20)
-            {
-                name = '<abbr title="' + name + '">' + name.substring(0,20) + '&hellip;</abbr>';
+            var aObj = document.createElement("a");
+            aObj.href = "/Resource.do?eid=5:" + groups[i];
+
+            if (name.length > 20) {
+                var abbrObj = document.createElement("abbr");
+                abbrObj.title = name;
+                abbrObj.innerHTML = name.substring(0,20).escapeHTML() + "&hellip;";
+                aObj.appendChild(abbrObj);
+            } else {
+                aObj.innerHTML = name.escapeHTML();
             }
-            row.childNodes[0].innerHTML = '<a href="/Resource.do?eid=5:' + groups[i] + '">' + name +'</a>';
+
+            row.childNodes[0].appendChild(aObj);
             row.childNodes[1].innerHTML = '<img src="/images/4.0/icons/'+data[0]+'.gif" alt="'+ status[data[0]] +'">';
             row.childNodes[2].innerHTML = '<a href="/alerts/Alerts.do?mode=list&eid=5:' + groups[i] + '"><img src="/images/4.0/icons/'+data[1]+'.gif" alt="'+ status[data[1]]+'" border="0"></a>';
             table.appendChild(row);