[Hyperic-hq-discuss] hq r14245 - trunk/src/org/hyperic/hq/bizapp/shared/action

[<pn...@hy...>]

Author: pnguyen
Date: 2010-01-28 21:41:31 -0800 (Thu, 28 Jan 2010)
New Revision: 14245
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=14245

Modified:
   trunk/src/org/hyperic/hq/bizapp/shared/action/SnmpActionConfig.java
Log:
[HQ-2044] Make "variable bindings" an optional config; Improve validation and error handling.

Modified: trunk/src/org/hyperic/hq/bizapp/shared/action/SnmpActionConfig.java
===================================================================
--- trunk/src/org/hyperic/hq/bizapp/shared/action/SnmpActionConfig.java	2010-01-29 05:18:02 UTC (rev 14244)
+++ trunk/src/org/hyperic/hq/bizapp/shared/action/SnmpActionConfig.java	2010-01-29 05:41:31 UTC (rev 14245)
@@ -20,7 +20,7 @@
     protected String snmpNotificationMechanism;
     protected String variableBindings;  // in JSON format
     
-    private String implementor =
+    private static String implementor =
         "com.hyperic.hq.bizapp.server.action.alert.SnmpAction";
 
     public SnmpActionConfig() {
@@ -95,6 +95,7 @@
         
         StringConfigOption variableBindings = 
             new StringConfigOption(CFG_VARIABLE_BINDINGS, "User Variable Bindings", "[]");
+        variableBindings.setOptional(true);
         res.addOption(variableBindings);
         
         return res;