[Hyperic-hq-discuss] hq r13929 - trunk/src/org/hyperic/hq/measurement/agent/server

[<tr...@hy...>]

Author: trader
Date: 2009-11-05 17:27:44 -0800 (Thu, 05 Nov 2009)
New Revision: 13929
URL: http://svn.hyperic.org/?view=rev&root=Hyperic+HQ&revision=13929

Modified:
   trunk/src/org/hyperic/hq/measurement/agent/server/SenderThread.java
Log:
Small logic tweak, minimal performance impact since the Record object already is implemented to calculate hashcode once.  I feel this is a more straightforward use of the Set interface.

Modified: trunk/src/org/hyperic/hq/measurement/agent/server/SenderThread.java
===================================================================
--- trunk/src/org/hyperic/hq/measurement/agent/server/SenderThread.java	2009-11-05 19:25:39 UTC (rev 13928)
+++ trunk/src/org/hyperic/hq/measurement/agent/server/SenderThread.java	2009-11-06 01:27:44 UTC (rev 13929)
@@ -379,9 +379,9 @@
         {
             try {
                 Record r = SenderThread.decodeRecord((String)it.next());
-                if (!records.contains(r)) {
-                    records.add(r);
-                } else {
+                boolean didNotAlreadyExist = records.add(r); 
+                if (!didNotAlreadyExist) {
+                    // nuke the dup
                     if (debug) log.debug("Dropping duplicate entry for " + r);
                     numUsed--;
                 }