#4485 [HHQ-4348] WebSphere Connection Pool metric collection fails

[Hyperic Team]

http://jira.hyperic.com/browse/HHQ-4348
This is presumably a regression bug caused by HHQ-4311.

---

I think there's 2 problems with this fix:

1. %mbeanIdentifier% is not inserted to product configuration. Plugin still discovers 'connpool' option while it's been replaced by 'mbeanIdentifier' in xml descriptor.

2. I don't know whether it was meant to use pool name to query jmx or match it to actual mbeanIdentifier(name=%mbeanIdentifier% in query). However, current solution is trying to use %mbeanIdentifier% but since that doesn't exist, metric collection fails. If you manually change 'mbeanIdentifier' to match the pool name (discovered connpool attribute value), collection works but I don't know which one is picked up since there may be duplicates(with identical pool name).

Here's dry-run with metric collection by discovered values:

WebSphere 6.1 Connection Pool JDBC Pool Prepared Statement Cache Discards per Minute:


   jvalkealahti-e6500Node01/server1/connectionPoolModule:Module=%mbeanIdentifier%:prepStmtCacheDiscards:admin.host=jvalkealahti-e6500.vmware.com,admin.port=8880,username=%username%,password=***


    WebSphere 6.1 Connection Pool C:\IBM\WebSphere\AppServer\profiles\AppSrv01 jvalkealahti-e6500Node01Cell jvalkealahti-e6500Node01 server1 Samples Derby JDBC Provider (XA)


     config...


     product..connpool=Samples Derby JDBC Provider (XA),server.name=server1,


     metric...


     control..null


     cprops...implementationClassName=org.apache.derby.jdbc.EmbeddedXADataSource,


     rt.......null


getValue failed for metric: WebSphere 6.1 Connection Pool:jvalkealahti-e6500Node01/server1/connectionPoolModule:Module=%mbeanIdentifier%:prepStmtCacheDiscards:admin.host=jvalkealahti-e6500.vmware.com,admin.port=8880,username=%username%,password=%password%RATE=1m


PluginException: WebSphere:type=JDBCProvider,j2eeType=JDBCResource,name=%mbeanIdentifier%,process=server1,node=jvalkealahti-e6500Node01, query returned 0 results


hit enter to continue


WebSphere 6.1 Connection Pool Availability:


   jvalkealahti-e6500Node01/server1/connectionPoolModule:Module=%mbeanIdentifier%:Availability:admin.host=jvalkealahti-e6500.vmware.com,admin.port=8880,username=%username%,password=


getValue failed for metric: WebSphere 6.1 Connection Pool:jvalkealahti-e6500Node01/server1/connectionPoolModule:Module=%mbeanIdentifier%:Availability:admin.host=jvalkealahti-e6500.vmware.com,admin.port=8880,username=%username%,password=%password%


PluginException: WebSphere:type=JDBCProvider,j2eeType=JDBCResource,name=%mbeanIdentifier%,process=server1,node=jvalkealahti-e6500Node01, query returned 0 results


hit enter to continue