RES: [Hwgui-developers] HwGUI cleanup proposal

[Rodrigo M. <rod...@te...>]

I Agree.

-----Mensagem original-----
De: hwg...@li...
[mailto:hwg...@li...]Em nome de
Alexander S.Kresin
Enviada em: sabado, 13 de marco de 2004 07:28
Para: hwg...@li...
Assunto: [Hwgui-developers] HwGUI cleanup proposal


Hello,

  first of all: thanks to all, who contributed to HwGUI.

  Below are some notices I want to discuss here.
  Few days ago I'd downloaded latest HwGUI changes from CVS and had
  tried to compile them - but unsuccessfully - mostly due to few
  errors in Harbour related parts ( #ifndef __XHARBOUR__ ).
  I want to do some cleanup to get clear of warnings and errors and to
  keep the HwGUI core clear and free of redundancy.

  1. I suggest to remove the commctrl.ch because
    a) It includes a lot of stuff which isn't needed for us.
    b) We have windows.ch, which is intended for #defines, which
       are really used in HwGUI.
    c) I'm not an expert in licensing issues, but I'm afraid that it
       isn't legal to include a file, which hasn't Harbour like, GNU
       like license.

    Of course, all necessary #defines I'll place in windows.ch.
    
  2. I suggest to remove the _winmsg.c, because it seems that it is
     copied from some other product and there is no license in it.
     On the other hand, this file includes simplest wrappers, some of
     which presents already in HwGUI ( SendMessage(), PostMessage() ),
     some other aren't needed for HwGUI.
     I suggest to add those wrappers, which are really needed to other
     files.

  3. I don't sure, is the ReleaseAllWindows() really needed.
     It closes all child windows, if parent receives WM_CLOSE, but
     aren't they closed automatically, by Windows in this case ?
     The Harbour part of this function is very strange :).
     And I can't understand, why

         If HWindow():oMainWindow == oWnd
             ExitProcess(0)
         Endif

     is needed ? Application ends after main window closing in any
     case ...

  4. IMO, the CLASS VAR oMainWindow is redundant, because
     HWindow():GetMain() returns the main window object.

  5. I don't understand, why 'parent' variable is added to the HWindow
  class. We can get parent window handle, using ::oParent:handle ...

  I didn't review all the changes yet, these are only first thoughts
  ...
  
  Any comments are appreciated.
  
Regards,
 Alexander
http://kresin.belgorod.su




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Hwgui-developers mailing list
Hwg...@li...
https://lists.sourceforge.net/lists/listinfo/hwgui-developers