hwgui-developers

[Hwgui-developers] 2013-07-02 21:49 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)

[Przemyslaw C. <dr...@po...>]

2013-07-02 21:49 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
  * hwgui/source/common/debug/dbgentry.c
    * reformatted keeping the same rules as used to format dbgentry.c in
      Harbour GIT repository.

best regards
Przemek

Re: [Hwgui-developers] 2013-07-02 21:49 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)

[Przemyslaw C. <dr...@po...>]

On Tue, 02 Jul 2013, Przemyslaw Czerpak wrote:
> 2013-07-02 21:49 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
>   * hwgui/source/common/debug/dbgentry.c
>     * reformatted keeping the same rules as used to format dbgentry.c in
>       Harbour GIT repository.

Hi Alexander,

After above reformatting it's possible to easy compare dbgentry.c from
HWGUI and Harbour. As I can see there is only one difference. In HWGUI
dbgentry.c contains new function __DBGPROCESSRUN()
If it's possible then I'd like to ask you move this function to different
file and remove redundant code. In longer terms it will create problems
and additional jobs for HWGUI and Harbour developers to keep synced the
same code, i.e. I'd like to commit some modifications to Harbour
repository to fix few potential problems when module names are not
correctly recognized so breakpoints do not work as expected.

Do you see any drawbacks in moving __DBGPROCESSRUN() to
different file and removing dbgentry.c from HWGUI?

best regards
Przemek

Re: [Hwgui-developers] 2013-07-02 21:49 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)

[Alexander S.K. <al...@be...>]

Przemyslaw Czerpak writes:
> 
> After above reformatting it's possible to easy compare dbgentry.c from
> HWGUI and Harbour. As I can see there is only one difference. In HWGUI
> dbgentry.c contains new function __DBGPROCESSRUN()
> If it's possible then I'd like to ask you move this function to different
> file and remove redundant code. In longer terms it will create problems
> and additional jobs for HWGUI and Harbour developers to keep synced the
> same code, i.e. I'd like to commit some modifications to Harbour
> repository to fix few potential problems when module names are not
> correctly recognized so breakpoints do not work as expected.
> 
> Do you see any drawbacks in moving __DBGPROCESSRUN() to
> different file and removing dbgentry.c from HWGUI?
> 

  No drawbacks at all. I get more satisfaction, when I remove some code, 
staying with the same functionality, than when I add some :).
  That function, __DBGPROCESSRUN(), was introduced, because 
hb_processOpen() doesn't worked under Linux in the same way as under 
Windows. I was tired to fight with it and wrote this one.

Regards, Alexander.

Re: [Hwgui-developers] 2013-07-02 21:49 UTC+0200 Przemyslaw Czerpak (druzus/at/priv.onet.pl)

[Alexander S.K. <al...@be...>]

>> Do you see any drawbacks in moving __DBGPROCESSRUN() to
>> different file and removing dbgentry.c from HWGUI?
>>
> 
>   No drawbacks at all. I get more satisfaction, when I remove some code, 
> staying with the same functionality, than when I add some :).
>   That function, __DBGPROCESSRUN(), was introduced, because 
> hb_processOpen() doesn't worked under Linux in the same way as under 
> Windows. I was tired to fight with it and wrote this one.
> 

   There is one problem, which I remembered now, the reason, why I 
included the dbgentry.c in HwGUI. In Harbour this file is a part of 
hbdebug.lib, so I need to link the hbdebug and there may be conflicts 
with some functions from debugger.prg, especially __dbgEntry(). What to 
do with this ?

Regards, Alexander.