Re: [Hw4mdl-devel] Short tags patch

[Ashley H. <as...@ne...>]

Hi all,

The last chunk in that patch is a fix for the firstname/lastname bug.  
Users appear with their name reversed in Live Classroom, eg. "Ashley 
Holman" in Moodle becomes "Holman_Ashley" in Live Classroom.

Index: branches/team/Thomas/integrations_common/php/lc/LCAction.php
===================================================================
--- branches/team/Thomas/integrations_common/php/lc/LCAction.php	(revision 258)
+++ branches/team/Thomas/integrations_common/php/lc/LCAction.php	(working copy)
@@ -270,7 +270,7 @@
         $screenName = $this->session->getFirstname() . "_" . $this->session->getLastname();
         return $this->api->lcapi_get_session($this->session->getLcCurrentUser(), $screenName);
     } 
-    function getAuthokenNormal($userID, $lastName, $firstName)
+    function getAuthokenNormal($userID, $firstName, $lastName)
     {
         return $this->api->lcapi_get_session($userID, $firstName . "_" . $lastName);
     } 



Ashley Holman wrote:
> Hi all,
>
> I've attached a patch which fixes the short PHP tags in 
> branches/team/Thomas/
>
> Could this be included before the release of the next version as 
> otherwise the module won't work on servers with the PHP short_tags 
> setting off.
>
> Thanks
> Ashley
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> ------------------------------------------------------------------------
>
> _______________________________________________
> Hw4mdl-devel mailing list
> Hw4...@li...
> https://lists.sourceforge.net/lists/listinfo/hw4mdl-devel


-- 
Ashley Holman
Software Engineer
NetSpot Pty Ltd
183 Melbourne Street, North Adelaide, 5006
Ph: +618 8361 6800, Fax: +618 8361 6811