Re: [Hw4mdl-devel] Errors in latest code

[Ashley H. <as...@ne...>]

Hi Thomas,

Thanks.  That's working a lot better here now, although there are still 
these remaining lines with short tags which cause some errors if 
short_tags if turned off:

liveclassroom/mod.html:214:                      <?
liveclassroom/mod.html:665:                                                                             
<?
liveclassroom/mod.html:726:                                                                             
<font class="fontCurrent"><?echo 
get_string('duration_calendar','liveclassroom')?></font>
liveclassroom/view.php:211:<?
voicetools/error.php:39: <?require_once("../../config.php");   ?>
voicetools/mod.html:411:    <?}?>
voicetools/mod.html:737:                                        <?
voicetools/mod.html:798:                                        <font 
class="fontCurrent"><?echo 
get_string('duration_calendar','voicetools')?></font>
voicetools/index.php:83:                        <iframe src="<?=$url?>" 
width="705px" height="405px" name="frameWidget" style="overflow:hidden;" 
FRAMEBORDER=0>

That last line also looks like it might be a syntax error - perhaps it 
should be  "<? print $url; ?>"?

One other thing I noticed is that the "php-xml" RPM package had to be 
installed on RedHat with PHP5 for the voicetools module to work.  Last 
time I checked the hw4mdl installation docs it only mentioned php-domxml 
needing to be installed in PHP4 environments so perhaps that needs to be 
amended.

If you give me commit access I'm happy to check-in some of these fixes 
directly to save you the trouble.

Cheers
Ashley.

Thomas Rollinger wrote:
> Hi Ashley,
>
> I did some changes into my branches to fix the several errors that you 
> discovered :
>
> -I enabled the moodle debugging and fixed the couple of notice/warning 
> error. Please let me know if you continue to encountered problems.
>
> -I have also verified that I use <?php instead of <? in all my file to 
> follow the moodle coding convention and committed the missing 
> file(popup.php).
>
>
> I set up a new dev environment with the latest code and I was able to 
> use and configure the two module without any problems.
>
>
> Thanks for your help 
>
> Thomas
>
>
> On 17 févr. 08, at 20:46, Ashley Holman wrote:
>
>> Hi all,
>>
>> I tried setting up the latest code from branches/team/Thomas/ and 
>> have encountered several errors trying to get it going.
>>
>> Firstly there is a parse error in 
>> integrations_common/php/lc/lcapi.php on line 837.  The stray '.' on 
>> the end of that line causes the installation to fail.  The /admin/ 
>> URL shows up blank.
>>
>> There are a few short PHP tags in mod/voicetools/mod.html, ie. <? 
>> instead of <?php, which caused parse errors in my environment as I 
>> don't have short tags enabled.  The Moodle coding guidelines say that 
>> short tags should not be used 
>> (http://docs.moodle.org/en/Coding#General_rules).
>>
>> Once I fixed that up I got the following error from mod.html:
>>
>> Include(http://dev1.netspot.com.au/moodle19/mod/voicetools/popup.php?type=popup) 
>> [function.include 
>> <http://dev1.netspot.com.au/moodle19/course/function.include>]: 
>> failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in 
>> */var/www/html/moodle19/moodle/mod/voicetools/mod.html* on line *894*
>>
>> *Warning*: include() [function.include 
>> <http://dev1.netspot.com.au/moodle19/course/function.include>]: 
>> Failed opening 
>> 'http://dev1.netspot.com.au/moodle19/mod/voicetools/popup.php?type=popup' 
>> for inclusion (include_path='.:/usr/share/pear') in 
>> */var/www/html/moodle19/moodle/mod/voicetools/mod.html* on line *894*
>>
>> I can't see any popup.php that came with the code I checked out from SVN.
>>
>> There are also a few warning messages that come up if you enable the 
>> moodle debugging (Administration -> Server -> Debugging) and change 
>> the debug setting to ALL.  Eg. warnings about constants being already 
>> defined, and also some warnings about uninitialised variables.
>>
>> Regards
>> Ashley.
>> -- 
>> Ashley Holman
>> Software Engineer
>> NetSpot Pty Ltd
>> 183 Melbourne Street, North Adelaide, 5006
>> Ph: +618 8361 6800   Fax: +618 8361 6811
>>     
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/_______________________________________________
>> Hw4mdl-devel mailing list
>> Hw4...@li...
>> https://lists.sourceforge.net/lists/listinfo/hw4mdl-devel
>
>
>
>
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> ------------------------------------------------------------------------
>
> _______________________________________________
> Hw4mdl-devel mailing list
> Hw4...@li...
> https://lists.sourceforge.net/lists/listinfo/hw4mdl-devel
>   


-- 
Ashley Holman
Software Engineer
NetSpot Pty Ltd
183 Melbourne Street, North Adelaide, 5006
Ph: +618 8361 6800   Fax: +618 8361 6811