Re: [Hw4mdl-devel] Catalyst code review - comments please

[Ashley H. <as...@ne...>]

Hi Thomas,

In the getRoleForWimbaTools() function in WimbaLib.php, one of the 
return values is "StudentBis".  What is that role and is it still 
needed?  I'm working on using capabilities to define the Wimba roles so 
wanted to see which situation "StudentBis" should be used in... does it 
need its own capability defined?

Also I note that the isteacher() isadmin() etc functions are in Moodle's 
lib/deprecatedlib.php as of 1.7 so its probably important that these 
functions be no longer used.

Thanks
Ashley.

Thomas Rollinger wrote:
> Hi,
>
> It can be great if you can make the patch.
>
> Can you please start from the code of the branche "team/Thomas"  
> because trunk is not up to date and will not working correctly.
>
>
> Best
>
> Thomas
>
> On 16 janv. 08, at 19:08, Ashley Holman wrote:
>
>   
>> Hi Thomas,
>>
>>     
>>>> Since the review, we've realised ... this module needs to define  
>>>>         
>>> some
>>>       
>>>> capabilities and then use has_capability()
>>>>         
>>> Can you provide me more informations?
>>>
>>>       
>> I think a capability could be defined for being an instructor for the
>> Wimba tools.  At the moment the getRoleForWimbaTools() function in
>> WimbaCommons.php checks isstudent(), isteacher(), isadmin() etc.  This
>> could be replaced with has_capability(), and the default capabilities
>> could be set up to match the current behaviour.  Ie, the capability
>> mod/liveclassroom:instructor would be assigned to the Teacher, Course
>> Creator, and Admin roles.  This would allow for better customisation  
>> of
>> roles, and work in different contexts where roles are overridden etc.
>>
>> If you are interested I can make a patch.
>>
>> Cheers
>> Ashley.
>>
>> PS. sorry for duplicate message - forgot to CC the list on the first  
>> one
>>
>> -- 
>> Ashley Holman
>> Software Engineer
>> NetSpot Pty Ltd
>> 183 Melbourne Street, North Adelaide, 5006
>> Ph: +618 8361 6800   Fax: +618 8361 6811
>>
>>
>>     

-- 
Ashley Holman
Software Engineer
NetSpot Pty Ltd
183 Melbourne Street, North Adelaide, 5006
Ph: +618 8361 6800   Fax: +618 8361 6811