[Hw4mdl-devel] Catalyst code review - comments please

[Ashley H. <as...@ne...>]

Hi All,

Catalyst have done an analysis of the hw4mdl code and have identified 
several issues which may need fixing/improving.  I've attached the PDF 
document that they prepared outlining the problems they found.  I'm a 
developer at NetSpot in Australia and we've decided to give some time to 
fixing those problems, so I'd appreciate any comments people have on 
each of those points in the PDF - whether the issues are real concerns 
or not and what should be considered in implementing a fix, so that I 
can take those into consideration before starting development.

Also there is an additional issue that was raised after the PDF was written:

 > Since the review, we've realised ... this module needs to define some
 > capabilities and then use has_capability()

Thanks very much for any thoughts/comments!

Cheers
Ashley.

-- 
Ashley Holman
Software Engineer
NetSpot Pty Ltd
183 Melbourne Street, North Adelaide, 5006
Ph: +618 8361 6800   Fax: +618 8361 6811