Menu

#32 buttonPanel.cpp:53: bad if test ?

1.4.4
closed
nobody
None
2015-08-30
2015-03-16
dcb
No

httraqt/sources/main/buttonPanel.cpp:53]: (warning) Logical disjunction always evaluates to true: EXPR >= 0 || EXPR <= 3.

if (parent->currentTab == 5 || parent->currentTab >= 0 || parent->currentTab <= 3) {

Discussion

  • E.Kalinowski

    E.Kalinowski - 2015-03-17

    Hi!
    You are right, it's any mistake. I'll check it today at home. But, i think, right is
    if (parent->currentTab == 5 || (parent->currentTab >= 0 && parent->currentTab <= 3)) {

     
  • E.Kalinowski

    E.Kalinowski - 2015-08-25

    it's not critical, but i'll change the code on this week.
    thanks for report!

     
  • E.Kalinowski

    E.Kalinowski - 2015-08-30

    fixed in 1.4.5

     
  • E.Kalinowski

    E.Kalinowski - 2015-08-30
    • status: open --> closed
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.