#24 Crash

[Herman BRULE]

Hello, I have a crash, are you able to say if it's linked with HTTraQt or httrack only:

0 0x00007ffff5ec2ae7 in __libc_send (fd=24, buf=buf@entry=0x7fffe63ff780, n=n@entry=485, flags=-1, flags@entry=0) at ../sysdeps/unix/sysv/linux/x86_64/send.c:33

1 0x00007ffff69ff015 in sendc (r=r@entry=0x7fffe44e7e40,

s=s@entry=0x7fffe63ff780 "GET /upload/f/f3/Ultra_Ball_III.png HTTP/1.1\r\nReferer: http://bulbapedia.bulbagarden.net/wiki/Bulbanews\r\nConnection: Keep-Alive\r\nHost: cdn.bulbagarden.net\r\nUser-Agent: Mozilla/5.0 (X11; U; Linux i686;"...) at htslib.c:2841

2 0x00007ffff6a0783a in http_sendhead (opt=opt@entry=0x7fffe001e570, cookie=0x0, mode=mode@entry=0, xsend=<optimized out="">, adr=<optimized out="">, adr@entry=0x7fffe44e4200 "cdn.bulbagarden.net", fil=fil@entry=0x7fffe44e4a00 "/upload/f/f3/Ultra_Ball_III.png",

referer_adr=<optimized out>, referer_adr@entry=0x7fffe44e5a00 "bulbapedia.bulbagarden.net", referer_fil=<optimized out>, referer_fil@entry=0x7fffe44e6200 "/wiki/Bulbanews", retour=retour@entry=0x7fffe44e7e40) at htslib.c:1166

3 0x00007ffff69e2639 in back_wait (sback=sback@entry=0x7fffe0041100, opt=opt@entry=0x7fffe001e570, cache=cache@entry=0x7fffe6438dc0, stat_timestart=stat_timestart@entry=0) at htsback.c:2575

4 0x00007ffff69c0724 in hts_wait_delayed (str=str@entry=0x7fffe643cfa0, adr=<optimized out="">, adr@entry=0x7fffe641aa10 "cdn.bulbagarden.net", fil=<optimized out="">, fil@entry=0x7fffe641b210 "/upload/f/f3/Ultra_Ball_III.png", save=<optimized out="">,

save@entry=0x7fffe6420a10 "/mnt/world/sites/bulbapedia/cdn.bulbagarden.net/upload/f/f3/Ultra_Ball_III.e7f.delayed", parent_adr=0x7ffff7e17888 "bulbapedia.bulbagarden.net", parent_fil=0x7ffff7e178b0 "/wiki/Bulbanews", former_adr=former_adr@entry=0x7fffe6421210 "", 
former_fil=former_fil@entry=0x7fffe6421a10 "", forbidden_url=forbidden_url@entry=0x7fffe6417bac) at htsparse.c:4417

5 0x00007ffff69c95bf in htsparse (str=str@entry=0x7fffe643cfa0, stre=stre@entry=0x7fffe643f3a0) at htsparse.c:2430

6 0x00007ffff69b4ab9 in httpmirror (

url1=url1@entry=0x7fffe00433a0 "http://bulbapedia.bulbagarden.net/wiki/Main_Page +*.png +*.gif +*.css +*.js -ad.doubleclick.net/* -*/User:* -*/Utilisateur:* -*action=history* -*oldid=* -*action=edit* -*action=info* -*/Discussion* -*"..., 
opt=opt@entry=0x7fffe001e570) at htscore.c:1478

7 0x00007ffff6a161e0 in hts_main2 (argc=54, argv=0x7fffe005b600, opt=<optimized out="">) at htscoremain.c:2183

8 0x00000000004493ae in httraq_main ()

9 0x0000000000421f77 in MyThread::run() ()

10 0x00007ffff6cf1bbc in QThreadPrivate::start (arg=0xbf89b0) at thread/qthread_unix.cpp:338

11 0x00007ffff5bc3f4a in start_thread (arg=0x7fffe6493700) at pthread_create.c:305

12 0x00007ffff5ec19bd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:115

[Herman BRULE]

bt attached

[E.Kalinowski]

Hello!
i think, the bug is in the libhttrack library, but i'll check it. Of course, is possible any wrong param. i'm not sure now.
Which version of libhttrack do You have?
regards from Hanover

[Herman BRULE]

3.45.4, with 3.47.27 crash too.

[Herman BRULE]

For that's I will test directly the git.

[Herman BRULE]

Here you have the crash, part of bug due to not initialized value.
But the big crash is here:
==8831== Invalid read of size 4
==8831== at 0x6008E6C: fil_normalized (htslib.c:3532)
==8831== by 0x60014E3: hash_write (htshash.c:231)
==8831== by 0x5FDD60A: htsparse (htsparse.c:3293)
==8831== by 0x5FBF548: httpmirror (htscore.c:1568)
==8831== by 0x601F14F: hts_main2 (htscoremain.c:3016)
==8831== by 0x44A005: httraq_main (htinterface.cpp:746)
==8831== by 0x422206: MyThread::run() (httraqt.cpp:157)
==8831== by 0x5B43BBB: QThreadPrivate::start(void) (qthread_unix.cpp:338)
==8831== by 0x6E46F49: start_thread (pthread_create.c:305)
==8831== by 0x6B809BC: clone (clone.S:115)
==8831== Address 0x120540a8 is 56 bytes inside a block of size 58 alloc'd
==8831== at 0x4C2C6FB: malloc (vg_replace_malloc.c:270)
==8831== by 0x6008DBF: fil_normalized (htslib.c:3580)
==8831== by 0x60014E3: hash_write (htshash.c:231)
==8831== by 0x5FDD60A: htsparse (htsparse.c:3293)
==8831== by 0x5FBF548: httpmirror (htscore.c:1568)
==8831== by 0x601F14F: hts_main2 (htscoremain.c:3016)
==8831== by 0x44A005: httraq_main (htinterface.cpp:746)
==8831== by 0x422206: MyThread::run() (httraqt.cpp:157)
==8831== by 0x5B43BBB: QThreadPrivate::start(void) (qthread_unix.cpp:338)
==8831== by 0x6E46F49: start_thread (pthread_create.c:305)
==8831== by 0x6B809BC: clone (clone.S:115)
Meat me on #qt-fr on freenode if you want.

[E.Kalinowski]

thank You for this backtrace information!
i'll try to reproduce it at home, after work :)

[Herman BRULE]

Maybe linked

[Herman BRULE]

Another crash with more strange BT

[E.Kalinowski]

Hi!
can You save here please the file with parameters? i need it to reproduce the crash.

[Herman BRULE]

here you have

[Herman BRULE]

Another backtrace, it's right you need keep runing few hours, for my it have crash after 8h at 2KB/s (very bad connection with hurge ping)

[E.Kalinowski]

Hello!
i tried it 4 or 5 times, but not so long time. can't reproduce it. good, i test it little bit longer :)
thank You!

[Herman BRULE]

I have too an buggy connection: corrupted file, timeout, file detected at 100% when is not fully loaded, disconnection during the loading, ...

[E.Kalinowski]

possible, i can try to reproduce this situation, if i manipulate the connection settings in the GUI

[E.Kalinowski]

Hi!

i think, the problem for bt.txt and bt5.txt is the sendc() function in the htslib.c source code. this line:

n = send(r->soc, s, ssz, 0);

must be checked, is the r->soc structure right:

if (r->soc != INVALID_SOCKET) {
n = send(r->soc, s, ssz, 0);
}

i'll post it in support forum of httrack