#53 Handle redirect instructions which can lead to a loop

closed-fixed
None
5
2008-03-30
2005-03-02
james abley
No

As previously mentioned on the mailing list.

I had a situation where a page that I was testing was
sending back a series of 302 responses and entered into
a recursive loop since the location header started to
repeat. This was giving a StackOverflowException, as
demonstrated by the included test cases. The patch to
WebWindow.java fixes this.

The patch was created against the HEAD on the date of
submission using Eclipse 3.0.1 and has been
successfully applied locally against the same.

Please note the attempted ExecuteAroundMethod in
WebWindow.getRequest(WebRequest). It passes the tests
that I've supplied, but I think that there could be
more rigorous tests which would break it - I just can't
think what they might be at the moment! I would
appreciate a reviewer checking that this part is correct.

Discussion

  • james abley

    james abley - 2005-03-02

    Patch file containing patch to WebWindow.java and WebClientTest.java, plus new file RecursiveRedirectionException.java

     
  • Wolfgang Fahl

    Wolfgang Fahl - 2008-03-30
    • assigned_to: nobody --> wolfgang_fahl
    • status: open --> closed-fixed
     
  • Wolfgang Fahl

    Wolfgang Fahl - 2008-03-30

    Logged In: YES
    user_id=1220573
    Originator: NO

    The change is now in the subversion repository and will be in the next release.

     
  • Wolfgang Fahl

    Wolfgang Fahl - 2008-03-30

    Logged In: YES
    user_id=1220573
    Originator: NO

    Thanks a lot - nice work!

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks