Re: [Http-webtest-general] Small bug in ReportPlugin.pm

[Duncan C. <dca...@bc...>]

On 2003-03-21 Amit Kaul wrote:
>Hi All,
>
>First of all, wanted to thank the developers of Webtest. This is a great 
>module and I am really using it to the fullest :-). Kudos to you.
>
>However, I was trying to setup multiple mail_addresses in a wtscript and for 
>some reason it was giving me an error.
>
>ie. mail_addresses = ( ab...@ao... xy...@ao... )
>would come back with the following error.
>
>>>RCPT To:<ab...@ao....xy...@ao...>
><<< 553 malformed address: <ab...@ao....xy...@ao...>
>550 <ab...@ao....xy...@ao...>... User unknown
>
>I looked into it and this is what I came up with to fix it. Could you please 
>commment?
>
>Thanks,
>Amit
>
>Basically the $to should be @to in ReportPlugin.pm. This is because 
>NET::SMTP.pm wants an array of recipients.
>
>akaul_9:/lib/HTTP/WebTest>diff old.ReportPlugin.pm ReportPlugin.pm
>238c238,239
><     my $to = join ', ', @$mail_addresses;
>---
>>       my $temp = join / /, @$mail_addresses;
>>   my @to = split /\s+/, $temp; # push elements into @to array
>240c241
><     $self->_smtp_cmd($smtp, 'to', $to);
>---
>>     $self->_smtp_cmd($smtp, 'to', @to);
>243c244
><     $self->_smtp_cmd($smtp, 'datasend', "To: $to\n");
>---
>>     $self->_smtp_cmd($smtp, 'datasend', "To: @to\n");
>
Without actually testing anything, isn't it simply

    $self->_smtp_cmd($smtp, 'to', $to);

becomes 

    $self->_smtp_cmd($smtp, 'to', @$mail_addresses);

Regards,
Duncan