Menu
▾
▴
[HtmlUnit] [ htmlunit-Patches-797144 ] about:blank,window.frames["name"] patch & small fix
|
From: SourceForge.net <no...@so...> - 2003-09-04 00:44:30
|
Patches item #797144, was opened at 2003-08-29 08:06 Message generated for change (Comment added) made by chen_jun You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=448268&aid=797144&group_id=47038 Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Jun Chen (chen_jun) Assigned to: Mike Bowler (mbowler) Summary: about:blank,window.frames["name"] patch & small fix Initial Comment: This patch has done: 1. "about:" URL and "about:blank" javascript handling. 2. window.frames["name"] implementation 3. Multiple cookies submit bug fix. To exchange multiple cookies with some "strict" server like mail.yahoo.com, our HttpClient has to be in strict mode to merge multiple cookie header into one cookie header. 4. WebClient(BrowserVersion, httpProxy,httpPort) misses setting BrowserVersion. 5. document.open() place holder ---------------------------------------------------------------------- >Comment By: Jun Chen (chen_jun) Date: 2003-09-04 00:44 Message: Logged In: YES user_id=850655 About Item 3, I'd like to explain more. When I use htmlunit to get http://mail.yahoo.com, it's ok. One cookie is set by server side. Then I set the login name and password and submit again. This time, server give me another 2 cookies, and redirect me to another page to verify my login. Now the problem appears, htmlunit just send these 3 cookies in 3 cookie hearders . But the yahoo server can only accept one cookie header. And I found httpclient can be set to strict mode, so that httpclient will merge multiple cookies into one cookie header when submitting to server. That's why I think to use httpclient's strict mode is better for htmlunit. BTW, if you use http proxy to access mail.yahoo.com, you may not find this problem, because some proxy can merge multiple cookie headers into one. Sorry for my patch stuffed several features. Next time, I'll keep the rule one patch one feature. My previous wrong idea is that very small patch will annoy you and htmlunit users :) ---------------------------------------------------------------------- Comment By: Mike Bowler (mbowler) Date: 2003-09-03 19:45 Message: Logged In: YES user_id=46756 Part of this patch has been accepted and part has not. I have accepted and commited #1, #2, #4 and #5 - thanks #3 has not been accepted as I don't understand what it's supposed to fix. It claims to fix a problem connecting to mail.yahoo.com but the current code doesn't have a problem connecting to that server. I am closing this item because it covers so many different things and most of them have been addressed. In future, please don't put as many different things into one patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=448268&aid=797144&group_id=47038 |
