RE: [Htmlunit-user] Virtual Host feature -- tests?

[Erskine, C. <chr...@ed...>]

I would start by overloading the getPage call to add the extra
parameter.  This would then allow all of the existing calls still work
and you would only be adding the test that calls your new method.

Chris Erskine
=20
EDS Consulting Services
Colorado Springs, CO=20
=20
Phone: 719-265-5962
Cell: 719-640-6488

> -----Original Message-----
> From: htm...@li... [mailto:htmlunit-user-
> ad...@li...] On Behalf Of Dan Levine
> Sent: Tuesday, May 03, 2005 2:10 PM
> To: htm...@li...
> Subject: [Htmlunit-user] Virtual Host feature -- tests?
>=20
> Hey all,
>=20
> I need to allow virtual host functionality for my tests.  After asking
> here
> a bit ago, I took the issue up with the HttpClient list.  They showed
my
> how
> to achieve this functionality which I began testing out thought the
> HttpClient in the HttpWebConnection class.  turns out there was a bug
in
> HttpClient, and they have now provided a patch.  Now, I would like to
add
> an
> additional parameter to WebClient.getPage(..) to take a String
virtualHost
> in as well as a URL.  I am not sure how to go about writing tests for
this
> however, since none of the getPage(..) functions currently have tests,
and
> since this is hitting right in the middle of MockWebConnection.  Since
the
> change also needs to go down into HttpWebConnection.getResponse(..) so
I
> could add the tests there, but there are not currently any tests for
the
> HttpWebConnection.getResponse(..) functions that i can model it after.
>=20
> Thoughts?
>=20
> dan
>=20
> > -----Original Message-----
> > From: htm...@li...
> > [mailto:htm...@li...]On Behalf Of Marc
> > Guillemot
> > Sent: Tuesday, May 03, 2005 6:24 AM
> > To: htm...@li...
> > Subject: Re: [Htmlunit-user] Re: Javascript problem
> >
> >
> > Dave Kosenko wrote:
> > > But I am running v 1.5 and am seeing the problem .  Do you mean
that
> it
> > > is fixed in versions
> > > *after* 1.5?
> >
> > yes, this is has been fixed since version 1.5 and as long as no
> > new release is published, you can only get it using the
> > CVS access.
> >
> > Marc.
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: NEC IT Guy Games.
> > Get your fingers limbered up and give it your best shot. 4 great
events,
> 4
> > opportunities to win big! Highest score wins.NEC IT Guy Games. Play
to
> > win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=3D20
> > _______________________________________________
> > Htmlunit-user mailing list
> > Htm...@li...
> > https://lists.sourceforge.net/lists/listinfo/htmlunit-user
> >
>=20
>=20
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.
> Get your fingers limbered up and give it your best shot. 4 great
events, 4
> opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
> win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=3D20
> _______________________________________________
> Htmlunit-user mailing list
> Htm...@li...
> https://lists.sourceforge.net/lists/listinfo/htmlunit-user