From: <rb...@us...> - 2017-05-29 16:27:56
|
Revision: 14485 http://sourceforge.net/p/htmlunit/code/14485 Author: rbri Date: 2017-05-29 16:27:53 +0000 (Mon, 29 May 2017) Log Message: ----------- missing tests for the new svg element Modified Paths: -------------- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/dom/Document.java trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementDefaultStyleDisplayTest.java Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/dom/Document.java =================================================================== --- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/dom/Document.java 2017-05-29 15:25:56 UTC (rev 14484) +++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/dom/Document.java 2017-05-29 16:27:53 UTC (rev 14485) @@ -91,6 +91,7 @@ import com.gargoylesoftware.htmlunit.html.HtmlRp; import com.gargoylesoftware.htmlunit.html.HtmlRt; import com.gargoylesoftware.htmlunit.html.HtmlScript; +import com.gargoylesoftware.htmlunit.html.HtmlSvg; import com.gargoylesoftware.htmlunit.html.HtmlUnknownElement; import com.gargoylesoftware.htmlunit.html.impl.SimpleRange; import com.gargoylesoftware.htmlunit.javascript.SimpleScriptable; @@ -664,7 +665,7 @@ } final SgmlPage page = getPage(); - final org.w3c.dom.Node element = page.createElement(tagName); + org.w3c.dom.Node element = page.createElement(tagName); if (element instanceof BaseFrameElement) { ((BaseFrameElement) element).markAsCreatedByJavascript(); @@ -687,6 +688,9 @@ else if (element instanceof HtmlUnknownElement) { ((HtmlUnknownElement) element).markAsCreatedByJavascript(); } + else if (element instanceof HtmlSvg) { + element = page.createElement("unknown"); + } final Object jsElement = getScriptableFor(element); if (jsElement == NOT_FOUND) { Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java =================================================================== --- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java 2017-05-29 15:25:56 UTC (rev 14484) +++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java 2017-05-29 16:27:53 UTC (rev 14485) @@ -1327,6 +1327,17 @@ } /** + * Test {@link com.gargoylesoftware.htmlunit.html.HtmlSuperscript}. + * + * @throws Exception if an error occurs + */ + @Test + @Alerts("[object HTMLUnknownElement]") + public void svg() throws Exception { + test("svg"); + } + + /** * Test {@link com.gargoylesoftware.htmlunit.html.HtmlTable}. * * @throws Exception if an error occurs Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementDefaultStyleDisplayTest.java =================================================================== --- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementDefaultStyleDisplayTest.java 2017-05-29 15:25:56 UTC (rev 14484) +++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementDefaultStyleDisplayTest.java 2017-05-29 16:27:53 UTC (rev 14485) @@ -1501,6 +1501,19 @@ } /** + * Test {@link com.gargoylesoftware.htmlunit.html.HtmlSuperscript}. + * + * @throws Exception if the test fails + */ + @Test + @Alerts(DEFAULT = {"", "inline"}, + FF = {"block", "inline"}, + IE = {"inline", "inline"}) + public void svg() throws Exception { + loadPageWithAlerts2(test("svg")); + } + + /** * Test {@link com.gargoylesoftware.htmlunit.html.HtmlTable}. * * @throws Exception if the test fails |