Menu
▾
▴
[HtmlUnit] SVN: [14356] trunk/htmlunit/src
|
From: <asa...@us...> - 2017-05-04 12:25:13
|
Revision: 14356
http://sourceforge.net/p/htmlunit/code/14356
Author: asashour
Date: 2017-05-04 12:25:10 +0000 (Thu, 04 May 2017)
Log Message:
-----------
remove IE8 from comments
Modified Paths:
--------------
trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElement.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementOuterHtmlTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HTMLParser4Test.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/MalformedHtmlTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEConditionalCompilationTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEWeirdSyntaxTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLFormElementTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLScriptElementTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTextAreaElementTest.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/source/JQueryExtractor.java
Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElement.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElement.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElement.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -2531,7 +2531,7 @@
* Sets the {@code hidden} property.
* @param hidden the {@code hidden} value
*/
- @JsxGetter
+ @JsxSetter
public void setHidden(final boolean hidden) {
if (hidden) {
getDomNodeOrDie().setAttribute("hidden", "hidden");
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementCreationTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -1481,10 +1481,6 @@
@Test
@Alerts("[object HTMLTitleElement]")
public void title() throws Exception {
- // there seems to be a bug in ie8
- // document.createElement('title') creates a text element
- // instead of a title. But if you use the title html tag
- // you end with a title element.
test("title");
}
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementOuterHtmlTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementOuterHtmlTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/general/ElementOuterHtmlTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -40,8 +40,6 @@
+ " while (value && (value.charAt(0) == '\\r' || value.charAt(0) == '\\n')) {\n"
+ " value = value.substring(1);\n"
+ " }\n"
- // IE8 inserts a fancy namespace declaration if the tag is unknown
- // and of course IE10 is different
+ " value = value.replace('<?XML:NAMESPACE PREFIX = PUBLIC NS = \"URN:COMPONENT\" />', '');\n"
+ " value = value.replace('<?XML:NAMESPACE PREFIX = \"PUBLIC\" NS = \"URN:COMPONENT\" />', '');\n"
+ " alert(value);\n"
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HTMLParser4Test.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HTMLParser4Test.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HTMLParser4Test.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -414,8 +414,7 @@
/**
* Test for a case where complete HTML page is present inside DIV tag.
- * IE8 ignores the HTML tag, BODY tag and complete HEAD along with content inside HEAD.
- * Others ignores only HTML, HEAD and BODY tags. Contents of HEAD and BODY are added to
+ * Browsers ignore only HTML, HEAD and BODY tags. Contents of HEAD and BODY are added to
* the current node (DIV tag in test case).
*
* @throws Exception failure
@@ -473,8 +472,7 @@
/**
* Test for a case where complete HTML page is added using document.write() inside DIV tag.
- * IE8 ignores the HTML tag, BODY tag and complete HEAD along with content inside HEAD.
- * Others ignores only HTML, HEAD and BODY tags. Contents of HEAD and BODY are added to
+ * Browsers ignore only HTML, HEAD and BODY tags. Contents of HEAD and BODY are added to
* the current node (DIV tag in test case).
*
* @throws Exception failure
@@ -531,8 +529,7 @@
/**
* Test for a case where complete HTML page is set in innerHTML of DIV tag.
* Behavior is same for any TAG inside body including BODY tag.
- * IE8 ignores the HTML tag, BODY tag and complete HEAD along with content inside HEAD.
- * Others ignores only HTML, HEAD and BODY tags. Contents of HEAD and BODY are added to
+ * Browsers ignore only HTML, HEAD and BODY tags. Contents of HEAD and BODY are added to
* the current node (DIV tag in test case).
*
* @throws Exception failure
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/MalformedHtmlTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/MalformedHtmlTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/MalformedHtmlTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -357,8 +357,6 @@
// <a id="outerA">V<div id="innerDiv">W<a id="innerA">X</a>Y</div>Z</a>
// CHROME and IE generate:
// <a id="outerA">V</a><div id="innerDiv"><a id="outerA">W</a><a id="innerA">X</a>Y</div>Z
- // IE8 generates (total mess):
- // <a id="outerA">V<div id="innerDiv">W<a id="innerA">X</a>Y</div></a><a id="innerA">X</a>YZ</a/>
// HtmlUnit generates:
// <a id="outerA">V<div id="innerDiv">W</div></a><a id="innerA">X</a>YZ
public void nestedAnchorInDivision() throws Exception {
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEConditionalCompilationTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEConditionalCompilationTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEConditionalCompilationTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -69,7 +69,6 @@
* @throws Exception if the test fails
*/
@Test
- //TODO: fails with IE8 with WebDriver, but succeeds manually
public void simple4() throws Exception {
final String script = "/*@cc_on alert(1) @*/\n"
+ "/*@if (@_win32)\n"
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEWeirdSyntaxTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEWeirdSyntaxTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/IEWeirdSyntaxTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -22,7 +22,7 @@
import com.gargoylesoftware.htmlunit.WebDriverTestCase;
/**
- * Test for IE weird JavaScript syntax (supported by IE8).
+ * Test for IE weird JavaScript syntax.
*
* @author Marc Guillemot
* @author Ronald Brill
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -3788,7 +3788,6 @@
*/
@Test
@Alerts("executed")
- // IE8 does not support appendChild for script elements
public void appendChildExecuteJavaScript() throws Exception {
final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
+ "<html><head><title>foo</title><script>\n"
@@ -3814,7 +3813,6 @@
*/
@Test
@Alerts("executed")
- // IE8 does not support appendChild for script elements
public void appendChildExecuteNestedJavaScript() throws Exception {
final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
+ "<html><head><title>foo</title><script>\n"
@@ -3866,7 +3864,6 @@
*/
@Test
@Alerts("executed")
- // IE8 does not support appendChild for script elements
public void insertBeforeExecuteJavaScript() throws Exception {
final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
+ "<html><head><title>foo</title><script>\n"
@@ -3892,7 +3889,6 @@
*/
@Test
@Alerts("executed")
- // IE8 does not support appendChild for script elements
public void insertBeforeExecuteNestedJavaScript() throws Exception {
final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
+ "<html><head><title>foo</title><script>\n"
@@ -3944,7 +3940,6 @@
*/
@Test
@Alerts("executed")
- // IE8 does not support appendChild for script elements
public void replaceChildExecuteJavaScript() throws Exception {
final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
+ "<html><head><title>foo</title><script>\n"
@@ -3970,7 +3965,6 @@
*/
@Test
@Alerts("executed")
- // IE8 does not support appendChild for script elements
public void replaceChildExecuteNestedJavaScript() throws Exception {
final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
+ "<html><head><title>foo</title><script>\n"
@@ -4199,10 +4193,7 @@
+ "<html><head><title>foo</title><script>\n"
+ " function test() {\n"
+ " var newnode = document.createElement('script');\n"
- // IE8 does not support appendChild for script elements
- + " try {\n"
- + " newnode.appendChild(document.createTextNode('alerter();'));\n"
- + " } catch(e) { alert('exception-append'); return }\n"
+ + " newnode.appendChild(document.createTextNode('alerter();'));\n"
+ " var outernode = document.getElementById('myNode');\n"
+ " if (!outernode.insertAdjacentElement) { alert('insertAdjacentElement not available'); return }\n"
@@ -4230,10 +4221,7 @@
+ " var newnode = document.createElement('div');\n"
+ " var newscript = document.createElement('script');\n"
+ " newnode.appendChild(newscript);\n"
- // IE8 does not support appendChild for script elements
- + " try {\n"
- + " newscript.appendChild(document.createTextNode('alerter();'));\n"
- + " } catch(e) { alert('exception-append'); return }\n"
+ + " newscript.appendChild(document.createTextNode('alerter();'));\n"
+ " var outernode = document.getElementById('myNode');\n"
+ " if (!outernode.insertAdjacentElement) { alert('insertAdjacentElement not available'); return }\n"
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLFormElementTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLFormElementTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLFormElementTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -1191,9 +1191,6 @@
}
/**
- * For IE8: calling form.submit() immediately triggers a request but only the
- * last response for a page is parsed.
- * For FF10+ and Chrome: only one request, the last one.
* @throws Exception if the test fails
*/
@Test
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLScriptElementTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLScriptElementTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLScriptElementTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -202,7 +202,6 @@
@Test
@Alerts({"start", "end"})
public void createElementWithCreateTextNode() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script>\n"
@@ -227,7 +226,6 @@
@Test
@Alerts({"start", "middle", "executed", "end"})
public void createElementWithCreateTextNodeAndAppend() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script>\n"
@@ -346,7 +344,6 @@
@Test
@Alerts({"start", "end"})
public void replaceSelfWithCreateTextNode() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script>\n"
@@ -416,7 +413,6 @@
@Test
@Alerts({"start", "executed", "end"})
public void replaceWithCreateTextNodeEmpty() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script id='js1'></script>\n"
@@ -441,7 +437,6 @@
@Test
@Alerts({"start", "end"})
public void replaceWithCreateTextNodeBlank() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script id='js1'> </script>\n"
@@ -466,7 +461,6 @@
@Test
@Alerts({"script", "start", "end"})
public void replaceWithCreateTextNodeScript() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script id='js1'>\n"
@@ -874,7 +868,6 @@
*/
@Test
public void appendChild_UnexpectedCall() throws Exception {
- // IE (at least IE6 and IE8) does not support script.appendChild(source)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script>\n"
@@ -897,7 +890,6 @@
*/
@Test
public void insertBeforeUnexpectedCall() throws Exception {
- // IE (at least IE6 and IE8) does not support script.insertBefore(source, null)
final String html =
"<html><head><title>foo</title></head><body>\n"
+ "<script>\n"
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTextAreaElementTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTextAreaElementTest.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTextAreaElementTest.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -600,8 +600,8 @@
* @throws Exception if the test fails
*/
@Test
- @Alerts(DEFAULT = {"-1", /* "null", */ "32", "32", "-1", "ms"},
- IE = {"2147483647", /* "null", */ "32", "32", "2147483647", "ms"})
+ @Alerts(DEFAULT = {"-1", "null", "32", "32", "-1", "ms"},
+ IE = {"2147483647", "null", "32", "32", "2147483647", "ms"})
public void getMaxLength() throws Exception {
final String html
= "<html>\n"
@@ -609,7 +609,7 @@
+ " <script>\n"
+ " function test() {\n"
+ " alert(document.form1.textarea1.maxLength);\n"
- // + " alert(document.form1.textarea1.getAttribute('maxLength'));\n"
+ + " alert(document.form1.textarea1.getAttribute('maxLength'));\n"
+ " alert(document.form1.textarea2.maxLength);\n"
+ " alert(document.form1.textarea2.getAttribute('maxLength'));\n"
+ " alert(document.form1.textarea3.maxLength);\n"
@@ -629,34 +629,9 @@
}
/**
- * Separated from the above testcase; can be merged back if fixed.
* @throws Exception if the test fails
*/
@Test
- @Alerts("null")
- public void getMaxLength_IE8Failing() throws Exception {
- final String html
- = "<html>\n"
- + "<head><title>foo</title>\n"
- + " <script>\n"
- + " function test() {\n"
- + " alert(document.form1.textarea1.getAttribute('maxLength'));\n"
- + " }\n"
- + " </script>\n"
- + "</head>\n"
- + "<body onload='test()'>\n"
- + " <form name='form1' method='post' >\n"
- + " <textarea name='textarea1'></textarea>\n"
- + " </form>\n"
- + "</body></html>";
-
- loadPageWithAlerts2(html);
- }
-
- /**
- * @throws Exception if the test fails
- */
- @Test
@Alerts(DEFAULT = {"10", "10", "error", "10", "10", "0", "0"},
IE = {"10", "10", "-1", "-1", "0", "0"})
public void setMaxLength() throws Exception {
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/source/JQueryExtractor.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/source/JQueryExtractor.java 2017-05-04 12:17:45 UTC (rev 14355)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/source/JQueryExtractor.java 2017-05-04 12:25:10 UTC (rev 14356)
@@ -48,8 +48,6 @@
* Extracts the needed expectation from the real browsers output, this is done by waiting the browser to finish
* all the tests, then select all visible text and copy it to a local file.
*
- * In IE8 raw file, test outputs should be manually separated in a new line.
- *
* Steps to generate the tests:
* <ol>
* <li>Call {@link #extractExpectations(File, File)}, where <tt>input</tt> is the raw file from the browser</li>
|
