[HtmlUnit] SVN: [9181] trunk/htmlunit/src

[<rb...@us...>]

Revision: 9181
          http://sourceforge.net/p/htmlunit/code/9181
Author:   rbri
Date:     2014-03-15 19:40:42 +0000 (Sat, 15 Mar 2014)
Log Message:
-----------
fix table row group initialization (no preset of valign); source element configuration fix

Modified Paths:
--------------
    trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/TableRowGroup.java
    trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLSourceElement.java
    trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java
    trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElementTest.java

Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/TableRowGroup.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/TableRowGroup.java	2014-03-15 16:42:16 UTC (rev 9180)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/TableRowGroup.java	2014-03-15 19:40:42 UTC (rev 9181)
@@ -14,8 +14,6 @@
  */
 package com.gargoylesoftware.htmlunit.html;
 
-import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.HTMLELEMENT_ALIGN_INVALID;
-
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -46,10 +44,6 @@
     protected TableRowGroup(final String qualifiedName, final SgmlPage page,
             final Map<String, DomAttr> attributes) {
         super(qualifiedName, page, attributes);
-        final boolean invalidAlign = hasFeature(HTMLELEMENT_ALIGN_INVALID);
-        if (invalidAlign && !hasAttribute("align")) {
-            setAttribute("align", "left");
-        }
     }
 
     /**

Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLSourceElement.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLSourceElement.java	2014-03-15 16:42:16 UTC (rev 9180)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLSourceElement.java	2014-03-15 19:40:42 UTC (rev 9181)
@@ -33,5 +33,13 @@
 @JsxClass(domClass = HtmlSource.class, browsers = { @WebBrowser(FF),
         @WebBrowser(value = IE, minVersion = 11), @WebBrowser(CHROME) })
 public class HTMLSourceElement extends HTMLElement {
-    // nothing so far
+
+    /**
+     * Returns whether the end tag is forbidden or not.
+     * @see <a href="http://www.w3.org/TR/html4/index/elements.html">HTML 4 specs</a>
+     * @return whether the end tag is forbidden or not
+     */
+    protected boolean isEndTagForbidden() {
+        return true;
+    }
 }

Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java	2014-03-15 16:42:16 UTC (rev 9180)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLElementTest.java	2014-03-15 19:40:42 UTC (rev 9181)
@@ -4219,7 +4219,6 @@
     @Test
     @Alerts(DEFAULT = "<source>",
             IE8 = "<source></source>")
-    @NotYetImplemented({ FF17, FF24 })
     public void outerHTML_source() throws Exception {
         loadPageWithAlerts2(outerHTML("source"));
     }
@@ -4309,7 +4308,6 @@
     @Test
     @Alerts(DEFAULT = "<tbody></tbody>",
             IE8 = "<TBODY></TBODY>")
-    @NotYetImplemented({ FF17, FF24 })
     public void outerHTML_tbody() throws Exception {
         loadPageWithAlerts2(outerHTML("tbody"));
     }
@@ -4360,7 +4358,6 @@
     @Test
     @Alerts(DEFAULT = "<tfoot></tfoot>",
             IE8 = "<TFOOT></TFOOT>")
-    @NotYetImplemented({ FF17, FF24 })
     public void outerHTML_tfoot() throws Exception {
         loadPageWithAlerts2(outerHTML("tfoot"));
     }
@@ -4371,7 +4368,6 @@
     @Test
     @Alerts(DEFAULT = "<thead></thead>",
             IE8 = "<THEAD></THEAD>")
-    @NotYetImplemented({ FF17, FF24 })
     public void outerHTML_thead() throws Exception {
         loadPageWithAlerts2(outerHTML("thead"));
     }

Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElementTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElementTest.java	2014-03-15 16:42:16 UTC (rev 9180)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLTableSectionElementTest.java	2014-03-15 19:40:42 UTC (rev 9181)
@@ -41,7 +41,6 @@
     @Test
     @Alerts(DEFAULT = {"", "hello", "left", "hi", "right" },
             IE = {"", "error", "", "left", "error", "left", "right" })
-    @NotYetImplemented({ FF17, FF24 })
     public void align_thead() throws Exception {
         align("th");
     }
@@ -52,7 +51,6 @@
     @Test
     @Alerts(DEFAULT = {"", "hello", "left", "hi", "right" },
             IE = {"", "error", "", "left", "error", "left", "right" })
-    @NotYetImplemented({ FF17, FF24 })
     public void align_tbody() throws Exception {
         align("tb");
     }
@@ -63,7 +61,6 @@
     @Test
     @Alerts(DEFAULT = {"", "hello", "left", "hi", "right" },
             IE = {"", "error", "", "left", "error", "left", "right" })
-    @NotYetImplemented({ FF17, FF24 })
     public void align_tfoot() throws Exception {
         align("tf");
     }