Menu
▾
▴
[HtmlUnit] SVN: [8869] trunk/htmlunit/src
|
From: <asa...@us...> - 2013-12-18 09:48:03
|
Revision: 8869
http://sourceforge.net/p/htmlunit/code/8869
Author: asashour
Date: 2013-12-18 09:48:00 +0000 (Wed, 18 Dec 2013)
Log Message:
-----------
JavaScript: fix parseInt() when the value has a leading 0.
Issue 1563
Modified Paths:
--------------
trunk/htmlunit/src/changes/changes.xml
trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/HtmlUnitContextFactory.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/GlobalFunctionsTest.java
Modified: trunk/htmlunit/src/changes/changes.xml
===================================================================
--- trunk/htmlunit/src/changes/changes.xml 2013-12-18 09:32:11 UTC (rev 8868)
+++ trunk/htmlunit/src/changes/changes.xml 2013-12-18 09:48:00 UTC (rev 8869)
@@ -8,6 +8,9 @@
<body>
<release version="2.14" date="???" description="Bugfixes">
+ <action type="fix" dev="asashour" issue="1563">
+ JavaScript: fix parseInt() when the value has a leading 0.
+ </action>
<action type="add" dev="asashour" issue="1536">
JavaScript: node and window.addEventListener() and .removeEventListener() are supported starting IE 9.
</action>
Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java 2013-12-18 09:32:11 UTC (rev 8868)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java 2013-12-18 09:48:00 UTC (rev 8869)
@@ -1070,6 +1070,11 @@
@BrowserFeature(@WebBrowser(IE))
JS_PARENT_PROTO_PROPERTIES,
+ /** Indicates that parseInt() should have radix 10 by default. */
+ @BrowserFeature({ @WebBrowser(value = IE, minVersion = 11), @WebBrowser(value = FF, minVersion = 24),
+ @WebBrowser(CHROME)})
+ JS_PARSE_INT_RADIX_10,
+
/** Indicates that HTMLPhraseElements returning 'HTMLElement'
* as class name. */
@BrowserFeature(@WebBrowser(FF))
Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/HtmlUnitContextFactory.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/HtmlUnitContextFactory.java 2013-12-18 09:32:11 UTC (rev 8868)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/HtmlUnitContextFactory.java 2013-12-18 09:48:00 UTC (rev 8869)
@@ -341,6 +341,8 @@
return browserVersion_.hasFeature(BrowserVersionFeatures.JS_FUNCTION_OBJECT_METHOD);
case Context.FEATURE_HTMLUNIT_FUNCTION_DECLARED_FORWARD_IN_BLOCK:
return browserVersion_.hasFeature(BrowserVersionFeatures.JS_FUNCTION_DECLARED_FORWARD_IN_BLOCK);
+ case Context.FEATURE_HTMLUNIT_PARSE_INT_RADIX_10:
+ return browserVersion_.hasFeature(BrowserVersionFeatures.JS_PARSE_INT_RADIX_10);
default:
return super.hasFeature(cx, featureIndex);
}
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/GlobalFunctionsTest.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/GlobalFunctionsTest.java 2013-12-18 09:32:11 UTC (rev 8868)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/GlobalFunctionsTest.java 2013-12-18 09:48:00 UTC (rev 8869)
@@ -19,7 +19,6 @@
import com.gargoylesoftware.htmlunit.BrowserRunner;
import com.gargoylesoftware.htmlunit.BrowserRunner.Alerts;
-import com.gargoylesoftware.htmlunit.BrowserRunner.NotYetImplemented;
import com.gargoylesoftware.htmlunit.WebDriverTestCase;
/**
@@ -65,7 +64,6 @@
CHROME = { "0", "1", "-2345", "1", "12", "NaN", "0", "1", "8", "9", "100", "0", "1", "8", "9", "100" },
FF24 = { "0", "1", "-2345", "1", "12", "NaN", "0", "1", "8", "9", "100", "0", "1", "8", "9", "100" },
IE11 = { "0", "1", "-2345", "1", "12", "NaN", "0", "1", "8", "9", "100", "0", "1", "8", "9", "100" })
- @NotYetImplemented
public void parseInt() throws Exception {
final String html
= "<html><head><title>foo</title><script>\n"
|
