Menu
▾
▴
[HtmlUnit] SVN: [8311] trunk/htmlunit/src
|
From: <rb...@us...> - 2013-05-26 20:13:00
|
Revision: 8311
http://sourceforge.net/p/htmlunit/code/8311
Author: rbri
Date: 2013-05-26 20:12:57 +0000 (Sun, 26 May 2013)
Log Message:
-----------
fix event handling for IE
Modified Paths:
--------------
trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLInputElement.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput2Test.java
Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLInputElement.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLInputElement.java 2013-05-26 20:10:47 UTC (rev 8310)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLInputElement.java 2013-05-26 20:12:57 UTC (rev 8311)
@@ -15,6 +15,7 @@
package com.gargoylesoftware.htmlunit.javascript.host.html;
import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.JS_ALIGN_FOR_INPUT_IGNORES_VALUES;
+import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.JS_CLICK_CHECKBOX_TRIGGERS_NO_CHANGE_EVENT;
import static com.gargoylesoftware.htmlunit.javascript.configuration.BrowserName.FF;
import static com.gargoylesoftware.htmlunit.javascript.configuration.BrowserName.IE;
@@ -387,7 +388,9 @@
final boolean newState = domNode.isChecked();
if (originalState != newState
- && (domNode instanceof HtmlCheckBoxInput || domNode instanceof HtmlRadioButtonInput)) {
+ && (domNode instanceof HtmlRadioButtonInput
+ || (domNode instanceof HtmlCheckBoxInput
+ && !getBrowserVersion().hasFeature(JS_CLICK_CHECKBOX_TRIGGERS_NO_CHANGE_EVENT)))) {
domNode.fireEvent(Event.TYPE_CHANGE);
}
}
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput2Test.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput2Test.java 2013-05-26 20:10:47 UTC (rev 8310)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlCheckBoxInput2Test.java 2013-05-26 20:12:57 UTC (rev 8311)
@@ -26,7 +26,6 @@
import com.gargoylesoftware.htmlunit.BrowserRunner;
import com.gargoylesoftware.htmlunit.BrowserRunner.Alerts;
-import com.gargoylesoftware.htmlunit.BrowserRunner.Browser;
import com.gargoylesoftware.htmlunit.BrowserRunner.NotYetImplemented;
import com.gargoylesoftware.htmlunit.WebDriverTestCase;
@@ -799,7 +798,6 @@
*/
@Test
@Alerts(DEFAULT = "changed", IE = { })
- @NotYetImplemented(Browser.IE)
public void clickShouldTriggerOnchange() throws Exception {
final String html = "<html><head><title>foo</title>\n"
+ "<script>\n"
|
