Menu
▾
▴
[HtmlUnit] SVN: [8221] trunk/htmlunit/src
|
From: <rb...@us...> - 2013-04-13 10:14:05
|
Revision: 8221
http://sourceforge.net/p/htmlunit/code/8221
Author: rbri
Date: 2013-04-13 10:14:00 +0000 (Sat, 13 Apr 2013)
Log Message:
-----------
Starting with IE8 the radio button checked state is reseted to false when adding to page
Modified Paths:
--------------
trunk/htmlunit/src/changes/changes.xml
trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput.java
trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput2Test.java
Modified: trunk/htmlunit/src/changes/changes.xml
===================================================================
--- trunk/htmlunit/src/changes/changes.xml 2013-04-12 19:07:54 UTC (rev 8220)
+++ trunk/htmlunit/src/changes/changes.xml 2013-04-13 10:14:00 UTC (rev 8221)
@@ -8,6 +8,10 @@
<body>
<release version="2.13" date="???" description="Bugfixes">
+ <action type="fix" dev="rbri">
+ JavaScript: Starting with IE8 the radio button checked state is reseted to false
+ when adding to page.
+ </action>
<action type="update" dev="rbri">
Upgrade Apache HttpClient to 4.2.4.
</action>
Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java 2013-04-12 19:07:54 UTC (rev 8220)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/BrowserVersionFeatures.java 2013-04-13 10:14:00 UTC (rev 8221)
@@ -605,10 +605,14 @@
@BrowserFeature(@WebBrowser(IE))
HTMLPARSER_REMOVE_EMPTY_CONTENT,
- /** Set this checked state back to default when added to page (IE). */
- @BrowserFeature(@WebBrowser(IE))
+ /** Set this checked state back to default when added to page (IE6). */
+ @BrowserFeature(@WebBrowser(value = IE, maxVersion = 7))
HTMLRADIOINPUT_SET_CHECKED_TO_DEFAULT_WHEN_ADDED,
+ /** Set this checked state to false when added to page (IE). */
+ @BrowserFeature(@WebBrowser(value = IE, minVersion = 8))
+ HTMLRADIOINPUT_SET_CHECKED_TO_FALSE_WHEN_ADDED,
+
/**
* Set this property if the script tag supports the
* types 'application/javascript' and 'application/x-javascript'.
Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput.java
===================================================================
--- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput.java 2013-04-12 19:07:54 UTC (rev 8220)
+++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput.java 2013-04-13 10:14:00 UTC (rev 8221)
@@ -17,6 +17,7 @@
import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.EVENT_ONCHANGE_LOSING_FOCUS;
import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.HTMLINPUT_DEFAULT_IS_CHECKED;
import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.HTMLRADIOINPUT_SET_CHECKED_TO_DEFAULT_WHEN_ADDED;
+import static com.gargoylesoftware.htmlunit.BrowserVersionFeatures.HTMLRADIOINPUT_SET_CHECKED_TO_FALSE_WHEN_ADDED;
import java.io.IOException;
import java.util.Map;
@@ -208,6 +209,9 @@
if (hasFeature(HTMLRADIOINPUT_SET_CHECKED_TO_DEFAULT_WHEN_ADDED)) {
setChecked(isDefaultChecked());
}
+ if (hasFeature(HTMLRADIOINPUT_SET_CHECKED_TO_FALSE_WHEN_ADDED)) {
+ setChecked(false);
+ }
}
/**
Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput2Test.java
===================================================================
--- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput2Test.java 2013-04-12 19:07:54 UTC (rev 8220)
+++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/html/HtmlRadioButtonInput2Test.java 2013-04-13 10:14:00 UTC (rev 8221)
@@ -42,7 +42,8 @@
*/
@Test
@Alerts(DEFAULT = { "true", "true", "true", "true", "true", "true" },
- IE = { "true", "false", "false", "false", "true", "true" })
+ IE = { "true", "false", "false", "false", "false", "false" },
+ IE6 = { "true", "false", "false", "false", "true", "true" })
public void checked_on_attachment() throws Exception {
final String html = "<html>\n"
+ "<head>\n"
|
