From: <mgu...@us...> - 2013-01-28 15:52:04
|
Revision: 8053 http://sourceforge.net/p/htmlunit/code/8053 Author: mguillem Date: 2013-01-28 15:52:02 +0000 (Mon, 28 Jan 2013) Log Message: ----------- FF doesn't normalize case of align, added expectations for FF17 Modified Paths: -------------- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElement.java trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElementTest.java Modified: trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElement.java =================================================================== --- trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElement.java 2013-01-28 15:42:21 UTC (rev 8052) +++ trunk/htmlunit/src/main/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElement.java 2013-01-28 15:52:02 UTC (rev 8053) @@ -193,8 +193,7 @@ * @param align the value of the "align" property */ @JsxSetter - public void setAlign(String align) { - align = align.toLowerCase(); + public void setAlign(final String align) { final boolean acceptArbitraryValues = getBrowserVersion().hasFeature(JS_ALIGN_ACCEPTS_ARBITRARY_VALUES); if (acceptArbitraryValues) { getDomNodeOrDie().setAttribute("align", align); Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElementTest.java =================================================================== --- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElementTest.java 2013-01-28 15:42:21 UTC (rev 8052) +++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/html/HTMLImageElementTest.java 2013-01-28 15:52:02 UTC (rev 8053) @@ -20,8 +20,10 @@ import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebElement; +import static com.gargoylesoftware.htmlunit.BrowserRunner.Browser.FF17; import com.gargoylesoftware.htmlunit.BrowserRunner; import com.gargoylesoftware.htmlunit.BrowserRunner.Alerts; +import com.gargoylesoftware.htmlunit.BrowserRunner.NotYetImplemented; import com.gargoylesoftware.htmlunit.WebDriverTestCase; /** @@ -200,8 +202,11 @@ "top", "absbottom", "absmiddle", "baseline", "texttop", "wrong", "" }, FF10 = { "left", "right", "middle", "justify", "bottom", "middle", "top", "absbottom", "absmiddle", "bottom", "texttop", "wrong", "" }, + FF17 = { "left", "right", "middle", "justify", "bottom", "middle", + "top", "absbottom", "absmiddle", "bottom", "texttop", "wrong", "" }, IE = { "left", "right", "center", "", "bottom", "middle", "top", "absBottom", "absMiddle", "baseline", "textTop", "", "" }) + @NotYetImplemented(FF17) public void getAlign() throws Exception { final String html = "<html><body>\n" @@ -232,13 +237,16 @@ * @throws Exception if an error occurs */ @Test - @Alerts(DEFAULT = { "center", "8", "foo", "left", "right", "center", "justify", + @Alerts(DEFAULT = { "CenTer", "8", "foo", "left", "right", "center", "justify", "bottom", "middle", "top", "absbottom", "absmiddle", "baseline", "texttop" }, FF10 = { "CenTer", "8", "foo", "left", "right", "middle", "justify", "bottom", "middle", "top", "absbottom", "absmiddle", "bottom", "texttop" }, + FF17 = { "CenTer", "8", "foo", "left", "right", "middle", "justify", + "bottom", "middle", "top", "absbottom", "absmiddle", "bottom", "texttop" }, IE = { "center", "error", "center", "error", "center", "left", "right", "center", "error", "center", "bottom", "middle", "top", "absBottom", "absMiddle", "baseline", "textTop" }) + @NotYetImplemented(FF17) public void setAlign() throws Exception { final String html = "<html><body>\n" |