From: <asa...@us...> - 2012-12-12 10:54:00
|
Revision: 7861 http://sourceforge.net/p/htmlunit/code/7861 Author: asashour Date: 2012-12-12 10:53:56 +0000 (Wed, 12 Dec 2012) Log Message: ----------- CodeStyle: "two empty lines" is already part of checkstyle Modified Paths: -------------- trunk/htmlunit/src/changes/changes.xml trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/CodeStyleTest.java Modified: trunk/htmlunit/src/changes/changes.xml =================================================================== --- trunk/htmlunit/src/changes/changes.xml 2012-12-12 10:13:44 UTC (rev 7860) +++ trunk/htmlunit/src/changes/changes.xml 2012-12-12 10:53:56 UTC (rev 7861) @@ -8,7 +8,7 @@ <body> <release version="2.12" date="???" description="Bugfixes"> - <action type="fix" dev="asashour" issue="1456 "> + <action type="fix" dev="asashour" issue="1456"> JavaScript: fix the value of "(i in x)" for NodeList, HTMLCollection and CSSRuleList. </action> <action type="update" dev="asashour"> Modified: trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/CodeStyleTest.java =================================================================== --- trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/CodeStyleTest.java 2012-12-12 10:13:44 UTC (rev 7860) +++ trunk/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/CodeStyleTest.java 2012-12-12 10:53:56 UTC (rev 7861) @@ -109,7 +109,6 @@ lineBetweenMethods(lines, relativePath); svnProperties(file, relativePath); runWith(lines, relativePath); - twoEmptyLines(lines, relativePath); vs85aspx(lines, relativePath); deprecated(lines, relativePath); staticJSMethod(lines, relativePath); @@ -384,19 +383,6 @@ } /** - * Verifies that no two empty contiguous lines. - */ - private void twoEmptyLines(final List<String> lines, final String relativePath) { - for (int i = 1; i < lines.size(); i++) { - final String previousLine = lines.get(i - 1); - final String line = lines.get(i); - if (StringUtils.isBlank(previousLine) && StringUtils.isBlank(line)) { - addFailure("Two empty contiguous lines at " + relativePath + ", line: " + (i + 1)); - } - } - } - - /** * Verifies that no "(VS.85).aspx" token exists (which is sometimes used in MSDN documentation). */ private void vs85aspx(final List<String> lines, final String relativePath) { |