htmlunit-develop — General discussion of the development of HtmlUnit

[HtmlUnit] where is the latest cvs

[<ji...@ya...>]

Hi, everybody

I'm a newcomer to htmlunit. I have a plan to make some
fat-client application and I found htmlunit. I
compared httpunit and htmlunit, and my personal
feeling is htmlunit is compact and clean :) But in my
first week try, I also found some important but
missing or non-functional features, such as "mime form
post", javascript 'top.frames["abc"] ' not working,
and so on.(all based on the 1.2.3)
I'd like to contribute to make htmlunit better if
possible :)

But it seems that the latest cvs version on
sourceforge is just 1.2.2. How can I contribute?

Thanks.

Yours Sincerely,
Jim

_________________________________________________________
Do You Yahoo!? 
启用电邮帐号，领会雅虎通[身临其境聊电影]的动感魅力，还有网络摄像头+雅虎通收音机等你来拿
http://cn.rd.yahoo.com/mail_cn/tag/?http://cn.messenger.yahoo.com

[HtmlUnit] [ htmlunit-Bugs-779007 ] window.open() cause javascript exception

[SourceForge.net <no...@so...>]

Bugs item #779007, was opened at 2003-07-28 18:03
Message generated for change (Comment added) made by gousseff
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=779007&group_id=47038

Category: None
Group: None
>Status: Deleted
Resolution: None
Priority: 5
Submitted By: Alexei Goussev (gousseff)
Assigned to: Nobody/Anonymous (nobody)
Summary: window.open() cause javascript exception

Initial Comment:
I am runninig the following code now:

>>>
HtmlAnchor link = ...

WebWindowListener windowEventListener = new 
WebWindowListener() {
   public void webWindowContentChanged
(WebWindowEvent event) {
       log.warn("webWindowContentChanged called");
   }
           
   public void webWindowOpened(WebWindowEvent 
event) {
       log.warn("webWindowOpened called");
   }
};
       
webClient.addWebWindowListener(windowEventListener);
       
link.click();
<<<

where link has the following on click attribute: 
onclick="javascript:var win = window.open
('','versionWindow','height=500,width=650,top='+
((screen.height-(screen.height/1.618))-(500/2))+',left='+
((screen.width-650)/2)+',scrollbars,resizable');win.focus
()"

This code throws an Exception: what I see is:

[WARN] MyTestClass - -webWindowOpened called
E
Time: 18,141
There was 1 error:
1) test1(MyTestClass)======= EXCEPTION START 
========
EcmaError: lineNumber=[1] column=[0] lineSource=
[GargoyleWrapper6()] name=[TypeError] sourceName=
[Wrapper definition for
onClick handler] message=[Cannot convert null to an 
object.] errorObject=[TypeError: Cannot convert null to 
an object.]

com.gargoylesoftware.htmlunit.ScriptException: Cannot 
convert null to an object.
       at 
com.gargoylesoftware.htmlunit.javascript.JavaScriptEngin
e.execute(JavaScriptEngine.java:199)
       at 
com.gargoylesoftware.htmlunit.html.HtmlPage.executeJav
aScriptIfPossible(HtmlPage.java:767)
       at 
com.gargoylesoftware.htmlunit.html.HtmlAnchor.click
(HtmlAnchor.java:54)
       at MyTestClass.test1(MyTestClass.java:line where 
I call link.click())
       at sun.reflect.NativeMethodAccessorImpl.invoke0
(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
Enclosed exception:
TypeError: Cannot convert null to an object. (Wrapper 
definition for onClick handler; line 1)
       at org.mozilla.javascript.NativeGlobal.constructError
(NativeGlobal.java:597)
       at org.mozilla.javascript.NativeGlobal.constructError
(NativeGlobal.java:557)
       at org.mozilla.javascript.NativeGlobal.typeError0
(NativeGlobal.java:562)
       at org.mozilla.javascript.ScriptRuntime.toObject
(ScriptRuntime.java:510)
       at org.mozilla.javascript.ScriptRuntime.toObject
(ScriptRuntime.java:486)
       at org.mozilla.javascript.ScriptRuntime.getProp
(ScriptRuntime.java:707)
       at org.mozilla.javascript.gen.c88.call(Wrapper 
definition for onClick handler:1)
       at 
org.mozilla.javascript.optimizer.OptRuntime.callSimple
(OptRuntime.java:275)
       at org.mozilla.javascript.gen.c90.call(onClick 
handler:1)
       at org.mozilla.javascript.gen.c90.exec(onClick 
handler)
       at org.mozilla.javascript.Context.evaluateReader
(Context.java:820)
       at org.mozilla.javascript.Context.evaluateString
(Context.java:784)
       at 
com.gargoylesoftware.htmlunit.javascript.JavaScriptEngin
e.execute(JavaScriptEngine.java:191)
       at 
com.gargoylesoftware.htmlunit.html.HtmlPage.executeJav
aScriptIfPossible(HtmlPage.java:767)
       at 
com.gargoylesoftware.htmlunit.html.HtmlAnchor.click
(HtmlAnchor.java:54)
       at MyTestClass.test1(MyTestClass.java:line where 
I call link.click())
       at sun.reflect.NativeMethodAccessorImpl.invoke0
(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
== CALLING JAVASCRIPT ==
GargoyleWrapper6()
======= EXCEPTION END ========

Additional information (probably has nothing to do with 
the bug): the page that should appear in the new 
window contains 3 frames.

----------------------------------------------------------------------

>Comment By: Alexei Goussev (gousseff)
Date: 2003-08-22 18:30

Message:
Logged In: YES 
user_id=830552

This bug was deleted: window.open() works right except 
when 'about:blank' or '' are used as a parameter instead of 
valid url. Following is described in bug 793340:
'about:blank' and '' can not be used for frames and windows

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=779007&group_id=47038

RE: [HtmlUnit] Help with regard to HtmlSelect

[Rahul J. <rah...@sp...>]

Mike,
I do something like this.
     =20
Initially optVals is an empty select.=20
i.e it has no options.=20

HtmlSelect optVals =3D form.getSelectByName("selectedOpts");
optVals.fakeSelectedAttribute("DID");
Submit..

I expect that an option with value "DID"
would be added to the HtmlSelect optVals.
But the server does not do what it is expected to.
Nor do I get any error. The server processe as if=20
Htmlselect optVals is empty.

It would be nice if you could give me some
directions to go about debugging this.=20
e.g where can i see what is being sent to server
from the client?

Thanking you for your help.

-Rahul
=20

-----Original Message-----
From: Mike Bowler [mailto:mb...@Ga...]
Sent: Wednesday, August 20, 2003 4:55 PM
To: htm...@li...
Subject: Re: [HtmlUnit] Help with regard to HtmlSelect


Rahul Joshi wrote:
> I had tried fakeselectedAttribute() but it is not working?
> Can anyone help me how should I go  about debugging/figuring out=20
> the problem ..

Perhaps if you explained what you've tried and what response you've seen

then someone could offer some insight.

--=20
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com



-------------------------------------------------------
This SF.net email is sponsored by Dice.com.
Did you know that Dice has over 25,000 tech jobs available today? From
careers in IT to Engineering to Tech Sales, Dice has tech jobs from the
best hiring companies. http://www.dice.com/index.epl?rel_code=3D104
_______________________________________________
HtmlUnit-develop mailing list
Htm...@li...
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop

[HtmlUnit] [ htmlunit-Bugs-793340 ] 'about:blank' and '' can not be used for frames and windows

[SourceForge.net <no...@so...>]

Bugs item #793340, was opened at 2003-08-22 18:25
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=793340&group_id=47038

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Alexei Goussev (gousseff)
Assigned to: Nobody/Anonymous (nobody)
Summary: 'about:blank' and '' can not be used for frames and windows

Initial Comment:
'about:blank' and '' can not be used ínstead of url for 
frames and windows.

Following htmls cause an exception:

1.         	<frame  name="results"
                        title="Results"
                        scrolling="yes"
                        marginwidth="0" 
                        marginheight="0" 
                        border="1" 
                        framespacing="1"
                        noresize
                        src="about:blank">

2a.          <a href="http://htmlunit.sourceforge.net" 
target="htmlunit" title="HtmlUnit (Presented in a New 
Window)" 
onmouseover="javascript:window.status='HtmlUnit 
(Presented in a New Window)'; return true" 
onfocus="javascript:window.status='HtmlUnit (Presented 
in a New Window)'; return true" onmouseout="javascript: 
window.status=''; return true" onblur="javascript: 
window.status=''; return true" onclick="javascript:var 
win = window.open
('','htmlunit','height=500,width=750,top='+
((screen.height-(screen.height/1.618))-(500/2))+',left='+
((screen.width-750)/2)+',scrollbars,resizable');win.focus
()">HtmlUnit</a>

2b.          <a href="http://htmlunit.sourceforge.net" 
target="htmlunit" title="HtmlUnit (Presented in a New 
Window)" 
onmouseover="javascript:window.status='HtmlUnit 
(Presented in a New Window)'; return true" 
onfocus="javascript:window.status='HtmlUnit (Presented 
in a New Window)'; return true" onmouseout="javascript: 
window.status=''; return true" onblur="javascript: 
window.status=''; return true" onclick="javascript:var 
win = window.open
('about:blank','htmlunit','height=500,width=750,top='+
((screen.height-(screen.height/1.618))-(500/2))+',left='+
((screen.width-750)/2)+',scrollbars,resizable');win.focus
()">HtmlUnit</a>

Second example executes as following:
1. empty window named 'htmlunit' is opened
2. JavaScript does not return true -> url specified by 
href is called and received content is passed than to 
target, which is a previously opened 'htmlunit' window

in example 2a an exception will occur on win.focus(), 
cause there will be no ScriptObject for win (win==null)

in example 2b an exception will be thrown as 
jsFunction_open in ...Window will try to create an url 
from 'about:blank'

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=793340&group_id=47038

Re: [HtmlUnit] Help with regard to HtmlSelect

[Mike B. <mb...@Ga...>]

Rahul Joshi wrote:
> I had tried fakeselectedAttribute() but it is not working?
> Can anyone help me how should I go  about debugging/figuring out 
> the problem ..

Perhaps if you explained what you've tried and what response you've seen 
then someone could offer some insight.

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

RE: [HtmlUnit] Help with regard to HtmlSelect

[Rahul J. <rah...@sp...>]

I had tried fakeselectedAttribute() but it is not working?
Can anyone help me how should I go  about debugging/figuring out=20
the problem ..

-Rahul

-----Original Message-----
From: th...@cy... [mailto:th...@cy...]
Sent: Wednesday, August 20, 2003 5:30 AM
To: Rahul Joshi
Cc: htm...@li...
Subject: Re: [HtmlUnit] Help with regard to HtmlSelect


Rahul Joshi <rah...@sp...> schrieb am 20.08.2003, 00:09:24:
> Hi,
>=20
>    Is there anyway to add option elements  to a HtmlSelect ?
> In the original HTML , there is a java script that moves in options
> into a HtmlSelect that is initally empty. However I am running into
> problems with the java script.
> So I was thinking to do it programatically by moving in options
> into the HtmlSelect. Is there any way?


There might be. I didn't try it myself, but you might want to test using
the method 'fakeSelectedAttribute' of the class HtmlSelect. According to
the API documentation it should do exactly what you want.=20

best regards
Thomas Bartz

Re: [HtmlUnit] Help with regard to HtmlSelect

[Mike B. <mb...@Ga...>]

Rahul Joshi wrote:
>    Is there anyway to add option elements  to a HtmlSelect ?
> In the original HTML , there is a java script that moves in options
> into a HtmlSelect that is initally empty. However I am running into
> problems with the java script.
> So I was thinking to do it programatically by moving in options
> into the HtmlSelect. Is there any way?

Look at HtmlPage.createElement() and see if that does what you want.

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: [HtmlUnit] Help with regard to HtmlSelect

[<th...@cy...>]

Rahul Joshi <rah...@sp...> schrieb am 20.08.2003, 00:09:24:
> Hi,
> 
>    Is there anyway to add option elements  to a HtmlSelect ?
> In the original HTML , there is a java script that moves in options
> into a HtmlSelect that is initally empty. However I am running into
> problems with the java script.
> So I was thinking to do it programatically by moving in options
> into the HtmlSelect. Is there any way?


There might be. I didn't try it myself, but you might want to test using
the method 'fakeSelectedAttribute' of the class HtmlSelect. According to
the API documentation it should do exactly what you want. 

best regards
Thomas Bartz

[HtmlUnit] Help with regard to HtmlSelect

[Rahul J. <rah...@sp...>]

Hi,

   Is there anyway to add option elements  to a HtmlSelect ?
In the original HTML , there is a java script that moves in options
into a HtmlSelect that is initally empty. However I am running into
problems with the java script.
So I was thinking to do it programatically by moving in options
into the HtmlSelect. Is there any way?

Thanking you.
-Rahul

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Mike B. <mb...@Ga...>]

Brad Clarke wrote:
> That does seem to be the case. The admins, techs, and original posters 
> seem to be the only people who can do anything but comment on a tracker 
> item and I don't see anything in the admin settings to change this :(

That's annoying.

> Should people open a new item (maybe with "FIX: <old title>" for a 
> title) and link back to the old one?

That sounds like a reasonable compromise.  Lets try that for now.

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Brad C. <bc...@bo...>]

At 04:19 PM 8/18/2003, Mike Bowler wrote:
>Brad Clarke wrote:
>>The sf.net project doesn't seem to be setup to allow users to attach 
>>files to already existing Bugs/RFEs
>
>A number of people have uploaded patches and sample files to existing bugs 
>in the past.  Is it that you can't upload to a bug that you didn't open?

That does seem to be the case. The admins, techs, and original posters seem 
to be the only people who can do anything but comment on a tracker item and 
I don't see anything in the admin settings to change this :(

Should people open a new item (maybe with "FIX: <old title>" for a title) 
and link back to the old one?

Brad C

[HtmlUnit] [ htmlunit-Feature Requests-790848 ] Test RFE for attachment permissions

[SourceForge.net <no...@so...>]

Feature Requests item #790848, was opened at 2003-08-18 17:12
Message generated for change (Settings changed) made by yourgod
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=790848&group_id=47038

Category: None
Group: None
>Status: Deleted
Priority: 5
Submitted By: Brad Clarke (yourgod)
Assigned to: Nobody/Anonymous (nobody)
Summary: Test RFE for attachment permissions

Initial Comment:
not a real RFE, please ignore this

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=790848&group_id=47038

[HtmlUnit] [ htmlunit-Feature Requests-790848 ] Test RFE for attachment permissions

[SourceForge.net <no...@so...>]

Feature Requests item #790848, was opened at 2003-08-18 17:12
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=790848&group_id=47038

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Brad Clarke (yourgod)
Assigned to: Nobody/Anonymous (nobody)
Summary: Test RFE for attachment permissions

Initial Comment:
not a real RFE, please ignore this

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=790848&group_id=47038

Re: [HtmlUnit] CVS Checkout

[Mike B. <mb...@Ga...>]

Brad Clarke wrote:
> It's in build.xml

Ahh.  The code in the "htmlunit" module in cvs is the latest.  There are 
no branches at this time.


-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Mike B. <mb...@Ga...>]

Brad Clarke wrote:
> The sf.net project doesn't seem to be setup to allow users to attach 
> files to already existing Bugs/RFEs

A number of people have uploaded patches and sample files to existing 
bugs in the past.  Is it that you can't upload to a bug that you didn't 
open?

BTW my responses are going to be very sluggish over the next week as 
we're recovering from a massive power failure and the server that acts 
as an smtp gateway for me is going to be shut down more often than it 
will be up.

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Brad C. <bc...@bo...>]

The sf.net project doesn't seem to be setup to allow users to attach files 
to already existing Bugs/RFEs

Brad C

At 08:58 AM 8/16/2003, Mike Bowler wrote:
>James Asher wrote:
>>As I was going through this I noticed that it was
>>incomplete.  The bottom of the patch is truncated. Perhaps it was just 
>>Sourceforge? I don't know, but I
>>thought I'd mention anyways.
>>Also, because of the way the lists are set up, they
>>wrap the text.  That messes up the patch.  Is there
>>any way to do an attachment of the patch?
>
>I've been offline due to power failures - hence the slow response ;-)
>
>The best way to send patches/files is to attach them to the appropriate 
>bug report in sourceforge.  This keeps the email size down and also 
>ensures that the patches don't get lost.
>
>--
>Mike Bowler
>Principal, Gargoyle Software Inc.
>Voice: (416) 822-0973 | Email  : mb...@Ga...
>Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
>
>
>
>-------------------------------------------------------
>This SF.Net email sponsored by: Free pre-built ASP.NET sites including
>Data Reports, E-commerce, Portals, and Forums are available now.
>Download today and enter to win an XBOX or Visual Studio .NET.
>http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
>_______________________________________________
>HtmlUnit-develop mailing list
>Htm...@li...
>https://lists.sourceforge.net/lists/listinfo/htmlunit-develop

Re: [HtmlUnit] CVS Checkout

[Brad C. <bc...@bo...>]

It's in build.xml

At 11:28 AM 8/16/2003, Mike Bowler wrote:
>James Asher wrote:
>>When I do an annonomyous CVS checkout I get all my
>>files in a folder entitled HtmlUnit 1.2.2. Am I still
>>getting the 1.2.2 version or am I getting the 1.2.3
>>version in a folder with the wrong version name?
>>Just checking, cuz I'm going to be applying some
>>patches, so I just needed to know if I've got the
>>right version.
>
>I'm not sure what's happening but you shouldn't see any version number in 
>any code checked out of cvs.  How are you doing the checkout?
>
>
>--
>Mike Bowler
>Principal, Gargoyle Software Inc.
>Voice: (416) 822-0973 | Email  : mb...@Ga...
>Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
>
>
>
>-------------------------------------------------------
>This SF.Net email sponsored by: Free pre-built ASP.NET sites including
>Data Reports, E-commerce, Portals, and Forums are available now.
>Download today and enter to win an XBOX or Visual Studio .NET.
>http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
>_______________________________________________
>HtmlUnit-develop mailing list
>Htm...@li...
>https://lists.sourceforge.net/lists/listinfo/htmlunit-develop

Re: [HtmlUnit] CVS Checkout

[James A. <the...@ya...>]

cvs -d:pserver:ano...@cv...:/cvsroot/htmlunit logincvs -z3 -d:pserver:ano...@cv...:/cvsroot/htmlunit co htmlunitant initialize cleancompile build--- Mike Bowler  wrote:> James Asher wrote:> > When I do an annonomyous CVS checkout I get all my> > files in a folder entitled HtmlUnit 1.2.2. Am I> still> > getting the 1.2.2 version or am I getting the> 1.2.3> > version in a folder with the wrong version name?> > > > Just checking, cuz I'm going to be applying some> > patches, so I just needed to know if I've got the> > right version.> > I'm not sure what's happening but you shouldn't see> any version number > in any code checked out of cvs.  How are you doing> the checkout?> > > -- > Mike Bowler> Principal, Gargoyle Software Inc.> Voice: (416) 822-0973 | Email  :> mb...@Ga...> Fax  : (416) 822-0975 | Website:> http://www.GargoyleSoftware.com> > > > -------------------------------------------------------> This SF.Net
 email sponsored by: Free pre-built> ASP.NET sites including> Data Reports, E-commerce, Portals, and Forums are> available now.> Download today and enter to win an XBOX or Visual> Studio .NET.> http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01> _______________________________________________> HtmlUnit-develop mailing list> Htm...@li...> https://lists.sourceforge.net/lists/listinfo/htmlunit-develop

---------------------------------
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Mike B. <mb...@Ga...>]

James Asher wrote:
> As I was going through this I noticed that it was
> incomplete.  The bottom of the patch is truncated. 
> Perhaps it was just Sourceforge? I don't know, but I
> thought I'd mention anyways.
> 
> Also, because of the way the lists are set up, they
> wrap the text.  That messes up the patch.  Is there
> any way to do an attachment of the patch?

I've been offline due to power failures - hence the slow response ;-)

The best way to send patches/files is to attach them to the appropriate 
bug report in sourceforge.  This keeps the email size down and also 
ensures that the patches don't get lost.

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: [HtmlUnit] CVS Checkout

[Mike B. <mb...@Ga...>]

James Asher wrote:
> When I do an annonomyous CVS checkout I get all my
> files in a folder entitled HtmlUnit 1.2.2. Am I still
> getting the 1.2.2 version or am I getting the 1.2.3
> version in a folder with the wrong version name?
> 
> Just checking, cuz I'm going to be applying some
> patches, so I just needed to know if I've got the
> right version.

I'm not sure what's happening but you shouldn't see any version number 
in any code checked out of cvs.  How are you doing the checkout?


-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[James A. <the...@ya...>]

This is the last 6 lines or so of that .txt file,
seems incomplete...

---
     public WebResponse getResponse(
             final URL url,
+            final FormEncodingType encType,
             final SubmitMethod method,
             final List parameters,
             final Map requestParameters ) {
---

I was up late lastnight, maybe my eyes are just
playing tricks on me...



--- Brad Clarke <bc...@bo...> wrote:
> Mailing lists tend to eat attachments so I avoided
> doing that. You can 
> download it here:
> 
> http://www.bradclarke.com/htmlunit/patch.txt
> 
> Brad C
> 
> At 02:42 PM 8/14/2003, James Asher wrote:
> >As I was going through this I noticed that it was
> >incomplete.  The bottom of the patch is truncated.
> >Perhaps it was just Sourceforge? I don't know, but
> I
> >thought I'd mention anyways.
> >
> >Also, because of the way the lists are set up, they
> >wrap the text.  That messes up the patch.  Is there
> >any way to do an attachment of the patch?
> >
> >Thanks.
> >
> >
> >__________________________________
> >Do you Yahoo!?
> >Yahoo! SiteBuilder - Free, easy-to-use web site
> design software
> >http://sitebuilder.yahoo.com
> 


__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

[HtmlUnit] CVS Checkout

[James A. <the...@ya...>]

When I do an annonomyous CVS checkout I get all my
files in a folder entitled HtmlUnit 1.2.2. Am I still
getting the 1.2.2 version or am I getting the 1.2.3
version in a folder with the wrong version name?

Just checking, cuz I'm going to be applying some
patches, so I just needed to know if I've got the
right version.

thanks.

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[James A. <the...@ya...>]

As I was going through this I noticed that it was
incomplete.  The bottom of the patch is truncated. 
Perhaps it was just Sourceforge? I don't know, but I
thought I'd mention anyways.

Also, because of the way the lists are set up, they
wrap the text.  That messes up the patch.  Is there
any way to do an attachment of the patch?

Thanks.


__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Brad C. <bc...@bo...>]

Mailing lists tend to eat attachments so I avoided doing that. You can 
download it here:

http://www.bradclarke.com/htmlunit/patch.txt

Brad C

At 02:42 PM 8/14/2003, James Asher wrote:
>As I was going through this I noticed that it was
>incomplete.  The bottom of the patch is truncated.
>Perhaps it was just Sourceforge? I don't know, but I
>thought I'd mention anyways.
>
>Also, because of the way the lists are set up, they
>wrap the text.  That messes up the patch.  Is there
>any way to do an attachment of the patch?
>
>Thanks.
>
>
>__________________________________
>Do you Yahoo!?
>Yahoo! SiteBuilder - Free, easy-to-use web site design software
>http://sitebuilder.yahoo.com

Re: [HtmlUnit] rough patch for HtmlFileInput support

[Brad C. <bc...@bo...>]

Support for putting your file name in the box was already there, it just 
didn't send the file to the server when you submit()ed the containing 
HtmlForm (I think it just sent the filename as a string).

You'll need a recent CVS checkout to apply a patch. Most CVS 
implementations come with a "patch" command (try "patch --help" or "man 
patch"), or if you're like me and use Eclipse there's an "Apply Patch..." 
option on the Team menu. I'm sure most other IDEs have something similar.

A good description of what a patch is: 
http://cocoon.apache.org/2.0/howto/howto-patch.html

Brad C


At 12:08 PM 8/14/2003, James Asher wrote:
>I, too, have just come across a need for this.  I
>already know the path to the file, I just need a way
>of accessing the input field for the path, I'm
>assuming I'll be able to do that with this patch?
>Also, I don't know how to use this patch, do I need to
>do a CVS check out from the HtmlUnit CVS?
>
>Thanks,
>  James
>
>
>--- Brad Clarke <bc...@bo...> wrote:
> >
> > RFE:
> >
>http://sourceforge.net/tracker/index.php?func=detail&aid=625328&group_id=47038&atid=448269
> >
> > I have managed to get an HtmlFileInput to upload a
> > file to the server with
> > this patch. It's likely in no condition to go into
> > just CVS yet, I'm just
> > looking for comments and suggestions for
> > improvement.
> >
> > My personal issues with it are:
> > - I really have no clue what I'm doing :)
> > - It requires the unreleased commons-httpclient 2.0
> > (this is probably
> > unavoidable)
> > - I've really done nothing to see how this mimics
> > real world web browsers,
> > I just know it worked for me
> > - FormEncodingType seems sort of like a waste to me,
> > but it seemed "right"
> > to model it after SubmitMethod
> > - FormEncodingType naming conventions were basically
> > random. Someone with
> > more experience with this could probably name things
> > better.
> > - I had to add a lot of new API to preserve
> > compatibility because so many
> > things are public. Maybe some of this could be
> > removed??
> > - KeyDataPair seems like a really bad idea to me,
> > but it helped to not have
> > to touch much of the surrounding code
> > - I really have no idea how to "properly" unit test
> > this, so there are no
> > new tests (though all the old ones still pass)
> > - The new stuff is completely unimplemented in
> > FakeWebConnection
> > - There were other little things I noticed in the
> > RFCs that I just ignored
> > because I don't know exactly how commons-httpclient
> > fits in
> > - The checkstyle task in the ant build.xml won't
> > work so I doubt this meets
> > the standards (though I did make an effort)
> > - The copyright is not on the new files, but only to
> > make the diff smaller.
> > Just act like it's there :)
> > - If the encoding type on the form is not correct it
> > defaults to the old
> > broken behavior. From the RFCs it sounds like there
> > should be a MIME
> > encoding of the file and it added to the POST as
> > text. I could live with
> > this being ignored but maybe others can't?
> >
> > Brad C
> >
> >
> > Index:
> >
>src/java/com/gargoylesoftware/htmlunit/FormEncodingType.java
> >
>===================================================================
> > RCS file:
> >
>src/java/com/gargoylesoftware/htmlunit/FormEncodingType.java
> > diff -N
> >
>src/java/com/gargoylesoftware/htmlunit/FormEncodingType.java
> > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > +++
> >
>src/java/com/gargoylesoftware/htmlunit/FormEncodingType.java
> > 12 Aug
> > 2003 22:56:55 -0000
> > @@ -0,0 +1,73 @@
> > +package com.gargoylesoftware.htmlunit;
> > +
> > +import
> > org.apache.commons.httpclient.methods.PostMethod;
> > +import
> >
>org.apache.commons.httpclient.methods.MultipartPostMethod;
> > +
> > +/**
> > + *  A collection of constants that represent the
> > various ways a form can be
> > + *  encoded when submitted
> > + *
> > + * @version  $Revision: 1.1 $
> > + */
> > +public class FormEncodingType {
> > +
> > +     /**
> > +     *  URL_ENCODED
> > +     */
> > +     public static final FormEncodingType URL_ENCODED =
> > +             new
> >
>FormEncodingType(PostMethod.FORM_URL_ENCODED_CONTENT_TYPE);
> > +     /**
> > +     *  MULTIPART
> > +     */
> > +     public static final FormEncodingType MULTIPART =
> > +             new
> >
>FormEncodingType(MultipartPostMethod.MULTIPART_FORM_CONTENT_TYPE);
> > +
> > +     private final String name_;
> > +
> > +     private FormEncodingType(final String name) {
> > +             name_ = name;
> > +     }
> > +
> > +     /**
> > +     *  Return the name of this EncodingType
> > +     *
> > +     * @return  See above
> > +     */
> > +     public String getName() {
> > +             return name_;
> > +     }
> > +
> > +     /**
> > +     *  Return the constant that matches the given
> > name
> > +     *
> > +     * @param  name The name to search by
> > +     * @return  See above
> > +     */
> > +     public static FormEncodingType getInstance(final
> > String name) {
> > +             final String lowerCaseName = name.toLowerCase();
> > +             final FormEncodingType allInstances[] = new
> > FormEncodingType[] {
> > URL_ENCODED, MULTIPART };
> > +
> > +             int i;
> > +             for (i = 0; i < allInstances.length; i++) {
> > +                     if
> > (allInstances[i].getName().equals(lowerCaseName)) {
> > +                             return allInstances[i];
> > +                     }
> > +             }
> > +
> > +             // Special case: empty string defaults to url
> > encoded
> > +             if (name.equals("")) {
> > +                     return URL_ENCODED;
> > +             }
> > +
> > +             throw new IllegalArgumentException("No encoding
> > type found for [" + name
> > + "]");
> > +     }
> > +
> > +     /**
> > +     *  Return a string representation of this object
> > +     *
> > +     * @return  See above
> > +     */
> > +     public String toString() {
> > +             return "EncodingType[name=" + getName() + "]";
> > +     }
> > +}
> > Index:
> >
>src/java/com/gargoylesoftware/htmlunit/HttpWebConnection.java
> >
>===================================================================
> > RCS file:
> >
>/cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/HttpWebConnection.java,v
> > retrieving revision 1.13
> > diff -u -r1.13 HttpWebConnection.java
> > ---
> >
>src/java/com/gargoylesoftware/htmlunit/HttpWebConnection.java
> > 19 Jul
> > 2003 17:17:30 -0000   1.13
> > +++
> >
>src/java/com/gargoylesoftware/htmlunit/HttpWebConnection.java
> > 12 Aug
> > 2003 22:56:55 -0000
> > @@ -37,6 +37,7 @@
> >    */
> >   package com.gargoylesoftware.htmlunit;
> >
> > +import java.io.File;
> >   import java.io.ByteArrayInputStream;
> >   import java.io.IOException;
> >   import java.io.InputStream;
> > @@ -58,6 +59,7 @@
> >   import org.apache.commons.httpclient.URI;
> >   import org.apache.commons.httpclient.URIException;
> >   import
> > org.apache.commons.httpclient.cookie.CookiePolicy;
> > +import
> >
>org.apache.commons.httpclient.methods.MultipartPostMethod;
> >   import
> > org.apache.commons.httpclient.methods.GetMethod;
> >   import
> > org.apache.commons.httpclient.methods.PostMethod;
> >   import org.apache.commons.logging.Log;
> > @@ -98,12 +100,32 @@
> >           super(webClient, proxyHost, proxyPort);
> >       }
> >
> > -
> > +     /**
> > +     *  Submit a request and retrieve a response
> > +     *
> >
>=== message truncated ===
>
>
>__________________________________
>Do you Yahoo!?
>Yahoo! SiteBuilder - Free, easy-to-use web site design software
>http://sitebuilder.yahoo.com
>
>
>-------------------------------------------------------
>This SF.Net email sponsored by: Free pre-built ASP.NET sites including
>Data Reports, E-commerce, Portals, and Forums are available now.
>Download today and enter to win an XBOX or Visual Studio .NET.
>http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
>_______________________________________________
>HtmlUnit-develop mailing list
>Htm...@li...
>https://lists.sourceforge.net/lists/listinfo/htmlunit-develop