htmlunit-develop — General discussion of the development of HtmlUnit

[HtmlUnit] [ htmlunit-Bugs-757225 ] Javascript: Support changing the TYPE,ID and NAME attributes

[SourceForge.net <no...@so...>]

Bugs item #757225, was opened at 2003-06-19 09:33
Message generated for change (Comment added) made by barnabycourt
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=757225&group_id=47038

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Barnaby Court (barnabycourt)
Assigned to: Nobody/Anonymous (nobody)
Summary: Javascript: Support changing the TYPE,ID and NAME attributes

Initial Comment:
Add support for changing the type of INPUT elments and

the ID and NAME of all html elements through javascript.  



Attached is a test case for the desired functionality.

----------------------------------------------------------------------

>Comment By: Barnaby Court (barnabycourt)
Date: 2003-10-02 16:36

Message:
Logged In: YES 
user_id=591975

With help from the rhino development team I have found a 

solution for the issue.  It requires SimpleScriptable to override 

the has(String, Scriptable) method.  This is so that has 

returns true for all the predefined html attribues.  One 

possible implementation of this is

    public boolean has(String name, Scriptable start) {

        boolean parentValue = super.has(name, start);

        if (parentValue == true) {

            return parentValue;

        } else {

            if (name == null ) {

                return false;

            }

            Map propertyMap = getPropertyMap();

            if (propertyMap != null && propertyMap.containsKey

(name)) {

                return true;

            } else {

                return false;

            }

        }

    }



This is causing a failure in 

HtmlPageTest.testOnLoadHandler_ScriptName(...) and 

WindowTest.testSetLocation(...).  I will continue to look into 

why this is causing problems for those 2 tests.  If anyone has 

any ideas I would welcome any suggetions.  

----------------------------------------------------------------------

Comment By: Barnaby Court (barnabycourt)
Date: 2003-10-02 12:40

Message:
Logged In: YES 
user_id=591975

I have a patch that addresses the type and name attributes.  

For some reason I am still having a problem getting the id 

attribute to work using the "with (element) {...}" javascript 

call.  The reason it isn't working as that the put method is not 

being called on SimpleScriptable.  I have opened a defect 

(#221025) for this in the Rhino Bugzilla database.  



There may be something in the configuration I am missing but 

I can set the id using "element.id = 'foo';" and it works fine so 

I am assuming this is a Rhino issue.  I will continue to track 

the issue with the Rhino development folks and report back 

here once the issue has been addressed there.  

----------------------------------------------------------------------

Comment By: Barnaby Court (barnabycourt)
Date: 2003-07-18 10:02

Message:
Logged In: YES 
user_id=591975

I have had some degree of success with this but I have found

certain cases where use of with (element) {} expression in

javascript causes problems.  There are 2 problems with it

that I have encountered.  The first is with the

SimpleScriptable.put(...)  method.  put(...) is being called

on the parent scriptable object.  I replaced 

         if( htmlElement_ == null ) {

             super.put(name, start, newValue);

             return;

         }

with 

         if( htmlElement_ == null ) {

             super.put(name, start, newValue);

             if (start != null && start != this) {

                 start.put(name, start, newValue);

             }

             return;

         }

and that appeared to fix half the problems.  



The 2nd is with the SimplScriptable.setName(...) method. 

The "bound" variable is null and the variable found was

incorrect.  I am still working on finding a solution for

this problem.  



The test case I used for this is the following:

    public void testId() throws Exception {

        final String content

                 = "<html><head><title>foo</title><script>"

                 + "var testElement1 =

document.createElement( 'INPUT' );"

                 + "testElement1.id = 'testID1';"

                 + "alert(testElement1.id);"

                 + "var testElement2 =

document.createElement( 'INPUT' );"

                 + "with (testElement2) {id = 'testID2';}"

                 + "alert(testElement2.id);"

                 + "</script></head><body>"

                 + "<p>hello world</p>"

                 + "</body></html>";

        final List collectedAlerts = new ArrayList();

        final HtmlPage page = loadPage(content,

collectedAlerts);

        assertEquals("foo", page.getTitleText());



        final List expectedAlerts = Arrays.asList( new String[]{

            "testID1","testID2"

        });

        assertEquals( expectedAlerts, collectedAlerts );

    }



----------------------------------------------------------------------

Comment By: Mike Bowler (mbowler)
Date: 2003-07-18 09:33

Message:
Logged In: YES 
user_id=46756

I seem to recall discussing this one with you via private

email but I don't have those emails with me (different

machine) and my memory is failing.  Can you post a summary

of where this bug stands right now?  As I recall you were

investigating why some elements weren't being initialized

correctly.

----------------------------------------------------------------------

Comment By: Barnaby Court (barnabycourt)
Date: 2003-06-20 09:21

Message:
Logged In: YES 
user_id=591975

Tha attached patch adds the methods needed to support this

functionality.  For some reason not all the methods are

getting called.  Perhaps someone could take a look at the

patch and see why.  

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=757225&group_id=47038

[HtmlUnit] [ htmlunit-Bugs-757225 ] Javascript: Support changing the TYPE,ID and NAME attributes

[SourceForge.net <no...@so...>]

Bugs item #757225, was opened at 2003-06-19 09:33
Message generated for change (Comment added) made by barnabycourt
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=757225&group_id=47038

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Barnaby Court (barnabycourt)
Assigned to: Nobody/Anonymous (nobody)
Summary: Javascript: Support changing the TYPE,ID and NAME attributes

Initial Comment:
Add support for changing the type of INPUT elments and

the ID and NAME of all html elements through javascript.  



Attached is a test case for the desired functionality.

----------------------------------------------------------------------

>Comment By: Barnaby Court (barnabycourt)
Date: 2003-10-02 12:40

Message:
Logged In: YES 
user_id=591975

I have a patch that addresses the type and name attributes.  

For some reason I am still having a problem getting the id 

attribute to work using the "with (element) {...}" javascript 

call.  The reason it isn't working as that the put method is not 

being called on SimpleScriptable.  I have opened a defect 

(#221025) for this in the Rhino Bugzilla database.  



There may be something in the configuration I am missing but 

I can set the id using "element.id = 'foo';" and it works fine so 

I am assuming this is a Rhino issue.  I will continue to track 

the issue with the Rhino development folks and report back 

here once the issue has been addressed there.  

----------------------------------------------------------------------

Comment By: Barnaby Court (barnabycourt)
Date: 2003-07-18 10:02

Message:
Logged In: YES 
user_id=591975

I have had some degree of success with this but I have found

certain cases where use of with (element) {} expression in

javascript causes problems.  There are 2 problems with it

that I have encountered.  The first is with the

SimpleScriptable.put(...)  method.  put(...) is being called

on the parent scriptable object.  I replaced 

         if( htmlElement_ == null ) {

             super.put(name, start, newValue);

             return;

         }

with 

         if( htmlElement_ == null ) {

             super.put(name, start, newValue);

             if (start != null && start != this) {

                 start.put(name, start, newValue);

             }

             return;

         }

and that appeared to fix half the problems.  



The 2nd is with the SimplScriptable.setName(...) method. 

The "bound" variable is null and the variable found was

incorrect.  I am still working on finding a solution for

this problem.  



The test case I used for this is the following:

    public void testId() throws Exception {

        final String content

                 = "<html><head><title>foo</title><script>"

                 + "var testElement1 =

document.createElement( 'INPUT' );"

                 + "testElement1.id = 'testID1';"

                 + "alert(testElement1.id);"

                 + "var testElement2 =

document.createElement( 'INPUT' );"

                 + "with (testElement2) {id = 'testID2';}"

                 + "alert(testElement2.id);"

                 + "</script></head><body>"

                 + "<p>hello world</p>"

                 + "</body></html>";

        final List collectedAlerts = new ArrayList();

        final HtmlPage page = loadPage(content,

collectedAlerts);

        assertEquals("foo", page.getTitleText());



        final List expectedAlerts = Arrays.asList( new String[]{

            "testID1","testID2"

        });

        assertEquals( expectedAlerts, collectedAlerts );

    }



----------------------------------------------------------------------

Comment By: Mike Bowler (mbowler)
Date: 2003-07-18 09:33

Message:
Logged In: YES 
user_id=46756

I seem to recall discussing this one with you via private

email but I don't have those emails with me (different

machine) and my memory is failing.  Can you post a summary

of where this bug stands right now?  As I recall you were

investigating why some elements weren't being initialized

correctly.

----------------------------------------------------------------------

Comment By: Barnaby Court (barnabycourt)
Date: 2003-06-20 09:21

Message:
Logged In: YES 
user_id=591975

Tha attached patch adds the methods needed to support this

functionality.  For some reason not all the methods are

getting called.  Perhaps someone could take a look at the

patch and see why.  

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=757225&group_id=47038

Re: [HtmlUnit] Re: Re: Re: FileInput does not work (from CVS)

[Brad C. <bc...@bo...>]

It works fine against my web server. If you can give me some more 
information about the problem I might be able to fix it.

Brad C

At 04:00 AM 10/2/2003, ji...@le... wrote:
>  jimmy@le... wrote:
>  > Well the bug is quite simply that the file *data* of an HtmlFileInput
>  > field is not posted at all, instead the *filename* is posted as a normal
>  > key/value parameter.
>
>  Looking at the change log, it appears that the FileInput support added
>  by Brad Clarke hasn't made it into an official release yet.  Are you
>  using the code from CVS or one of the releases? If you're not using CVS,
>  you might want to try that.
>
>  http://htmlunit.sourceforge.net/changes-report.html
>
>  --
>  Mike Bowler
>
>
>Yes I am using the CVS version and the code change I suggested above is
>against the CVS...
>
>The FileInput does not work at all, so if you or anyone tests it you will
>see that it never sends any file data.
>
>/Jimmy
>
>
>
>
>-------------------------------------------------------
>This sf.net email is sponsored by:ThinkGeek
>Welcome to geek heaven.
>http://thinkgeek.com/sf
>_______________________________________________
>HtmlUnit-develop mailing list
>Htm...@li...
>https://lists.sourceforge.net/lists/listinfo/htmlunit-develop

[HtmlUnit] Re: Re: Re: FileInput does not work (from CVS)

[<ji...@le...>]

 jimmy@le... wrote:
 > Well the bug is quite simply that the file *data* of an HtmlFileInput
 > field is not posted at all, instead the *filename* is posted as a normal
 > key/value parameter.

 Looking at the change log, it appears that the FileInput support added
 by Brad Clarke hasn't made it into an official release yet.  Are you
 using the code from CVS or one of the releases? If you're not using CVS,
 you might want to try that.

 http://htmlunit.sourceforge.net/changes-report.html

 --
 Mike Bowler


Yes I am using the CVS version and the code change I suggested above is
against the CVS...

The FileInput does not work at all, so if you or anyone tests it you will
see that it never sends any file data.

/Jimmy

[HtmlUnit] [ htmlunit-Patches-816384 ] use strict mode to merge multiple cookies into one

[SourceForge.net <no...@so...>]

Patches item #816384, was opened at 2003-10-02 06:37
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448268&aid=816384&group_id=47038

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Jun Chen (chen_jun)
Assigned to: Nobody/Anonymous (nobody)
Summary: use strict mode to merge multiple cookies into one

Initial Comment:
Actually I have pointed out this problem in my previous 

post. Maybe I'm not good at explaining so it's 

misunderstood. But I think the problem should be noticed 

and it will make htmlunit work successfully in more 

cases. So I restate the problem here.



As I know, htmlunit uses httpclient to handle http 

protocol related stuffs, including cookie handling. But we 

need to notice HttpClient, which is used by 

HttpWebConnection.getResponse(...), has a method 

called setStrictMode(bool).  I cite the comments from its 

source code.

    /**

     * Defines how strictly the method follows the HTTP 

protocol specification  

     * (see RFC 2616 and other relevant RFCs). 

     * 

     * In the strict mode the method precisely

     * implements the requirements of the specification, 

whereas in non-strict mode 

     * it attempts to mimic the exact behaviour of 

commonly used HTTP agents, 

     * which many HTTP servers expect.

...



As the above comment says, It seems that we should 

use non-strict mode as default. Actually, httpclient just 

use non-strict mode as default. But it causes some 

nontrivial failure since this non-strict mode will NOT use 

single cookie header. Speaking more detailly, when 

httpclient sends a request to the server in a successive 

web interaction, it will NOT merge multiple cookie 

headers it got in the previous response. This will cause 

problems for some web servers which only allow ONE 

cookie header because of (I guess) the performance 

consideration!  The login server of yahoo.com is an 

example.



So I strongly suggest to consider strict/non-strict mode. 

In the patch attacted, I use HttpClient.setStrictMode

(true); It will handle single cookie header problem, but it 

may cause other  problems as the above comment says.



Fortunately, in the latest cvs code of httpclient, 

setStrictMode() is deprecated, and we can use 

HttpClientParams.setParameter

(SINGLE_COOKIE_HEADER,new Boolean(true)) to just 

enable single cookie header without any side effects.



Thanks.

Jun Chen



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448268&aid=816384&group_id=47038

Re: [HtmlUnit] Re: Re: FileInput does not work (from CVS)

[Mike B. <mb...@Ga...>]

ji...@le... wrote:
> Well the bug is quite simply that the file *data* of an HtmlFileInput
> field is not posted at all, instead the *filename* is posted as a normal
> key/value parameter.

Looking at the change log, it appears that the FileInput support added 
by Brad Clarke hasn't made it into an official release yet.  Are you 
using the code from CVS or one of the releases? If you're not using CVS, 
you might want to try that.

http://htmlunit.sourceforge.net/changes-report.html

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

[HtmlUnit] Re: Re: FileInput does not work (from CVS)

[<ji...@le...>]

>> We needed to use the file upload stuff inside HtmlUnit and we saw the
>> patch sent in to the mailing list but we could not get it to work.
>>
>> We found that there was a bug inside HtmlFileUpload. To get it working
>> you have to add (override) the following method:
>>
>> public KeyValuePair[] getSubmitKeyValuePairs() {
>>     return new KeyDataPair[]{new KeyDataPair(getNameAttribute(),
>>                              new File(getValueAttribute()))};
>> }
>>
>> Please note that it uses "KeyDataPair" instead of KeyValuePair. Could
>> someone that have commit rights please add this in the cvs code?

> I don't understand what the bug is.  Can you provide a test case that
> shows this failing?

Well the bug is quite simply that the file *data* of an HtmlFileInput
field is not posted at all, instead the *filename* is posted as a normal
key/value parameter.

The test case is to try to post any file via HtmlFileInput and the body of
the file will not be sent.

Another thing you can do (if your using Idea or Eclipse) is to search for
usages of the class called "KeyDataPair" it will show you that it is
checked against with an "instance of" in HttpWebConnection (line 282), but
it is is never instantiated.


(I'm not really familiar with your unit tests and the FakeWebConnection
class but you could probably try a submit with a file input using it and
verify that the body of the file was sent...)

Hope this will help.

/Regards, Jimmy

[HtmlUnit] [ htmlunit-Feature Requests-814741 ] Add support for window.focus()

[SourceForge.net <no...@so...>]

Feature Requests item #814741, was opened at 2003-09-29 17:19
Message generated for change (Comment added) made by mbowler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814741&group_id=47038

Category: None
Group: None
>Status: Closed
Priority: 5
Submitted By: Brad Clarke (yourgod)
>Assigned to: Mike Bowler (mbowler)
Summary: Add support for window.focus()

Initial Comment:
The attached patch should do it, but it seemed way too

simple to me...gotta be missing something :)





----------------------------------------------------------------------

>Comment By: Mike Bowler (mbowler)
Date: 2003-09-30 08:44

Message:
Logged In: YES 
user_id=46756

Patch applied - thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814741&group_id=47038

[HtmlUnit] CVS Commit: htmlunit: Added support for Window.focus().

[<no...@us...>]

Log Message:
-----------
Added support for Window.focus().  Patch supplied by Brad Clarke

Modified Files:
--------------
    /cvsroot/htmlunit/htmlunit/src/xdocs:
        changes.xml
    /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/javascript/host:
        Window.java
    /cvsroot/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host:
        WindowTest.java

Revision Data
-------------
Index: changes.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/changes.xml,v
retrieving revision 1.136
retrieving revision 1.137
diff -u -d -r1.136 -r1.137
--- changes.xml	29 Sep 2003 12:08:31 -0000	1.136
+++ changes.xml	30 Sep 2003 12:44:03 -0000	1.137
@@ -52,6 +52,9 @@
                 Fixed bug where radio button and checkbox logic was case sensitive.
                 Patch supplied by Brad Clarke
             </action>
+            <action type="update" dev="mbowler" id="814741" due-to="Brad Clarke">
+                Added support for Window.focus().  Patch supplied by Brad Clarke
+            </action>
         </release>
 
         <release version="1.2.3" date="July 31, 2003">
Index: Window.java
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/javascript/host/Window.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -r1.25 -r1.26
--- Window.java	17 Sep 2003 18:24:39 -0000	1.25
+++ Window.java	30 Sep 2003 12:44:03 -0000	1.26
@@ -434,7 +434,7 @@
      * Set the focus to this element.
      */
     public void jsFunction_focus() {
-        getLog().debug( "Window.focus() not implemented" );
+        webWindow_.getWebClient().setCurrentWindow(webWindow_);
     }
 
 
Index: WindowTest.java
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/WindowTest.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- WindowTest.java	17 Sep 2003 18:24:39 -0000	1.8
+++ WindowTest.java	30 Sep 2003 12:44:03 -0000	1.9
@@ -156,7 +156,7 @@
             = (WebWindow)((WebWindowEvent)eventCatcher.getEventAt(0)).getSource();
         final WebWindow secondWebWindow
             = (WebWindow)((WebWindowEvent)eventCatcher.getEventAt(2)).getSource();
-        assertSame( webClient.getCurrentWindow(), firstWebWindow);
+        assertSame( webClient.getCurrentWindow(), secondWebWindow);
         assertEquals( "MyNewWindow", secondWebWindow.getName() );
 
         assertEquals( "First", ((HtmlPage)firstWebWindow.getEnclosedPage()).getTitleText());

[HtmlUnit] CVS Commit: htmlunit: Added HtmlUnit.jar to ignore file

[<no...@us...>]

Log Message:
-----------
Added HtmlUnit.jar to ignore file

Modified Files:
--------------
    /cvsroot/htmlunit/htmlunit/build:
        .cvsignore

Revision Data
-------------
Index: .cvsignore
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/build/.cvsignore,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- .cvsignore	2 Sep 2002 22:11:48 -0000	1.1
+++ .cvsignore	30 Sep 2003 12:40:30 -0000	1.2
@@ -1 +1,2 @@
 HtmlUnit-*
+HtmlUnit.jar
\ No newline at end of file

[HtmlUnit] [ htmlunit-Feature Requests-814741 ] Add support for window.focus()

[SourceForge.net <no...@so...>]

Feature Requests item #814741, was opened at 2003-09-29 16:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814741&group_id=47038

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Brad Clarke (yourgod)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add support for window.focus()

Initial Comment:
The attached patch should do it, but it seemed way too

simple to me...gotta be missing something :)





----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814741&group_id=47038

[HtmlUnit] [ htmlunit-Feature Requests-814413 ] FORM - Add support for enctype attribute

[SourceForge.net <no...@so...>]

Feature Requests item #814413, was opened at 2003-09-29 07:03
Message generated for change (Comment added) made by yourgod
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814413&group_id=47038

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Fourel (nes_olivier)
Assigned to: Nobody/Anonymous (nobody)
Summary: FORM - Add support for enctype attribute

Initial Comment:
 > I have a test running on an html page containing a 

form declared as

 > following :

 >

 > <FORM NAME="form" METHOD="POST" 

enctype="multipart/form-data">

 > .....

 > </FORM>



<snip>



 > IS HtmlUnit able to manage such enctype 

("multipart/form-data") ?



No, it currently ignores the encoding attribute.  Please 

open a feature 

request for this.



----------------------------------------------------------------------

Comment By: Brad Clarke (yourgod)
Date: 2003-09-29 09:37

Message:
Logged In: YES 
user_id=257129

Part of adding support for HtmlFileInput was looking at this 

encoding attribute. So long as the form is a POST and not a 

GET it -should- already respect this particular encoding type 

in the CVS code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814413&group_id=47038

[HtmlUnit] CVS Commit: htmlunit: Added jar target back into build.xml.

[<no...@us...>]

Log Message:
-----------
Added jar target back into build.xml.  Patch supplied by Brad Clarke

Modified Files:
--------------
    /cvsroot/htmlunit/htmlunit:
        build.xml

Revision Data
-------------
Index: build.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/build.xml,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -d -r1.44 -r1.45
--- build.xml	19 Sep 2003 12:10:21 -0000	1.44
+++ build.xml	29 Sep 2003 12:10:51 -0000	1.45
@@ -75,6 +75,17 @@
         <classpath refid="test.class.path"/>
     </javac>
 </target>
+<target name="jar" description="Make a jar of HtmlUnit" depends="compile">
+    <jar
+        jarfile="build/HtmlUnit.jar"
+        basedir="target/classes"
+        excludes="**/test/*,**/*.java,build.xml,lib,**/package.html"
+    />
+    <jar
+        jarfile="build/HtmlUnit-src.jar"
+        basedir="src/java"
+        includes="**/*.java"/>    
+</target>
 
 <target name="cleancompile" description="clean compile">
      <delete quiet="true">

[HtmlUnit] [ htmlunit-Feature Requests-812757 ] Add jar-ing back to the ant build.xml

[SourceForge.net <no...@so...>]

Feature Requests item #812757, was opened at 2003-09-25 18:02
Message generated for change (Comment added) made by mbowler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=812757&group_id=47038

Category: None
Group: None
>Status: Closed
Priority: 5
Submitted By: Brad Clarke (yourgod)
>Assigned to: Mike Bowler (mbowler)
Summary: Add jar-ing back to the ant build.xml

Initial Comment:
Patch attached for those of us who are maven-less

----------------------------------------------------------------------

>Comment By: Mike Bowler (mbowler)
Date: 2003-09-29 08:10

Message:
Logged In: YES 
user_id=46756

Patch applied - thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=812757&group_id=47038

[HtmlUnit] [ htmlunit-Bugs-812749 ] javascript radio and checkbox inputs are case sensitive

[SourceForge.net <no...@so...>]

Bugs item #812749, was opened at 2003-09-25 17:45
Message generated for change (Comment added) made by mbowler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=812749&group_id=47038

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Brad Clarke (yourgod)
>Assigned to: Mike Bowler (mbowler)
Summary: javascript radio and checkbox inputs are case sensitive

Initial Comment:
If your input was type="RADIO" instead of type="radio"

then it wouldn't work right from javascript. Same for

type="checCKbox". The attached patch changes the

existing tests to check for this and fixes the issue.





----------------------------------------------------------------------

>Comment By: Mike Bowler (mbowler)
Date: 2003-09-29 08:08

Message:
Logged In: YES 
user_id=46756

Patch applied - thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=812749&group_id=47038

[HtmlUnit] CVS Commit: htmlunit: Fixed bug where radio button and checkbox logic

[<no...@us...>]

Log Message:
-----------
 Fixed bug where radio button and checkbox logic was case sensitive.  Patch supplied by Brad Clarke

Modified Files:
--------------
    /cvsroot/htmlunit/htmlunit/src/xdocs:
        changes.xml
    /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/javascript/host:
        Input.java
    /cvsroot/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host:
        InputTest.java
    /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/html:
        HtmlInput.java

Revision Data
-------------
Index: Input.java
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/javascript/host/Input.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -d -r1.11 -r1.12
--- Input.java	17 Sep 2003 18:24:39 -0000	1.11
+++ Input.java	29 Sep 2003 12:08:31 -0000	1.12
@@ -125,7 +125,7 @@
      *      set
      */
     public void jsSet_checked( final boolean checked ) {
-        String type = getHtmlElementOrDie().getAttributeValue("type");
+        String type = getHtmlElementOrDie().getAttributeValue("type").toLowerCase();
         if (type.equals("checkbox") || type.equals("radio")){
             ((HtmlInput)getHtmlElementOrDie()).setChecked(checked);
         }
@@ -145,7 +145,7 @@
      *@return    The checked property.
      */
     public boolean jsGet_checked() {
-        String type = getHtmlElementOrDie().getAttributeValue("type");
+        String type = getHtmlElementOrDie().getAttributeValue("type").toLowerCase();
         if (type.equals("checkbox") || type.equals("radio")){
             return ((HtmlInput)getHtmlElementOrDie()).isChecked();
         }
Index: InputTest.java
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host/InputTest.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- InputTest.java	3 Sep 2003 15:55:23 -0000	1.3
+++ InputTest.java	29 Sep 2003 12:08:31 -0000	1.4
@@ -178,7 +178,7 @@
                  + "</script></head><body>"
                  + "<p>hello world</p>"
                  + "<form name='form1'>"
-                 + "    <input type='checkbox' name='checkbox1' id='checkbox1' value='foo' />"
+                 + "    <input type='cheCKbox' name='checkbox1' id='checkbox1' value='foo' />"
                  + "</form>"
                  + "<a href='javascript:test()' id='clickme'>click me</a>\n"
                  + "</body></html>";
@@ -217,7 +217,7 @@
                  + "<p>hello world</p>"
                  + "<form name='form1'>"
                  + "    <input type='radio' name='radio1' id='radioA' value='a' checked='checked'/>"
-                 + "    <input type='radio' name='radio1' id='radioB' value='b' />"
+                 + "    <input type='RADIO' name='radio1' id='radioB' value='b' />"
                  + "    <input type='radio' name='radio1' id='radioC' value='c' />"
                  + "</form>"
                  + "<a href='javascript:test()' id='clickme'>click me</a>\n"
Index: changes.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/changes.xml,v
retrieving revision 1.135
retrieving revision 1.136
diff -u -d -r1.135 -r1.136
--- changes.xml	19 Sep 2003 15:53:26 -0000	1.135
+++ changes.xml	29 Sep 2003 12:08:31 -0000	1.136
@@ -48,6 +48,10 @@
             <action type="add" dev="mbowler" id="799760">
 				Added WebClient.getWebWindows()
 			</action>
+            <action type="update" dev="mbowler" id="812749" due-to="Brad Clarke">
+                Fixed bug where radio button and checkbox logic was case sensitive.
+                Patch supplied by Brad Clarke
+            </action>
         </release>
 
         <release version="1.2.3" date="July 31, 2003">
Index: HtmlInput.java
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/html/HtmlInput.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -r1.28 -r1.29
--- HtmlInput.java	17 Sep 2003 18:24:38 -0000	1.28
+++ HtmlInput.java	29 Sep 2003 12:08:31 -0000	1.29
@@ -684,7 +684,7 @@
      * Reset this element to its original values.
      */
     public void reset() {
-        String type = this.getTypeAttribute();
+        String type = this.getTypeAttribute().toLowerCase();
         if( type.equals("checkbox")) {
             setChecked(initialCheckedState_);
         }
@@ -707,7 +707,7 @@
      * @param  isChecked true if this element is to be selected
      */
     public void setChecked( final boolean isChecked ) {
-        String type = this.getTypeAttribute();
+        String type = this.getTypeAttribute().toLowerCase();
         if (type.equals("checkbox") ) {
             setCheckedCheckBox(isChecked);
         }

[HtmlUnit] [ htmlunit-Feature Requests-814413 ] FORM - Add support for enctype attribute

[SourceForge.net <no...@so...>]

Feature Requests item #814413, was opened at 2003-09-29 12:03
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814413&group_id=47038

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Fourel (nes_olivier)
Assigned to: Nobody/Anonymous (nobody)
Summary: FORM - Add support for enctype attribute

Initial Comment:
 > I have a test running on an html page containing a 

form declared as

 > following :

 >

 > <FORM NAME="form" METHOD="POST" 

enctype="multipart/form-data">

 > .....

 > </FORM>



<snip>



 > IS HtmlUnit able to manage such enctype 

("multipart/form-data") ?



No, it currently ignores the encoding attribute.  Please 

open a feature 

request for this.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=814413&group_id=47038

Re: [HtmlUnit] FileInput does not work (from CVS)

[Mike B. <mb...@Ga...>]

ji...@le... wrote:
 > We needed to use the file upload stuff inside HtmlUnit and we saw the
 > patch sent in to the mailing list but we could not get it to work.
 >
 > We found that there was a bug inside HtmlFileUpload. To get it working
 > you have to add (override) the following method:
 >
 > public KeyValuePair[] getSubmitKeyValuePairs() {
 >     return new KeyDataPair[]{new KeyDataPair(getNameAttribute(),
 >                              new File(getValueAttribute()))};
 > }
 >
 > Please note that it uses "KeyDataPair" instead of KeyValuePair. Could
 > someone that have commit rights please add this in the cvs code?

I don't understand what the bug is.  Can you provide a test case that 
shows this failing?

-- 
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email  : mb...@Ga...
Fax  : (416) 822-0975 | Website: http://www.GargoyleSoftware.com

[HtmlUnit] FileInput does not work (from CVS)

[<ji...@le...>]

Hi!

We needed to use the file upload stuff inside HtmlUnit and we saw the
patch sent in to the mailing list but we could not get it to work.

We found that there was a bug inside HtmlFileUpload. To get it working you
have to add (override) the following method:

public KeyValuePair[] getSubmitKeyValuePairs() {
    return new KeyDataPair[]{new KeyDataPair(getNameAttribute(),
                             new File(getValueAttribute()))};
}

Please note that it uses "KeyDataPair" instead of KeyValuePair. Could
someone that have commit rights please add this in the cvs code?

/Regards, Jimmy and Behe @ Lecando

[HtmlUnit] [ htmlunit-Feature Requests-812757 ] Add jar-ing back to the ant build.xml

[SourceForge.net <no...@so...>]

Feature Requests item #812757, was opened at 2003-09-25 17:02
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=812757&group_id=47038

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Brad Clarke (yourgod)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add jar-ing back to the ant build.xml

Initial Comment:
Patch attached for those of us who are maven-less

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=812757&group_id=47038

[HtmlUnit] [ htmlunit-Bugs-812749 ] javascript radio and checkbox inputs are case sensitive

[SourceForge.net <no...@so...>]

Bugs item #812749, was opened at 2003-09-25 16:45
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=812749&group_id=47038

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Brad Clarke (yourgod)
Assigned to: Nobody/Anonymous (nobody)
Summary: javascript radio and checkbox inputs are case sensitive

Initial Comment:
If your input was type="RADIO" instead of type="radio"

then it wouldn't work right from javascript. Same for

type="checCKbox". The attached patch changes the

existing tests to check for this and fixes the issue.





----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448266&aid=812749&group_id=47038

[HtmlUnit] [ htmlunit-Feature Requests-810550 ] execute javascript from a popup

[SourceForge.net <no...@so...>]

Feature Requests item #810550, was opened at 2003-09-22 12:08
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=810550&group_id=47038

Category: None
Group: None
Status: Open
Priority: 5
Submitted By: Fourel (nes_olivier)
Assigned to: Nobody/Anonymous (nobody)
Summary: execute javascript from a popup

Initial Comment:
I wonder if a popup can execute a javascript function 

contained in its parent.

  

 Code called from the pop up window :

 parent.opener.addElementToList(value);

  

  

 This code throws the followong exception :

  

 Exception class=

[org.mozilla.javascript.EvaluatorException]

 com.gargoylesoftware.htmlunit.ScriptException: The 

undefined value has 

 no properties.



>>>>>>>>>>>>>>>>>>>

I would guess (without looking at the code) that either 

parent or opener hasn't been implemented yet.  Please 

open a feature request for this.





----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=810550&group_id=47038

[HtmlUnit] CVS Commit: htmlunit: Navigator.javaEnabled should be method not

[<no...@us...>]

Log Message:
-----------
Navigator.javaEnabled should be method not property

Modified Files:
--------------
    /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/javascript/host:
        Navigator.java
    /cvsroot/htmlunit/htmlunit/src/xdocs:
        changes.xml

Added Files:
-----------
    /cvsroot/htmlunit/htmlunit/src/test/java/com/gargoylesoftware/htmlunit/javascript/host:
        NavigatorTest.java

Revision Data
-------------
Index: changes.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/changes.xml,v
retrieving revision 1.133
retrieving revision 1.134
diff -u -d -r1.133 -r1.134
--- changes.xml	19 Sep 2003 12:10:20 -0000	1.133
+++ changes.xml	19 Sep 2003 14:45:22 -0000	1.134
@@ -42,6 +42,9 @@
                 Fixed bug where disabled elements were being submitted anyway.
                 Patch supplied by Brad Clarke
             </action>
+            <action type="update" dev="mbowler" id="800993">
+				Navigator.javaEnabled should be method not property
+			</action>
         </release>
 
         <release version="1.2.3" date="July 31, 2003">
Index: Navigator.java
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/java/com/gargoylesoftware/htmlunit/javascript/host/Navigator.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- Navigator.java	10 Jun 2003 11:56:59 -0000	1.6
+++ Navigator.java	19 Sep 2003 14:45:22 -0000	1.7
@@ -90,7 +90,7 @@
      * Return false always as java support is not enabled in HtmlUnit
      * @return false.
      */
-    public boolean jsGet_javaEnabled() {
+    public boolean jsFunction_javaEnabled() {
         return false;
     }
 }
--- NEW FILE: NavigatorTest.java ---
/*
 * Copyright (c) 2002, 2003 Gargoyle Software Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are met:
 *
 * 1. Redistributions of source code must retain the above copyright notice,
 *    this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright notice,
 *    this list of conditions and the following disclaimer in the documentation
 *    and/or other materials provided with the distribution.
 * 3. The end-user documentation included with the redistribution, if any, must
 *    include the following acknowledgment:
 *
 *       "This product includes software developed by Gargoyle Software Inc.
 *        (http://www.GargoyleSoftware.com/)."
 *
 *    Alternately, this acknowledgment may appear in the software itself, if
 *    and wherever such third-party acknowledgments normally appear.
 * 4. The name "Gargoyle Software" must not be used to endorse or promote
 *    products derived from this software without prior written permission.
 *    For written permission, please contact in...@Ga....
 * 5. Products derived from this software may not be called "HtmlUnit", nor may
 *    "HtmlUnit" appear in their name, without prior written permission of
 *    Gargoyle Software Inc.
 *
 * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES,
 * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
 * FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GARGOYLE
 * SOFTWARE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
 * OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
 * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
 * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
 * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
package com.gargoylesoftware.htmlunit.javascript.host;

import java.net.URL;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

import com.gargoylesoftware.htmlunit.CollectingAlertHandler;
import com.gargoylesoftware.htmlunit.FakeWebConnection;
import com.gargoylesoftware.htmlunit.WebClient;
import com.gargoylesoftware.htmlunit.WebTestCase;

/**
 * Tests for Navigator.
 *
 * @version  $Revision: 1.1 $
 * @author  <a href="mailto:mb...@Ga...">Mike Bowler</a>
 */
public class NavigatorTest extends WebTestCase {

    /**
     * Create an instance
     * @param name The name of the test
     */
    public NavigatorTest( final String name ) {
        super(name);
    }

    /**
     * The javaEnabled() method should always return false.  Test this
     * @throws Exception if the test fails.
     */
    public void testJavaEnabled() throws Exception {
        final WebClient client = new WebClient();
        final FakeWebConnection webConnection = new FakeWebConnection( client );

        final String firstContent
             = "<html><head><title>First</title><script>\n"
             + "function doTest() {\n"
             + "    alert(navigator.javaEnabled());\n"
             + "}\n</script></head>"
             + "<body onload='doTest()'></body></html>";

        webConnection.setResponse(
            new URL("http://first"), firstContent, 200, "OK", "text/html", Collections.EMPTY_LIST );
        client.setWebConnection( webConnection );

        final List collectedAlerts = new ArrayList();
        client.setAlertHandler( new CollectingAlertHandler(collectedAlerts) );

        client.getPage(new URL("http://first"));

        final List expectedAlerts = Arrays.asList( new String[]{"false"} );
        assertEquals( expectedAlerts, collectedAlerts );
    }
}

[HtmlUnit] [ htmlunit-Feature Requests-799760 ] Getting all top level windows

[SourceForge.net <no...@so...>]

Feature Requests item #799760, was opened at 2003-09-03 08:23
Message generated for change (Comment added) made by mbowler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=799760&group_id=47038

Category: None
Group: None
>Status: Closed
Priority: 5
Submitted By: Andrei Kirshin (akirshin1)
>Assigned to: Mike Bowler (mbowler)
Summary: Getting all top level windows

Initial Comment:
Please add support for getting all open windows:

TopLevelWindow[] WebClient.getAllWindows() [not 

static of course]

Currently the only way to get the list of all windows is to 

registering a listener and keeping track of all 

webWindowOpened events, which is less convenient. 

Oh, and also there is no webWindowClosed event (a 

window also can be closed from JavaScript), but there is 

a separate RFE on this.



Thanks a lot.

----------------------------------------------------------------------

>Comment By: Mike Bowler (mbowler)
Date: 2003-09-19 11:54

Message:
Logged In: YES 
user_id=46756

Added method WebClient.getWebWindows().  Note that this will

return *all* web windows which includes frames so you'll

need to do an instanceof check to get just the ones you care

about.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=448269&aid=799760&group_id=47038

[HtmlUnit] CVS Commit: htmlunit: Migrated more of the build process from ant to

[<no...@us...>]

Log Message:
-----------
Migrated more of the build process from ant to maven.  Removed the old checkstyle stuff in favour of the new checkstyle xml configuration

Modified Files:
--------------
    /cvsroot/htmlunit/htmlunit/src/xdocs:
        buildingFromCvs.xml
        codingConventions.xml
        changes.xml
    /cvsroot/htmlunit/htmlunit:
        maven.xml
        build.xml

Removed Files:
-------------
    /cvsroot/htmlunit/htmlunit/build/lib:
        checkstyle-all.jar
    /cvsroot/htmlunit/htmlunit/build:
        checkstyle-test.properties
        checkstyle-prod.properties

Revision Data
-------------
Index: buildingFromCvs.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/buildingFromCvs.xml,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -d -r1.7 -r1.8
--- buildingFromCvs.xml	17 Sep 2003 13:38:31 -0000	1.7
+++ buildingFromCvs.xml	19 Sep 2003 12:10:20 -0000	1.8
@@ -35,39 +35,34 @@
 
         <section name="Compiling the code">
             <p>
-                Make sure that you have <a href="http://jakarta.apache.org/ant">Ant</a> 1.5 installed.
-                The build.xml file is located in the root of the src directory so change to that
-                directory and execute the following commands
+                Although it is still possible to compile the code with 
+                <a href="http://ant.apache.org">Ant</a> 1.5 or higher, the preferred way
+                to build HtmlUnit is with <a href="http://maven.apache.org">maven</a>.
             </p>
-            <source>ant initialize</source>
+            <source>maven java:compile</source>
             <p>
-                This will get the libraries needed to build that are not in the CVS repository.
+                This will do an incremental compile of all the code.
             </p>
-            <source>ant cleancompile</source>
+            <source>maven clean java:compile</source>
             <p>
-                This will delete all the existing class files and recompile all the source from scratch.
+                This will do a clean compile of all the code.
             </p>
         </section>
 
         <section name="Running the tests">
             <p>
-                All the tests are based on <a href="http://www.junit.org/">JUnit</a>.  JUnit is already provided
-                in the lib directory so you don't need to install anything extra.  The main tests can be
-                executed with either the text runner or the swing runner from JUnit.  The "junit" target
-                will dump status information to the command line while "junitui" will present a swing
-                user interface with a progress bar.
+                All the tests are based on <a href="http://www.junit.org/">JUnit</a>.  The standard
+                maven way of running the tests results in a large number of test reports which can
+                be difficult to sift through to find failures.  The fast-test goal has been created
+                to provide a quick run of the tests that dumps easy status information to the command
+                line.
             </p>
-            <source>ant junit</source>
-            <br />
-            <source>ant junitui</source>
+            <source>maven htmlunit:test</source>
             <p>
-                Strangely, the Swing version takes about three times as long to execute as the text runner
-                so I rarely use it.  If you are using the Swing version then you will have to uncheck
-                "reload classes" or else all the javascript related tests will fail.  It seems that
-                the javascript engine and the logging framework don't like to be reloaded.
+            	Calling htmlunit:test will force a recompile of the java classes if needed.
             </p>
         </section>
-
+<!--
         <section name="Packaging the code">
             <source>ant build</source>
             <p>
@@ -77,5 +72,6 @@
                 called projectdocs.zip that contains all the generated documentation.
             </p>
         </section>
+-->        
     </body>
 </document>
Index: codingConventions.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/codingConventions.xml,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- codingConventions.xml	17 Sep 2003 13:38:32 -0000	1.5
+++ codingConventions.xml	19 Sep 2003 12:10:20 -0000	1.6
@@ -24,7 +24,8 @@
                 We use <a href="http://checkstyle.sourceforge.net">checkstyle</a> to check as many coding
                 conventions as possible.  Things covered by checkstyle are only documented below if we feel
                 that they require explanation.  You can run checkstyle with the following ant target.
-                <source>ant checkstyle</source>
+                <source>maven htmlunit:checkstyle</source>
+                The results of the check will be in the file target/checkstyle-raw-report.txt
             </p>
         </section>
 
@@ -33,7 +34,7 @@
                 All code must have 100% automated test coverage using the <a href="http://www.junit.org">JUnit</a>
                 testing framework.  I strongly suggest that you write the code test-first but I'll be happy
                 as long as there are full tests for everything.  Run the tests with the following ant target.
-                <source>ant junit</source>
+                <source>maven htmlunit:test</source>
             </p>
             <p>
                 There are a couple of tests that hit live web servers as a final sanity check but the vast
Index: changes.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/src/xdocs/changes.xml,v
retrieving revision 1.132
retrieving revision 1.133
diff -u -d -r1.132 -r1.133
--- changes.xml	18 Sep 2003 19:07:22 -0000	1.132
+++ changes.xml	19 Sep 2003 12:10:20 -0000	1.133
@@ -7,6 +7,9 @@
 
     <body>
         <release version="Next" date="not released yet">
+            <action type="update" dev="mbowler">
+                Continued migration of the build process from ant to maven.
+            </action>
             <action type="update" dev="mbowler" id="713646">
                 Patch for bug in onload handler submitted by Andreas Hangler
             </action>
--- checkstyle-all.jar DELETED ---
--- checkstyle-test.properties DELETED ---
--- checkstyle-prod.properties DELETED ---
Index: maven.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/maven.xml,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- maven.xml	17 Sep 2003 13:38:29 -0000	1.6
+++ maven.xml	19 Sep 2003 12:10:21 -0000	1.7
@@ -178,4 +178,32 @@
             basedir="${maven.dist.bin.assembly.dir}/${maven.final.name}"/>
     </goal>
 
+	<!-- Run all the tests as quickly as possible.  This only outputs results
+	     to the console so if you are trying to generate reports, you will 
+	     need to call the slower "test" goal -->
+	<goal 
+		name="htmlunit:test" 
+		description="Run all the tests and output results to the console."
+		prereqs="test:compile">
+		
+	    <ant:java fork="true" classname="junit.textui.TestRunner" dir="target/test-classes">
+	        <arg value="com.gargoylesoftware.htmlunit.MainTestSuite"/>
+            <ant:classpath>
+            	<ant:path refid="maven.dependency.classpath"/>
+	            <ant:pathelement path="${maven.build.dest}"/>
+	            <ant:pathelement path="target/test-classes"/>
+    	    </ant:classpath>
+	    </ant:java>
+	</goal>
+	
+	<goal name="htmlunit:sanity-check" description="Run tests against a bunch of live servers">
+	    <ant:java fork="yes" classname="com.gargoylesoftware.htmlunit.SanityCheck" dir="src/java">
+            <ant:classpath>
+            	<ant:path refid="maven.dependency.classpath"/>
+	            <ant:pathelement path="${maven.build.dest}"/>
+	            <ant:pathelement path="target/test-classes"/>
+    	    </ant:classpath>
+	    </ant:java>
+	</goal>
+	
 </project>
Index: build.xml
===================================================================
RCS file: /cvsroot/htmlunit/htmlunit/build.xml,v
retrieving revision 1.43
retrieving revision 1.44
diff -u -d -r1.43 -r1.44
--- build.xml	17 Sep 2003 13:38:29 -0000	1.43
+++ build.xml	19 Sep 2003 12:10:21 -0000	1.44
@@ -19,10 +19,6 @@
 <property name="local-repository" value ="target/repository"/>
 <property name="remote-repository" value="http://www.ibiblio.org/maven"/>
 
-<taskdef name="checkstyle"
-    classname="com.puppycrawl.tools.checkstyle.CheckStyleTask"
-    classpath="build/lib/checkstyle-all.jar" />
-
 <path id="base.class.path">
     <pathelement path="target/classes"/>
 
@@ -115,168 +111,6 @@
     </xmlvalidate>
 </target>
 
-<target name="build" depends="compile" description="build">
-    <tstamp>
-        <format property="timestamp-now" pattern="d-MMM-yyyy hh:mma" locale="en"/>
-    </tstamp>
-
-    <delete dir="build/${version}"/>
-
-    <mkdir dir="build/${version}/"/>
-    <mkdir dir="build/${version}/docs"/>
-    <mkdir dir="build/${version}/docs/api"/>
-    <mkdir dir="build/${version}/lib"/>
-    <mkdir dir="build/${version}/src"/>
-    <mkdir dir="build/${version}/META-INF"/>
-
-    <manifest file="build/${version}/META-INF/MANIFEST.MF">
-        <attribute name="Main-Class" value="com.gargoylesoftware.htmlunit.Version"/>
-
-        <section name="com/gargoylesoftware/htmlunit/">
-            <attribute name="Sealed" value="true"/>
-            <attribute name="Specification-Title" value="HtmlUnit"/>
-            <attribute name="Specification-Version" value="${version}"/>
-            <attribute name="Specification-Vendor" value="Gargoyle Software Inc."/>
-            <attribute name="Implementation-Title" value="HtmlUnit"/>
-            <attribute name="Implementation-Version" value="${version} ${timestamp-now}"/>
-            <attribute name="Implementation-Vendor" value="Gargoyle Software Inc."/>
-        </section>
-        <section name="com/gargoylesoftware/htmlunit/html/">
-            <attribute name="Sealed" value="true"/>
-        </section>
-        <section name="com/gargoylesoftware/htmlunit/javascript/">
-            <attribute name="Sealed" value="true"/>
-        </section>
-        <section name="com/gargoylesoftware/htmlunit/javascript/host/">
-            <attribute name="Sealed" value="true"/>
-        </section>
-    </manifest>
-
-    <jar
-        jarfile="build/${version}/lib/HtmlUnit.jar"
-        basedir="target/classes"
-        excludes="**/test/*,**/*.java,build.xml,lib,**/package.html"
-        manifest="build/${version}/META-INF/MANIFEST.MF"/>
-    <delete file="build/${version}/META-INF/MANIFEST.MF"/>
-
-    <jar
-        jarfile="build/${version}/lib/HtmlUnit-src.jar"
-        basedir="src/java"
-        includes="**/*.java"/>
-
-    <javadoc
-        sourcepath="src/java"
-        destdir="build/${version}/docs/api"
-        packagenames="${packageList}"
-        version="yes"
-        author="yes"
-        windowtitle="${version}"
-        doctitle="${version}">
-
-        <classpath refid="base.class.path"/>
-        <packageset dir="src/java" defaultexcludes="no">
-            <exclude name="**/test" />
-        </packageset>
-        <link href="http://java.sun.com/j2se/1.4.1/docs/api"/>
-    </javadoc>
-
-    <copy todir="build/${version}/src">
-        <fileset dir="src/java">
-            <exclude name="**/*.class"/>
-            <exclude name="test/**"/>
-        </fileset>
-    </copy>
-
-    <!-- Build the docs -->
-    <style
-        basedir="src/xdocs"
-        destdir="build/${version}/docs"
-        extension=".html"
-        style="src/xdocs/stylesheets/site.xsl"
-        includes="*.xml">
-        <param name="pathToRoot" expression=""/>
-    </style>
-    <!--
-    <style
-        basedir="src/xdocs"
-        destdir="build/${version}/docs"
-        extension=".html"
-        style="/docs/site.xsl"
-        includes="**/*.xml"
-        excludes="*.xml">
-        <param name="pathToRoot" expression="../"/>
-    </style>
-    -->
-    <copy todir="build/${version}/docs" >
-        <fileset dir="src/xdocs/images" >
-            <include name="**/*.jpg"/>
-            <include name="**/*.gif"/>
-        </fileset>
-    </copy>
-
-    <copy todir="build/${version}/docs/tools" >
-        <fileset dir="ide" />
-    </copy>
-
-    <copy todir="build/${version}/lib">
-        <fileset dir="dist/lib">
-            <include name="*.jar"/>
-        </fileset>
-    </copy>
-
-    <zip
-        zipfile="dist/${version}.zip"
-        basedir="build"
-        includes="${version}/**"
-    />
-
-    <!-- Build the documentation zip file for uploading -->
-    <zip
-        zipfile="dist/projectdocs.zip"
-        basedir="build/${version}/docs"
-        includes="**/*.html,**/*.jpg,**/*.gif,**/package-list,tools/**/*"
-        excludes="src/**"
-    />
-
-    <echo message=""/>
-    <echo message="Doing a final sanity check to ensure that everything that is needed has been put in the dist directory"/>
-
-    <java fork="true" classname="com.gargoylesoftware.htmlunit.Version">
-        <arg value="-SanityCheck"/>
-        <classpath>
-            <fileset dir="build/${version}/lib">
-                <include name="**/*.jar"/>
-            </fileset>
-        </classpath>
-    </java>
-
-    <echo message=""/>
-    <echo message="************************************************************"/>
-    <echo message="Full packaged build is dist/${version}.zip"/>
-    <echo message="Zipped documentation is dist/projectdocs.zip"/>
-    <echo message="  "/>
-    <echo message="An unzipped build suitable for browsing is in build/${version}"/>
-    <echo message="************************************************************"/>
-    <!--
-    <delete dir="build/${version}"/>
-    -->
-</target>
-
-<target name="doclint" description="doclint">
-    <javadoc
-        sourcepath="src/java"
-        packagenames="${packageList}"
-        version="no"
-        author="no"
-        doclet="com.jollem.doclint.DocLint"
-        docletPath="build/lib/doclint.jar">
-
-        <classpath refid="base.class.path"/>
-        <packageset dir="src/java" defaultexcludes="no">
-            <exclude name="**/test" />
-        </packageset>
-    </javadoc>
-</target>
 
 <target name="junit" description="junit">
     <java fork="true" classname="junit.textui.TestRunner" dir="target/test-classes">
@@ -293,26 +127,6 @@
     </java>
 </target>
 
-<target name="SanityCheck" description="DO NOT RUN THIS TASK">
-    <java fork="yes" classname="com.gargoylesoftware.htmlunit.SanityCheck" dir="src/java">
-        <classpath refid="base.class.path"/>
-        <classpath refid="test.class.path"/>
-    </java>
-</target>
-
-<target name="checkstyle" description="Check all the coding conventions">
-    <!-- Check production code -->
-    <!--
-    <checkstyle properties="build/checkstyle-prod.properties">
-        <fileset dir="src/java" includes="**/*.java" excludes="**/test/*"/>
-    </checkstyle>
--->
-    <!-- Check tests - test code is a bit more lenient -->
-    <checkstyle properties="build/checkstyle-prod.properties">
-        <fileset dir="src/test/java"/>
-    </checkstyle>
-</target>
-
 <target name="jellytest" description="DO NOT RUN THIS TASK">
     <java fork="yes" classname="org.apache.commons.jelly.Jelly" dir=".">
         <classpath refid="base.class.path"/>
@@ -323,16 +137,12 @@
 <target name="get-dependency">
     <mkdir dir="${local-repository}/${project}/jars/"/>
     <get
-
         src="${remote-repository}/${project}/jars/${jarName}"
-
         dest="${local-repository}/${project}/jars/${jarName}"/>
 </target>
 
 <target
-
     name="initialize"
-
     description="Get all the required dependencies from a remote repository">
 
     <antcall target="get-dependency">