Re: [Htmlparser-developer] Added methods to NodeList

[Matthew B. <mat...@co...>]

Derrick Oswald wrote:
> 
> To answer your second question first, it's a legacy thing, trying to 
> keep the base classes compatible with Java 1.x and avoiding the new Java 
> Collections Framework. This can probably be revisited, since the goal of 
> backward compatiblity has less emphasis these days.

Ok. Even if NodeList didn't implement java.util.List having similar 
methods makes the learning curve smaller for most Java programmers.

On a slightly related note, is there a reason for using a array for the 
Nodes in NodeList but a Vector for the attributes in TagNode? Switching 
to a Vector in NodeList would make it easy to expose more flexible 
methods. Was it orginally decided to use an array for performance reasons?

> Removing nodes from an underlying collection while an iterator is active 
> on it is fraught with peril.

Nothing like living dangerously ;-)

> It might work in some cases (and I'm a little surprised it worked for 
> you), but I think the better approach it to throw all the nodes to be 
> deleted in a 'garbage bin' and remove them all later.

Ok. I'll probably change to this method.

I was just going to use a filter but then I either end up running 
multiple filters over the same tree or do the same tests on the nodes 
the filter returns to work out what I should be doing to them, neither 
seemed very sensible.

Using a visitor I at least only traverse the tree once and can perform 
the alterations.

 > Yes, the NodeList
> could use a remove(Node) call.
 > You could add the patch to the Patches
> tracker (http://sourceforge.net/tracker/?group_id=24399&atid=381401) or 
> Request For Enhancement tracker 
> (http://sourceforge.net/tracker/?group_id=24399&atid=381402), but it's 
> probably good enough in the mail list here.

Ok.

-- 
+--Matthew Buckett-----------------------------------------+
| VLE Developer, Learning Technologies Group               |
| Tel: +44 (0) 1865 283660 http://www.oucs.ox.ac.uk/       |
+------------Computing Services, University of Oxford------+