[Htmlparser-developer] Result of first round of refactoring
Brought to you by:
derrickoswald
From: Somik R. <so...@ya...> - 2002-12-28 23:55:11
|
Hi Folks, I'm done removing all duplication of toHTML(). Now, most tags either = inherit from HTMLCompositeTag or use the standard toHTML() in HTMLTag. = This was only the first step. But here are some interesting results : [1] Code size of the package org.htmlparser.tags reduced from 1218 to = 1082 lines (not counting tags and empty lines). A new class has been = added - org.htmlparser.tests.codeMetrics.LineCounter. It can recurse = through java files in a given directory and get the total count. [2] Due to the refactoring, I uncovered a bug in HTMLStringNode, in the = handling of single quotes. [3] There were a lot of complaints earlier (if I remember right, mostly = from Dhaval) about toHTML() putting in its own line breaks. That = shouldn't happen anymore. Any toHTML() bugs will be much easier to fix = as the code is in one place, and is uniform. [4] We have the added benefit of getting textarea contents in = toPlainTextString() automatically, as it now inherits from a composite = tag. We should be able to have a release tomorrow. I am currently waiting = for Derrick to fix the two tests that are failing. Derrick --> if you = dont find the time this week, I can comment out the two failing methods = in this week's version. Regards, Somik |