[Htmlparser-developer] Re: [Htmlparser-user] Testing/feedback, question
Brought to you by:
derrickoswald
From: Somik R. <so...@ya...> - 2002-06-26 02:01:17
|
WRT exception handling vs. feedback, only fatal exceptions should be = thrown and feedback, where you are currently using System.out or = System.err should go through an interface that users can reroute as they = might prefer (to logs, console or ignore them). I have written up the = classes and packaged them under the com.kizna.html.util package. I can = send these to you in any form you like. I agree. The existing System.err.println() statements - I think they all = indicate fatal errors - hence should be converted to an exception = throwing system. The Callback mechanism should also come in so we can start using it in = the rest of the library. Also - another issue I have been thinking of is SAX compliance. I dont = think it will be hard to make callbacks from the parse() method... What = do you think ? The files are: =20 HTMLFeedback DefaultHTMLFeedback FeedbackManager HTMLParserException (a chained exception class). =20 You put them in CVS. Do you think it'd be better to have a = com.kizna.html.exceptions package instead of util, for better naming = conventions ? I am debating whether to keep the ChainedException class as a base class = for more general use and use an HTMLParserException subclass. Any = thoughts? Hmm.. I'd need to see the code before I can comment. Since you are now going to be a developer - here are two important = guidelines (which you might be already following) : [1] all the code that is checked in must come with testcases and should = not break existing tests. As of now the parser is almost 100% covered by = tests. [2] The bug fixing strategy is - write a testcase to simulate the bug, = make the testcase fail, then fix the bug. Cheers, Somik |