htmlparser-developer

RE: [Htmlparser-developer] FormScanner (for Kaarle Kaila)

[<dha...@or...>]

Also no attributes not specified in the tag originally should be
displayed as a result of the toHtml() call.

For example, the following is happening:
<FORM></FORM>

is reproduced as=20

<FORM ACTION=3D""></FORM>


   It should be correctly reproduced as <FORM></FORM>
  =20
   If this is so, it is definitely wrong. Can you write a testcase for
   this ? I am a bit surprised, bcos FormTag does not even have a
   toHtml() - it uses CompositeTag's toHtml().
  =20

   I have logged it already with another bug at #713907. Its not really
   a test case since I am trying to depict another abnormal behaviour as
   well. Do check it out.
   =A0
   Regards,
   Dhaval

RE: [Htmlparser-developer] FormScanner (for Kaarle Kaila)

[<dha...@or...>]

Hi Somik,

The SelectTag class has a List of OptionTags underneath it. However the
FormTag has a NodeList of InputTags and TextArea tags. I think these 2
should be synchronized for consistency.

Can you explain more ? FormTag does have the standard children's list,
in addition to which, it has the input tags and textareas. There is
redundancy, but its there to provide helpful searches.
[Udani, Dhaval H.]=A0
The redundancy is acceptable. It would be useful for searches. My point
is different.=A0Input and Textarea are=A0child nodes of Form and are stor=
ed
as=A0a NodeList. Similarly Option is a child of Select and should be
stored as a NodeList instead of List as is at present.
=A0
For example, the following is happening:
<FORM></FORM>

is reproduced as=20

<FORM ACTION=3D""></FORM>
It should be correctly reproduced as <FORM></FORM>
If this is so, it is definitely wrong. Can you write a testcase for this
? I am a bit surprised, bcos FormTag does not even have a toHtml() - it
uses CompositeTag's toHtml().
[Udani, Dhaval H.]=A0
Will do so immediately.=A0
=A0
Regards,
Dhaval

Re: [Htmlparser-developer] FormScanner (for Kaarle Kaila)

[Somik R. <so...@ya...>]

Dhaval Udani wrote:
The redundancy is acceptable. It would be useful for searches. My point
is different. Input and Textarea are child nodes of Form and are stored
as a NodeList. Similarly Option is a child of Select and should be
stored as a NodeList instead of List as is at present.

I see what you mean, and I agree with you. Pls feel free to make this =
modification. (bytway, be sure to check out the latest version from cvs, =
there've been some changes)

Regards,
Somik

RE: [Htmlparser-developer] FormScanner (for Kaarle Kaila)

[<dha...@or...>]

Hi Somik,
 

I was checking out the code of form scanner and I saw that it contained
a list of all the INPUT tags and all the TEXTAREA tags. In addition we
need to add the list of SELECT tags also out here..

Thanks for catching this. Done.
[Udani, Dhaval H.] 
I yet don't see this in the latest code. 
 
Dhaval

Re: [Htmlparser-developer] FormScanner (for Kaarle Kaila)

[Somik R. <so...@ya...>]

Dhaval Udani wrote:
> I was checking out the code of form scanner and I saw that it contained
> a list of all the INPUT tags and all the TEXTAREA tags. In addition we
> need to add the list of SELECT tags also out here..
> 
> Thanks for catching this. Done.
> [Udani, Dhaval H.] 
> I yet don't see this in the latest code. 

I meant this is now transferred to the FormTag instead of the FormScanner.
Could you add the select tags to the FormTag, and make all of them lazy ?

Thanks and Regards,
Somik

RE: [Htmlparser-developer] FormScanner (for Kaarle Kaila)

[<dha...@or...>]

Dhaval Udani wrote:
> I was checking out the code of form scanner and I saw that it contained
> a list of all the INPUT tags and all the TEXTAREA tags. In addition we
> need to add the list of SELECT tags also out here..
> 
> Thanks for catching this. Done.
> [Udani, Dhaval H.] 
> I yet don't see this in the latest code. 

I meant this is now transferred to the FormTag instead of the FormScanner.
Could you add the select tags to the FormTag, and make all of them lazy ?

[Dhaval]
I'll do this.