htmlparser-developer

[Htmlparser-developer] Re: Daily bugs ... and one little fix:)

[Somik R. <so...@ya...>]

When I parse this url:
www.revues.org/calenda/articles/1083.html
Parsing this file last more than 40 second so I've searched which =
problem=20
may reduce performance.

First, I begin to fix this problem with prevent it to appear.

In HTMLReader.java:
------------------------------
protected boolean readNextLine()
{
   boolean skipLine =3D true;
   if (posInLine!=3D-1 && !(line !=3D null && =
node.elementEnd()+1>=3Dline.length()))
   {
     for (int i =3D 0; i < line.length(); i++)
     {
       if (line.charAt(i) !=3D ' ')
       {
         skipLine =3D false;
         break;
       }
     }
   }
   return skipLine;
}

Then I read sources around and I remark it will be a better idea to =
patch=20
HTMLStringNode.java
The solution is to go in state 1 when you are at the end of a space =
string.

if (state=3D=3D1)
{
   text+=3Dinput.charAt(i);
}
file://patch beginning here
if (state=3D=3D0 && i=3D=3Dinput.length()-1)
   state=3D1;
file://patch ending here
if (state=3D=3D1 && i=3D=3Dinput.length()-1)
{
   input =3D reader.getNextLine();
///.....

I think the second solution is better. I hope this fix will help you =
Somik,=20
to patch the code in the next integration release.

This fix is incorporated. Thanks. Ive written a test case to trap this =
bug.

Regards,
Somik

[Htmlparser-developer] Malformed End Tag [Was:Daily bugs ... and one little fix:)]

[Somik R. <so...@ya...>]

Hi Cedric,

Today, I've found another bug :)
http://www.cybergeo.presse.fr/sommaire/sisterra/ind15.htm
The last ">" is missing in the title mark out.
<TITLE>SISTEMA TERRA, VOL. VI , No. 1-3, December 1997</TITLE
=3D> null pointer exception
If I remember, you have already fix this problem with IMG mark out. Hope =

this patch will be the same.

I think this is a diff bug altogether - probably in HTMLEndTag. Will try =
fixing it soon.
Thanks for finding this.

Regards,
Somik

Re: [Htmlparser-developer] Malformed End Tag [Was:Daily bugs ... and one little fix:)]

[Somik R. <so...@ya...>]

Hi Cedric,
    This is fixed. You can check out the latest parser from CVS.=20
    Or wait till tomorrow, I will make the next integration release.
    Thank you for your good work on the bug reports. Bytway, I would be =
glad to give you CVS access so you can directly checkin bug fixes. Send =
me your sourceforge id.

Cheers,
Somik
----- Original Message -----=20
  From: Somik Raha=20
  To: htm...@li...=20
  Sent: Friday, July 19, 2002 5:48 PM
  Subject: [Htmlparser-developer] Malformed End Tag [Was:Daily bugs ... =
and one little fix:)]


  Hi Cedric,

  Today, I've found another bug :)
  http://www.cybergeo.presse.fr/sommaire/sisterra/ind15.htm
  The last ">" is missing in the title mark out.
  <TITLE>SISTEMA TERRA, VOL. VI , No. 1-3, December 1997</TITLE
  =3D> null pointer exception
  If I remember, you have already fix this problem with IMG mark out. =
Hope=20
  this patch will be the same.

  I think this is a diff bug altogether - probably in HTMLEndTag. Will =
try fixing it soon.
  Thanks for finding this.

  Regards,
  Somik
  =20