Thread: [Htmlparser-developer] Bug in parseParameters() - Kaarle, need your help

Brought to you by: derrickoswald

htmlparser-developer

[Htmlparser-developer] Bug in parseParameters() - Kaarle, need your help

From: Somik R. <so...@ya...> - 2002-07-31 02:11:24

Hi Kaarle,   =20
    I am hoping you will have some time to help us on bug report 588885. =
You would have already got the mail from Bugzilla - there seems to be a =
bug in parseParameters() in dealing with spaces before =3D. I am =
wondering if I introduced this bug recently, or if this was always =
there.
    Thanks in advance.

Cheers,
Somik

Re: [Htmlparser-developer] Bug in parseParameters() - Kaarle, need your help

From: Kaarle K. <kaa...@ik...> - 2002-07-31 19:38:11

At 11:04 31.7.2002 +0900, you wrote:
>Hi Kaarle,
>     I am hoping you will have some time to help us on bug report 588885. 
> You would have already got the mail from Bugzilla - there seems to be a 
> bug in parseParameters() in dealing with spaces before =. I am wondering 
> if I introduced this bug recently, or if this was always there.
>     Thanks in advance.
>
hi,

Quite a lot of changes in HTMLParser since I last time looked at it.
I guess they have to do with all the bad html syntax there has been on the 
list lately.

I made the modification and I wrote one testcase for it and it looks like 
OK now.

regards
Kaarle

>Cheers,
>Somik
>
>

---------------------------------------------
Kaarle Kaila
http://www.iki.fi/kaila
mailto:kaa...@ik...
tel: +358 50 3725844

Re: [Htmlparser-developer] Bug in parseParameters() - Kaarle, need your help

From: Somik R. <so...@ya...> - 2002-08-01 02:24:29

Dear Kaarle,

I made the modification and I wrote one testcase for it and it looks =
like=20
OK now.   =20

Wow - you're fast! All testcases are passing! Thanks a ton. Bytway, your =
parseParameters() method is really a key method in the parser - so I am =
really interested in doing a profiling and see how we can optimize. It =
will be great to collaborate on this. Bytway, there are two flags that I =
see -isApo and isAmp. I guess the former is to flag an apostrophe, but =
what is the latter ? Also, if I were to replace t and st with some =
names, what would you suggest ?

Quite a lot of changes in HTMLParser since I last time looked at it.
I guess they have to do with all the bad html syntax there has been on =
the=20
list lately.

Oh yes, a lot of them are due to bug fixes, and some great suggestions =
from the community. I have recieved some particularly fine suggestions =
from Sam Joseph and Claude Duguay. Sam's idea of providing data =
extraction methods like toHTML(), toPlainString(), took usability to the =
next level.

Claude's suggestions, if implemented, will truly make this parser =
professional :). Thats next on our agenda.=20

Once again - thanks so much for your quick action on this bug. Bytway, =
could you flag this bug as fixed on the htmlparser page with some =
comment, for archiving purposes ? (You are a developer, so you can login =
and go to the htmlparser bugs page from =
http://htmlparser.sourceforge.net ).

Regards,
Somik
  ----- Original Message -----=20
  From: Kaarle Kaila=20
  To: htm...@li...=20
  Sent: Thursday, August 01, 2002 4:35 AM
  Subject: Re: [Htmlparser-developer] Bug in parseParameters() - Kaarle, =
need your help

  At 11:04 31.7.2002 +0900, you wrote:
  >Hi Kaarle,
  >     I am hoping you will have some time to help us on bug report =
588885.=20
  > You would have already got the mail from Bugzilla - there seems to =
be a=20
  > bug in parseParameters() in dealing with spaces before =3D. I am =
wondering=20
  > if I introduced this bug recently, or if this was always there.
  >     Thanks in advance.
  >
  hi,

  Quite a lot of changes in HTMLParser since I last time looked at it.
  I guess they have to do with all the bad html syntax there has been on =
the=20
  list lately.

  I made the modification and I wrote one testcase for it and it looks =
like=20
  OK now.

  regards
  Kaarle

  >Cheers,
  >Somik
  >
  >

  ---------------------------------------------
  Kaarle Kaila
  http://www.iki.fi/kaila
  mailto:kaa...@ik...
  tel: +358 50 3725844

  -------------------------------------------------------
  This sf.net email is sponsored by: Dice - The leading online job board
  for high-tech professionals. Search and apply for tech jobs today!
  http://seeker.dice.com/seeker.epl?rel_code=3D31
  _______________________________________________
  Htmlparser-developer mailing list
  Htm...@li...
  https://lists.sourceforge.net/lists/listinfo/htmlparser-developer

Re: [Htmlparser-developer] Bug in parseParameters() - Kaarle, need your help

From: Kaarle K. <kaa...@ik...> - 2002-08-01 04:20:01

At 11:17 1.8.2002 +0900, you wrote:
>Dear Kaarle,
>
>I made the modification and I wrote one testcase for it and it looks like
>OK now.
>
>Wow - you're fast! All testcases are passing! Thanks a ton. Bytway, your 
>parseParameters() method is really a key method in the parser - so I am 
>really interested in doing a profiling and see how we can optimize. It 
>will be great to collaborate on this. Bytway, there are two flags that I 
>see -isApo and isAmp. I guess the former is to flag an apostrophe, but 
>what is the latter ? Also, if I were to replace t and st with some names, 
>what would you suggest ?

isApo waits for next '-sign and
isAmp waits for next "-sign. I guess isAmp should be called something else 
(isCitation?)

I guess t stands for temp. Perhaps it could be e.g. item.
st should perhaps be token but then
the current token should be renamed to something like tokenSet.


>
>Quite a lot of changes in HTMLParser since I last time looked at it.
>I guess they have to do with all the bad html syntax there has been on the
>list lately.
>Oh yes, a lot of them are due to bug fixes, and some great suggestions 
>from the community. I have recieved some particularly fine suggestions 
>from Sam Joseph and Claude Duguay. Sam's idea of providing data extraction 
>methods like toHTML(), toPlainString(), took usability to the next level.
>
>Claude's suggestions, if implemented, will truly make this parser 
>professional :). Thats next on our agenda.
>
>Once again - thanks so much for your quick action on this bug. Bytway, 
>could you flag this bug as fixed on the htmlparser page with some comment, 
>for archiving purposes ? (You are a developer, so you can login and go to 
>the htmlparser bugs page from 
><http://htmlparser.sourceforge.net>http://htmlparser.sourceforge.net ).

OK. I wrote there something. Hope that was what you meant.

Kaarle


>
>Regards,
>Somik
>>----- Original Message -----
>>From: <mailto:kaa...@ik...>Kaarle Kaila
>>To: 
>><mailto:htm...@li...>htm...@li... 
>>
>>Sent: Thursday, August 01, 2002 4:35 AM
>>Subject: Re: [Htmlparser-developer] Bug in parseParameters() - Kaarle, 
>>need your help
>>
>>At 11:04 31.7.2002 +0900, you wrote:
>> >Hi Kaarle,
>> >     I am hoping you will have some time to help us on bug report 588885.
>> > You would have already got the mail from Bugzilla - there seems to be a
>> > bug in parseParameters() in dealing with spaces before =. I am wondering
>> > if I introduced this bug recently, or if this was always there.
>> >     Thanks in advance.
>> >
>>hi,
>>
>>Quite a lot of changes in HTMLParser since I last time looked at it.
>>I guess they have to do with all the bad html syntax there has been on the
>>list lately.
>>
>>I made the modification and I wrote one testcase for it and it looks like
>>OK now.
>>
>>regards
>>Kaarle
>>
>> >Cheers,
>> >Somik
>> >
>> >
>>
>>---------------------------------------------
>>Kaarle Kaila
>><http://www.iki.fi/kaila>http://www.iki.fi/kaila
>>mailto:kaa...@ik...
>>tel: +358 50 3725844
>>
>>
>>
>>
>>-------------------------------------------------------
>>This sf.net email is sponsored by: Dice - The leading online job board
>>for high-tech professionals. Search and apply for tech jobs today!
>><http://seeker.dice.com/seeker.epl?rel_code=31>http://seeker.dice.com/seeker.epl?rel_code=31
>>_______________________________________________
>>Htmlparser-developer mailing list
>><mailto:Htm...@li...>Htm...@li...
>>https://lists.sourceforge.net/lists/listinfo/htmlparser-developer
>
>---------------------------------------------
>Kaarle Kaila
>http://www.iki.fi/kaila
>mailto:kaa...@ik...
>tel: +358 50 3725844

Re: [Htmlparser-developer] Bug in parseParameters() - Kaarle, need your help

From: Somik R. <so...@ya...> - 2002-08-02 12:29:46

Hi Kaarle,
> isApo waits for next '-sign and
> isAmp waits for next "-sign. I guess isAmp should be called something else
> (isCitation?)
>
> I guess t stands for temp. Perhaps it could be e.g. item.
> st should perhaps be token but then
> the current token should be renamed to something like tokenSet.

Thanks for the clarifications. I will change the names tomorrow.

> >Once again - thanks so much for your quick action on this bug. Bytway,
> >could you flag this bug as fixed on the htmlparser page with some
comment,
> >for archiving purposes ? (You are a developer, so you can login and go to
> >the htmlparser bugs page from
> ><http://htmlparser.sourceforge.net>http://htmlparser.sourceforge.net ).
>
> OK. I wrote there something. Hope that was what you meant.

Yeah - that was good. Can you also change the status of the bug to "fixed",
and close the report (change the Open status to Closed).

Thanks a lot.

Cheers,
Somik