RE: [htmltmpl] Re: Patches for HTML-Template-2.5.tar.gz

[Kenny S. <ke...@jo...>]

Hi Sam,

I don't know if you wanted external feedback on all of the bits, or just the
one you explicitly asked for... but, I generally overshare, so here ya go...

> > <TMPL_IF NAME="item ne 'pizza' && price != 0.99">

> I really don't like putting expressions into the NAME attribute.  I think
> EXPR, as used in HTML::Template::Expr, is a better choice.

I'd have to agree, there shouldn't be a need to make the name of a variable
into a variable.

>> 3. add a new way to access outside variables without global_vars
>>
>> 		This is a normal variable: <TMPL_VAR NORMAL>.<P>
>> 		<TMPL_LOOP NAME=FROOT_LOOP>
>> 		   Use it inside the loop: <TMPL_VAR __NORMAL><P>
>> 		</TMPL_LOOP>

> I really don't like this.  How is an HTML designer supposed to understand
> this bizarre syntax?

I have to agree with that. Teaching an HTML designer the concept of variable
scope is a dangerous proposition.

> Some people will like this, I imagine.  Maybe call it "DEFAULT"?  I think
> I might take this as a separate patch.  What do others think?

I think a DEFAULT="" is a great idea.

>> 5. add TMPL_DEF tag for defining new parameters
>>
>>         <TMPL_DEF NAME="NAME" VALUE="value">

>I don't like this.  Mixing display logic with setup of variables is a very
>dangerous thing.

I don't even know what this is really useful for? If you are hard coding the
definition of a variable in your template, why can't you just hard code that
variable where you use it?

Kenny Smith
JournalScape.com