Re: [htdig-dev] rundig: htdig -i and bug #1123810

[Ahmon D. <da...@fr...>]

>> > #1: bug #1123810 seems like an important bug with an easy fix.  What
>> >  are the chances of getting it in?  I had a look at rundig in the CVS
>> >  repository and it looks like it's still not done.
>> 
>>   Please submit the fix.

(diff against the trunk)
Index: installdir/rundig
===================================================================
RCS file: /cvsroot/htdig/htdig/installdir/rundig,v
retrieving revision 1.9
diff -u -r1.9 rundig
--- installdir/rundig	29 Dec 2003 08:49:05 -0000	1.9
+++ installdir/rundig	1 Mar 2006 23:44:16 -0000
@@ -30,7 +30,6 @@
 done
 
 # If -a specified, note the database directory to move the temp files correctly
-# TODO: Should also check for files relative to COMMONDIR.
 if [ -f "$conffile" ]
 then
     new_db_dir=`awk '/^[^#a-zA-Z]*database_dir/ { print $NF }' < $conffile`
@@ -38,6 +37,11 @@
     then
 	DBDIR=$new_db_dir
     fi
+    new_dir=`awk '/^[^#a-zA-Z]*common_dir/ { print $NF }' < $conffile`
+    if [ "$new_dir" != "" ]
+    then
+	COMMONDIR=$new_dir
+    fi
 else
     echo "Config file $conffile cannot be found"
     exit 1


>> 
>> > #2: How come rundig calls htdig with the -i flag by default?  Doing
>> >  so makes it impossible (as far as I can tell) to use rundig to do
>> >  incremental indexing.  
>> > 
>> 
>>   Correct!  I don't use rundig myself..

So... what do we do about it?  I think rundig would be fine (w/ the
COMMONDIR fix above) and the removal of the default -i flag.  

>> FYI:  A couple of us are in the process of reworking HtDig's code code for 
>> HtDig 4.0.  You can see the progress reports here
>> 
>> http://htdig.blogspot.org & http://opensource.rightnow.com/htdig.php

I checked it out.  It looks promising!

>> I think the current version in the trunk of CVS is more or less
>> DEAD.

Alright.  I'm using the htdig rpm from Fedora Core 4.  I can just
submit patches to whoever is maintaining the package at Redhat.
However, I do want to make sure that the patches are agreeable to you
first.